SM event notification datasource should not fail when no registration exists (#6692)

Author: haimsch

ibm/service/secretsmanager/data_source_ibm_sm_en_registration.go

@@ -42,11 +42,16 @@ func dataSourceIbmSmEnRegistrationRead(context context.Context, d *schema.Resour
 
 	getNotificationsRegistrationOptions := &secretsmanagerv2.GetNotificationsRegistrationOptions{}
 
+	enInstanceCrn := "" // default value if event notification registration doesn't exist
 	notificationsRegistration, response, err := secretsManagerClient.GetNotificationsRegistrationWithContext(context, getNotificationsRegistrationOptions)
 	if err != nil {
-		log.Printf("[DEBUG] GetNotificationsRegistrationWithContext failed %s\n%s", err, response)
-		tfErr := flex.TerraformErrorf(err, fmt.Sprintf("GetNotificationsRegistrationWithContext failed %s\n%s", err, response), fmt.Sprintf("(Data) %s", EnRegistrationResourceName), "read")
-		return tfErr.GetDiag()
+		if response.StatusCode != 404 {
+			log.Printf("[DEBUG] GetNotificationsRegistrationWithContext failed %s\n%s", err, response)
+			tfErr := flex.TerraformErrorf(err, fmt.Sprintf("GetNotificationsRegistrationWithContext failed %s\n%s", err, response), fmt.Sprintf("(Data) %s", EnRegistrationResourceName), "read")
+			return tfErr.GetDiag()
+		}
+	} else {
+		enInstanceCrn = *notificationsRegistration.EventNotificationsInstanceCrn
 	}
 
 	d.SetId(fmt.Sprintf("%s/%s", region, instanceId))
@@ -55,7 +60,7 @@ func dataSourceIbmSmEnRegistrationRead(context context.Context, d *schema.Resour
 		tfErr := flex.TerraformErrorf(err, fmt.Sprintf("Error setting region"), fmt.Sprintf("(Data) %s", EnRegistrationResourceName), "read")
 		return tfErr.GetDiag()
 	}
-	if err = d.Set("event_notifications_instance_crn", notificationsRegistration.EventNotificationsInstanceCrn); err != nil {
+	if err = d.Set("event_notifications_instance_crn", enInstanceCrn); err != nil {
 		tfErr := flex.TerraformErrorf(err, fmt.Sprintf("Error setting event_notifications_instance_crn"), fmt.Sprintf("(Data) %s", EnRegistrationResourceName), "read")
 		return tfErr.GetDiag()
 	}

website/docs/d/sm_en_registration.html.markdown

@@ -33,6 +33,5 @@ Review the argument reference that you can specify for your data source.
 In addition to all argument references listed, you can access the following attribute references after your data source is created.
 
 * `id` - The unique identifier of the data source.
-* `event_notifications_instance_crn` - (String) A CRN that uniquely identifies an IBM Cloud resource.
-  * Constraints: The maximum length is `512` characters. The minimum length is `9` characters. The value must match regular expression `/^crn:v[0-9](:([A-Za-z0-9-._~!$&'()*+,;=@\/]|%[0-9A-Z]{2})*){8}$/`.
+* `event_notifications_instance_crn` - (String) A CRN that uniquely identifies an IBM Cloud resource. If event notification registration does not exist for the Secret Mnager instance the value is an empty string.