-
Notifications
You must be signed in to change notification settings - Fork 711
Helios reporting apis support #6309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Helios reporting apis support #6309
Conversation
| Summary: "Update Not Supported", | ||
| Detail: "The resource definition will be only be removed from the terraform statefile. This resource cannot be deleted from the backend. ", | ||
| } | ||
| diags = append(diags, warning) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we remove in update also?
Then will not it show a new resource far every apply?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hkantare It won’t create a new resource on every apply because Terraform keeps the ID in state and our Read is a no-op, so subsequent applies see the resource as already existing and don’t call Create again.
| } | ||
|
|
||
| func resourceIbmBackupRecoveryManagerCreateClusterUpgradesUpdate(context context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics { | ||
| // This resource does not support a "delete" operation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above comment
|
|
||
| # Syntax | ||
| <pre> | ||
| $ terraform import ibm_backup_recovery_manager_cancel_cluster_upgrades.backup_recovery_manager_cancel_cluster_upgrades <id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ID is some time stamp , how will import helps the customer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for all resource docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hkantare
These 3 resources do not support import.
Have updated the same in doc for each resource.
| Schema: map[string]*schema.Schema{ | ||
| "cluster_identifiers": &schema.Schema{ | ||
| Type: schema.TypeList, | ||
| Optional: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it optional ?
We don't have any field with required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hkantare
Have updated cluster_identifiers as required (same for the remaining resources)
| ```hcl | ||
| resource "ibm_backup_recovery_manager_create_cluster_upgrades" "backup_recovery_manager_create_cluster_upgrades_instance" { | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we have mismatch between schema vs doc arguments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hkantare
Updated the docs
Community Note
Relates OR Closes #0000
Output from acceptance testing: