fix: Add EC build support logic in OCP installer download task (#430)

This PR introduces logic updates in the
roles/download_ocp_installer/tasks/main.yaml file to enable automated
handling of Early Candidate (EC) builds for OpenShift.
The code now dynamically selects the appropriate download URL based on
the installer version pattern.

Changes Introduced:
Added conditional check for EC builds (-ec in version string).
Routes EC build downloads to:

https://mirror.openshift.com/pub/openshift-v4/s390x/clients/ocp-dev-preview/
Maintains existing logic for regular builds from:
https://mirror.openshift.com/pub/openshift-v4/s390x/clients/ocp/
No changes to all.yaml or inventory inputs — logic is handled directly
in code.
Verified backward compatibility with standard build versions.

Testing Done:

✅ Tested with both EC (4.21.0-ec.2) and non-EC (4.20.2) versions.
✅ Verified correct URL resolution in ansible-playbook debug logs.
✅ Confirmed successful download and extraction of installer and client
binaries.

Impact:

Simplifies EC build handling without requiring manual URL updates.
Keeps ABI automation compatible with both GA and EC releases.
No breaking changes for existing playbooks.

Signed-off-by: Neeraj Mishra <[email protected]>
Co-authored-by: Neeraj Mishra <[email protected]>

Author: Neeraj8418

roles/download_ocp_installer/tasks/main.yaml

@@ -1,49 +1,73 @@
 ---
+# Section: Download OpenShift Installer (fips=false)
 - name: Download OpenShift Installer (fips=false)
   ansible.builtin.get_url:
-    url: "{{ abi.ocp_installer_base_url }}/{{ abi.architecture | lower }}/clients/ocp/{{ abi.ocp_installer_version }}/{{ 's390x/' if abi.architecture | lower == 'multi' else '' }}{{ ocp_install_tgz }}"
+    url: >-
+      {{ (abi.ocp_installer_base_url ~ '/' ~ (abi.architecture | lower) ~ '/clients/' ~
+      ('ocp-dev-preview' if '-ec' in abi.ocp_installer_version else 'ocp') ~ '/' ~
+      abi.ocp_installer_version ~ '/' ~
+      ('s390x/' if abi.architecture | lower == 'multi' else '') ~
+      ocp_install_tgz) | replace(' ', '') }}
     dest: "/tmp/{{ ocp_install_tgz }}"
     mode: '0640'
     validate_certs: false
   when: not install_config_vars.fips
 
+# Section: Download OpenShift Installer (fips=true)
 - name: Download OpenShift Installer (fips=true)
   ansible.builtin.get_url:
-    url: "{{ abi.ocp_installer_base_url }}/{{ abi.architecture | lower }}/clients/ocp/{{ abi.ocp_installer_version }}/{{ 's390x/' if abi.architecture | lower == 'multi' else '' }}{{ ocp_install_fips_tgz }}-{{ install_config_vars.control.architecture | lower }}.tar.gz"
+    url: >-
+      {{ (abi.ocp_installer_base_url ~ '/' ~ (abi.architecture | lower) ~ '/clients/' ~
+      ('ocp-dev-preview' if '-ec' in abi.ocp_installer_version else 'ocp') ~ '/' ~
+      abi.ocp_installer_version ~ '/' ~
+      ('s390x/' if abi.architecture | lower == 'multi' else '') ~
+      ocp_install_fips_tgz ~ '-' ~ (install_config_vars.control.architecture | lower) ~ '.tar.gz')
+      | replace(' ', '') }}
     dest: "/tmp/{{ ocp_install_fips_tgz }}-{{ install_config_vars.control.architecture | lower }}.tar.gz"
     mode: '0640'
     validate_certs: false
   when: install_config_vars.fips
 
+# Section: Extract OpenShift Installer (fips=false)
 - name: Extract OpenShift Installer (fips=false)
   ansible.builtin.unarchive:
     src: "/tmp/{{ ocp_install_tgz }}"
     dest: /usr/local/bin
     remote_src: true
   when: not install_config_vars.fips
 
+# Section: Extract OpenShift Installer (fips=true)
 - name: Extract OpenShift Installer (fips=true)
   ansible.builtin.unarchive:
     src: "/tmp/{{ ocp_install_fips_tgz }}-{{ install_config_vars.control.architecture | lower }}.tar.gz"
     dest: /usr/local/bin
     remote_src: true
   when: install_config_vars.fips
 
+# Section: Download OpenShift Client
 - name: Download OpenShift Client
   ansible.builtin.get_url:
-    url: "{{ abi.ocp_installer_base_url }}/{{ abi.architecture | lower }}/clients/ocp/{{ abi.ocp_installer_version }}/{{ 's390x/' if abi.architecture | lower == 'multi' else '' }}{{ ocp_client_tgz }}"
+    url: >-
+      {{ (abi.ocp_installer_base_url ~ '/' ~ (abi.architecture | lower) ~ '/clients/' ~
+      ('ocp-dev-preview' if '-ec' in abi.ocp_installer_version else 'ocp') ~ '/' ~
+      abi.ocp_installer_version ~ '/' ~
+      ('s390x/' if abi.architecture | lower == 'multi' else '') ~
+      ocp_client_tgz) | replace(' ', '') }}
     dest: "/tmp/{{ ocp_client_tgz }}"
     mode: '0755'
     validate_certs: false
 
+# Section: Extract OpenShift Client
 - name: Extract OpenShift Client
   ansible.builtin.unarchive:
     src: "/tmp/{{ ocp_client_tgz }}"
     dest: /usr/local/bin
     remote_src: true
 
+# Section: Install NMState package
 - name: Install NMState package
   ansible.builtin.yum:
     name: nmstate
     state: latest
     skip_broken: true
+