test: test for missing graphite in config (#73)

fix for #72

Signed-off-by: Ricky Moorhouse <[email protected]>

Author: rickymoorhouse

test-assets/no-graphite.yaml

@@ -0,0 +1,11 @@
+# Example configuration file
+prometheus:
+  port: 63512 
+  enabled: true
+nets:
+  datapower:
+    enabled: true
+  manager:
+    enabled: true
+trawler:
+  use_kubeconfig: true

test_trawler.py

@@ -74,6 +74,12 @@ def test_check_nosettings():
     assert result.exit_code == 2
 
 
+def test_check_config_load_nographite():
+    boaty2 = trawler.Trawler('test-assets/no-graphite.yaml')
+    assert 'prometheus' in boaty2.config
+    assert 'graphite' not in boaty2.config
+
+
 def test_check_config_load():
     boaty.load_config('test-assets/config.yaml')
     assert 'prometheus' in boaty.config

trawler.py

@@ -52,8 +52,9 @@ def __init__(self, config_file=None):
             port = self.config['prometheus'].get('port')
             logger.info('Starting prometheus http port at http://0.0.0.0:{}'.format(port))
             start_http_server(port)
-        if self.config['graphite']['enabled']:
-            self.graphite = metrics_graphite.instance(self.config['graphite'])
+        if 'graphite' in self.config:
+            if self.config['graphite']['enabled']:
+                self.graphite = metrics_graphite.instance(self.config['graphite'])
 
         use_kubeconfig = False
         if 'trawler' in self.config: