fix: catch invalid labels exception

Author: rickymoorhouse

datapower_net.py

@@ -224,22 +224,29 @@ def fetch_data(self, provider, label, suffix=''):
                                 verify=False, timeout=1).json()
             logger.debug(status)
             data = status.get(provider, {})
+            labels = self.labels
             if type(data) is list:
                 for item in data:
                     try:
                         name = item[provider.replace('Status', '')]['value']
                         del(item[provider.replace('Status', '')])
                         logger.debug(item)
                         for key in item:
-                            self.trawler.set_gauge('datapower',
-                                                "{}.{}.{}{}".format(label, name, key, suffix), item[key], 
-                                                pod_name=self.name, labels=self.labels)
+                            self.trawler.set_gauge(
+                                'datapower',
+                                "{}.{}.{}{}".format(label, name, key, suffix), item[key], 
+                                pod_name=self.name, labels=self.labels)
                     except KeyError:
                         logger.warning('Failed to parse response for {}'.format(provider))
                         logger.info(item)
             else:
                 for key in data:
-                    self.trawler.set_gauge('datapower', "{}_{}{}".format(label, key, suffix), data[key], pod_name=self.name, labels=self.labels)
+                    self.trawler.set_gauge(
+                        'datapower', 
+                        "{}_{}{}".format(label, key, suffix), 
+                        data[key], 
+                        pod_name=self.name, 
+                        labels=labels)
         except requests.exceptions.RequestException as e:
             logger.info("{}: {} (Check rest-mgmt is enabled and you have network connectivity)".format(provider, e.strerror))
 
@@ -342,15 +349,15 @@ def invoke_api(self, api):
                 'datapower',
                 "invoke_api_{}_status_total".format(api['name']),
                 1,
-                pod_name=self.name, labels=self.labels)
+                pod_name=self.name, labels=status_labels)
         except requests.RequestException:
             status_labels = self.labels
             status_labels['code'] = '000'
             self.trawler.set_gauge(
                 'datapower',
                 "invoke_api_{}_status_total".format(api['name']),
                 0,
-                pod_name=self.name, labels=self.labels)
+                pod_name=self.name, labels=status_labels)
 
 if __name__ == "__main__":
     net = DataPowerNet()

trawler.py

@@ -116,10 +116,13 @@ def set_gauge(self, component, target_name, value, pod_name=None, labels=None):
 
                 logger.debug("Setting gauge %s to %f",
                     self.gauges[prometheus_target]._name, value)
-                if labels:
-                    self.gauges[prometheus_target].labels(**labels).set(value)
-                else:
-                    self.gauges[prometheus_target].set(value)
+                try:
+                    if labels:
+                        self.gauges[prometheus_target].labels(**labels).set(value)
+                    else:
+                        self.gauges[prometheus_target].set(value)
+                except ValueError as valueException:
+                    self.logger.exception(valueException)
             if self.config['graphite']['enabled']:
                 if pod_name:
                     metric_name = "{}.{}.{}".format(component, pod_name, target_name)