Skip to content

Commit 899a0fe

Browse files
author
John Lubinski
committed
Make daemonset mountPropagation configurable, remove bidirectional default
Signed-off-by: John Lubinski <john.lubinski@chicagotrading.com>
1 parent c315d2d commit 899a0fe

File tree

3 files changed

+20
-0
lines changed

3 files changed

+20
-0
lines changed

charts/core-dump-handler/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -334,6 +334,7 @@ Daemonset
334334
* envFrom: Array of [EnvFromSource](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.25/#envfromsource-v1-core) to inject into main container.
335335
* sidecarContainers: Array of [Container](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.25/#container-v1-core) to define as part of the pod.
336336
* updateStrategy: [DaemonsetUpdateStrategy](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.25/#daemonsetupdatestrategy-v1-apps) is a struct used to control the update strategy for the DaemonSet.
337+
* mountPropagation: [Mount propagation](https://kubernetes.io/docs/concepts/storage/volumes/#mount-propagation) mode for core dump volumes. (Default "")
337338
338339
Service account:
339340
* useToken: automatically create a service account token secret

charts/core-dump-handler/templates/_helpers.tpl

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,24 @@ Basically copied from https://github.com/bitnami/charts/blob/master/bitnami/comm
8686
mountPath: {{ .Values.daemonset.eventDirectory }}
8787
mountPropagation: Bidirectional
8888
{{- end }}
89+
{{- define "core-dump-handler.daemonset.container.volumeMounts" -}}
90+
- name: host-volume
91+
mountPath: {{ .Values.daemonset.hostDirectory }}
92+
{{- if .Values.daemonset.mountPropagation }}
93+
mountPropagation: {{ .Values.daemonset.mountPropagation }}
94+
{{- end }}
95+
- name: core-volume
96+
mountPath: {{ .Values.daemonset.coreDirectory }}
97+
{{- if .Values.daemonset.mountPropagation }}
98+
mountPropagation: {{ .Values.daemonset.mountPropagation }}
99+
{{- end }}
100+
{{- if .Values.composer.coreEvents }}
101+
- name: event-volume
102+
mountPath: {{ .Values.daemonset.eventDirectory }}
103+
{{- if .Values.daemonset.mountPropagation }}
104+
mountPropagation: {{ .Values.daemonset.mountPropagation }}
105+
{{- end }}
106+
{{- end }}
89107
{{- if .Values.daemonset.mountContainerRuntimeEndpoint }}
90108
- mountPath: {{ .Values.daemonset.hostContainerRuntimeEndpoint }}
91109
name: container-runtime

charts/core-dump-handler/values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ daemonset:
6060
envFrom: []
6161
sidecarContainers: []
6262
updateStrategy: {}
63+
mountPropagation: ""
6364

6465
serviceAccount:
6566
create: true

0 commit comments

Comments
 (0)