Skip to content

Commit f66c628

Browse files
committed
feat(daemonset): functionality for user defined labels
Signed-off-by: David Kohl <david.kohl@vonage.com>
1 parent c315d2d commit f66c628

File tree

4 files changed

+13
-3
lines changed

4 files changed

+13
-3
lines changed

.github/workflows/lint-test.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- name: Set up Python
2222
uses: actions/setup-python@v2
2323
with:
24-
python-version: 3.7
24+
python-version: 3.14.2
2525

2626
- name: Set up chart-testing
2727
uses: helm/chart-testing-action@v2.1.0
@@ -42,4 +42,4 @@ jobs:
4242
# if: steps.list-changed.outputs.changed == 'true'
4343

4444
# - name: Run chart-testing (install)
45-
# run: ct install --config ct.yaml
45+
# run: ct install --config ct.yaml

charts/core-dump-handler/templates/daemonset.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ spec:
1414
metadata:
1515
labels:
1616
name: {{ .Values.daemonset.label }}
17+
{{- with .Values.daemonset.labels }}
18+
{{- toYaml . | nindent 8 }}
19+
{{- end }}
1720
annotations:
1821
kubectl.kubernetes.io/default-container: "coredump-container"
1922
{{- with .Values.daemonset.podAnnotations }}

charts/core-dump-handler/values.schema.json

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,12 @@
206206
"name": {
207207
"type": "string"
208208
},
209+
"labels": {
210+
"type": "object",
211+
"additionalProperties": {
212+
"type": "string"
213+
}
214+
},
209215
"label": {
210216
"type": "string"
211217
},
@@ -352,4 +358,4 @@
352358
"title": "ServiceAccount"
353359
}
354360
}
355-
}
361+
}

charts/core-dump-handler/values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ daemonset:
3737
podAnnotations: {}
3838
name: "core-dump-handler"
3939
label: "core-dump-ds"
40+
labels: {}
4041
hostDirectory: "/var/mnt/core-dump-handler"
4142
coreDirectory: "/var/mnt/core-dump-handler/cores"
4243
eventDirectory: "/var/mnt/core-dump-handler/events"

0 commit comments

Comments
 (0)