Skip to content

Commit 5333dab

Browse files
Fix makefile syntax errors and fix Trivy vulnerabilities (#224)
* Fix syntax errors in Makefile Signed-off-by: Victoria Miltcheva <[email protected]> * Cleanup Signed-off-by: Victoria Miltcheva <[email protected]> * Align slashes Signed-off-by: Victoria Miltcheva <[email protected]> * Indent Makefile with spaces instead of tabs Signed-off-by: Victoria Miltcheva <[email protected]> * Actually fix Makefile Signed-off-by: Victoria Miltcheva <[email protected]> * Update pipenv version Signed-off-by: Victoria Miltcheva <[email protected]> --------- Signed-off-by: Victoria Miltcheva <[email protected]>
1 parent 5c3db0e commit 5333dab

File tree

3 files changed

+106
-107
lines changed

3 files changed

+106
-107
lines changed

Makefile

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -198,14 +198,13 @@ quality-images:
198198

199199
.PHONY: deploy
200200
deploy:
201-
skaffold build
201+
skaffold build; \
202202
for image in $(shell skaffold build -q --dry-run | jq -r .builds[].tag); do \
203-
@echo "Signing image $${image}"; \
204-
$(COSIGN) sign --key env://COSIGN_PRIVATE_KEY --yes $${image}; \
205-
206-
@echo "Verifying image $${image}; \
207-
$(COSIGN) verify --key env://COSIGN_PUBLIC_KEY $${image}; \
208-
done;
203+
@echo "Signing image" ${image}"; \
204+
$(COSIGN) sign --key env://COSIGN_PRIVATE_KEY --yes $${image}; \
205+
@echo "Verifying image ${image}; \
206+
$(COSIGN) verify --key env://COSIGN_PUBLIC_KEY $${image}; \
207+
done; \
209208

210209
.PHONY: clean
211210
clean:

Pipfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ unittest2 = "==1.1.0"
1111
pre-commit = "==2.18.1"
1212
flake8 = "==4.0.1"
1313
autopep8 = "==1.6.0"
14-
pipenv = "==2023.2.4"
14+
pipenv = "==2023.4.20"
1515
pep8-naming = "==0.12.1"
1616
pytest-cov = "==3.0.0"
1717

Pipfile.lock

Lines changed: 99 additions & 99 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)