Skip to content

Commit eb800c2

Browse files
committed
Include all architectures in a single release
Signed-off-by: Ilya Leoshkevich <[email protected]>
1 parent db88ee0 commit eb800c2

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

.github/workflows/dotnet.yml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -249,11 +249,6 @@ jobs:
249249
needs: installer
250250
runs-on: ubuntu-latest
251251
if: ${{ github.event_name == 'push' && github.ref_type == 'tag' }}
252-
strategy:
253-
matrix:
254-
# TODO: aspnetcore build fails on x64 with:
255-
# EXEC : error : Failed to load assembly 'System.Private.CoreLib'
256-
arch: [ppc64le, s390x]
257252
container:
258253
image: ghcr.io/ibm/dotnet-${{ matrix.arch }}-toolchain:latest
259254
credentials:
@@ -270,10 +265,14 @@ jobs:
270265
uses: actions/checkout@v1 # Newer versions are not compatible with Ubuntu 18.04
271266
- name: Fix the repository ownership
272267
run: chown -R "$(id -u):$(id -g)" .
273-
- name: Download the installer artifacts
268+
- name: Download the ppc64le installer artifacts
274269
uses: actions/download-artifact@v3 # Newer versions are not compatible with Ubuntu 18.04
275270
with:
276-
name: installer-${{ matrix.arch }}
271+
name: installer-ppc64le
272+
- name: Download the s390x installer artifacts
273+
uses: actions/download-artifact@v3 # Newer versions are not compatible with Ubuntu 18.04
274+
with:
275+
name: installer-s390x
277276
- name: Create a release
278277
run: gh release create --notes "" "${{ github.ref_name }}" output/*
279278
env:

.github/workflows/dotnet.yml.j2

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,16 @@ on:
1212
- 'v*'
1313
pull_request:
1414

15+
{%- set arches = ['ppc64le', 's390x'] -%}
16+
1517
{%- set projects = ['runtime', 'msbuild', 'roslyn', 'sdk', 'aspnetcore', 'installer'] %}
1618

1719
{%- set matrix -%}
1820
strategy:
1921
matrix:
2022
# TODO: aspnetcore build fails on x64 with:
2123
# EXEC : error : Failed to load assembly 'System.Private.CoreLib'
22-
arch: [ppc64le, s390x]
24+
arch: [{{ ', '.join(arches) }}]
2325
{%- endset %}
2426

2527
{%- set container -%}
@@ -83,14 +85,15 @@ jobs:
8385
needs: installer
8486
runs-on: ubuntu-latest
8587
if: {% raw %}${{ github.event_name == 'push' && github.ref_type == 'tag' }}{% endraw %}
86-
{{ matrix }}
8788
{{ container }}
8889
steps:
8990
{{ checkout_steps }}
90-
- name: Download the installer artifacts
91+
{%- for arch in arches %}
92+
- name: Download the {{ arch }} installer artifacts
9193
uses: actions/download-artifact@v3 # Newer versions are not compatible with Ubuntu 18.04
9294
with:
93-
name: installer-{% raw %}${{ matrix.arch }}{% endraw %}
95+
name: installer-{{ arch }}
96+
{%- endfor %}
9497
- name: Create a release
9598
run: gh release create --notes "" "{% raw %}${{ github.ref_name }}{% endraw %}" output/*
9699
env:

0 commit comments

Comments
 (0)