better response error handling

[aharbis]

On success we get back a SOAP envelope that looks something like this:

<?xml version="1.0" encoding="UTF-8"?>
<env:Envelope xmlns:env="http://schemas.xmlsoap.org/soap/envelope/">
  <env:Body>
    <dp:response xmlns:dp="http://www.datapower.com/schemas/management">
      <dp:timestamp>2019-09-18T12:42:33-04:00</dp:timestamp>
      <dp:import>
        <import-results domain="sandbox">
          <export-details>
            <description>Exported Configuration</description>
            <user>admin</user>
            <domain>mc</domain>
            <comment />
            <product-id>software</product-id>
            <product>IDG</product>
            <display-product>IDG</display-product>
            <model>IBM DataPower Gateway</model>
            <display-model>IBM DataPower Gateway</display-model>
            <device-name>4ba3062fcf13</device-name>
            <serial-number>0000001</serial-number>
            <firmware-version>IDG.2018.4.1.6</firmware-version>
            <display-firmware-version>IDG.2018.4.1.6</display-firmware-version>
            <firmware-build>309660</firmware-build>
            <delivery-type>LTS</delivery-type>
            <firmware-timestamp>2019/06/06 06:33:26</firmware-timestamp>
            <current-date>2019-06-18</current-date>
            <current-time>10:25:53 EDT</current-time>
            <reset-date>2019-06-14</reset-date>
            <reset-time>13:53:46 EDT</reset-time>
            <login-message />
            <custom-ui-file />
          </export-details>
          <imported-files>
            <file name="local:///HelloService.wsdl" src="local/HelloService.wsdl" status="same" overwrite="off" />
            <file name="webgui:///clixform.xsl" src="dp-aux/clixform.xsl" status="internal" overwrite="off" />
            <file name="webgui:///SchemaUtil.xsl" src="dp-aux/SchemaUtil.xsl" status="internal" overwrite="off" />
            <file name="webgui:///management.xsl" src="dp-aux/management.xsl" status="internal" overwrite="off" />
            <file name="webgui:///map-dmz.xsl" src="dp-aux/map-dmz.xsl" status="internal" overwrite="off" />
            <file name="webgui:///drMgmt.xml" src="dp-aux/drMgmt.xml" status="internal" overwrite="off" />
            <file name="webgui:///basetypes.xml" src="dp-aux/basetypes.xml" status="internal" overwrite="off" />
          </imported-files>
          <imported-objects><object class="HTTPUserAgent" name="default" status="exists" import-debug="false"
              overwrite="off" /><object class="XMLManager" name="default" status="exists" import-debug="false"
              overwrite="off" /><object class="HTTPSourceProtocolHandler" name="http_4443" status="exists"
              import-debug="false" overwrite="off" /><object class="WSEndpointRewritePolicy" name="MC_1" status="exists"
              import-debug="false" overwrite="off" /><object class="Matching" name="MC_1_match_all" status="exists"
              import-debug="false" overwrite="off" /><object class="SLMPolicy" name="MC_1" status="exists"
              import-debug="false" overwrite="off" /><object class="StylePolicyAction"
              name="MC_1_default_request-rule_defaultaction_slm" status="exists" import-debug="false"
              overwrite="off" /><object class="StylePolicyAction" name="MC_1_default_request-rule_defaultaction_result"
              status="exists" import-debug="false" overwrite="off" /><object class="WSStylePolicyRule"
              name="MC_1_default_request-rule" status="exists" import-debug="false" overwrite="off" /><object
              class="StylePolicyAction" name="MC_1_default_response-rule_defaultaction_result" status="exists"
              import-debug="false" overwrite="off" /><object class="WSStylePolicyRule" name="MC_1_default_response-rule"
              status="exists" import-debug="false" overwrite="off" /><object class="WSStylePolicy" name="MC_1"
              status="exists" import-debug="false" overwrite="off" /><object class="PolicyAttachments"
              name="MC_1_HelloService.wsdl" status="exists" import-debug="false" overwrite="off" /><object
              class="WSGateway" name="MC_1" status="new" import-debug="false" overwrite="off" /></imported-objects>
          <file-copy-log>
            <file-result name="local:///HelloService.wsdl" result="ignored">
              <reason>Identical file exists</reason>
            </file-result>
          </file-copy-log>
          <exec-script-results>
            <cfg-result class="HTTPUserAgent" name="default" status="skipped" />
            <cfg-result class="XMLManager" name="default" status="skipped" />
            <cfg-result class="HTTPSourceProtocolHandler" name="http_4443" status="skipped" />
            <cfg-result class="WSEndpointRewritePolicy" name="MC_1" status="skipped" />
            <cfg-result class="Matching" name="MC_1_match_all" status="skipped" />
            <cfg-result class="SLMPolicy" name="MC_1" status="skipped" />
            <cfg-result class="StylePolicyAction" name="MC_1_default_request-rule_defaultaction_slm" status="skipped" />
            <cfg-result class="StylePolicyAction" name="MC_1_default_request-rule_defaultaction_result"
              status="skipped" />
            <cfg-result class="WSStylePolicyRule" name="MC_1_default_request-rule" status="skipped" />
            <cfg-result class="StylePolicyAction" name="MC_1_default_response-rule_defaultaction_result"
              status="skipped" />
            <cfg-result class="WSStylePolicyRule" name="MC_1_default_response-rule" status="skipped" />
            <cfg-result class="WSStylePolicy" name="MC_1" status="skipped" />
            <cfg-result class="PolicyAttachments" name="MC_1_HelloService.wsdl" status="skipped" />
            <cfg-result class="WSGateway" name="MC_1" status="SUCCESS" />
          </exec-script-results>
        </import-results>
      </dp:import>
    </dp:response>
  </env:Body>
</env:Envelope>

for failure targeting an invalid domain we seem to get back an Authentication failure:

<?xml version="1.0" encoding="UTF-8"?>
<env:Envelope xmlns:env="http://schemas.xmlsoap.org/soap/envelope/">
  <env:Body>
    <dp:response xmlns:dp="http://www.datapower.com/schemas/management">
      <dp:result>Authentication failure</dp:result>
    </dp:response>
  </env:Body>
</env:Envelope>

and trying to upload an invalid archive package yields:

<?xml version="1.0" encoding="UTF-8"?>
<env:Envelope xmlns:env="http://schemas.xmlsoap.org/soap/envelope/">
  <env:Body>
    <dp:response xmlns:dp="http://www.datapower.com/schemas/management">
      <dp:timestamp>2019-09-18T12:46:58-04:00</dp:timestamp>
      <dp:result>ERROR</dp:result>
    </dp:response>
  </env:Body>
</env:Envelope>

[aharbis]

The bug with this is that on the two failure cases we still log a success, because xml-mgmt returns a 200 regardless. Need a more strict check and validation of the response XML to validate if the request was successful or not.

[aharbis]

code in question is here

dp-config-batch-import/dp_config_batch_import/__init__.py

Lines 79 to 86 in d93a448

	if r.status_code == 200:
	print('File uploaded successfully')
	if VERBOSE:
	print(r.text)
	else:
	print('File upload failed:')
	print(r.text)
	exit()