Skip to content

Commit 415db83

Browse files
Quality of life add to make container tool variable replace hard coded docker (#2738)
Signed-off-by: Jeremy Cheng <jeremyjcheng@gmail.com>
1 parent b530f15 commit 415db83

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

Makefile

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -197,16 +197,16 @@ deploy: manifests ## Deploy controller in the configured Kubernetes cluster in ~
197197

198198
build-dev-image: cloudpak-theme.jar
199199
@echo "Building the $(OPERATOR_IMAGE_NAME) docker dev image for $(LOCAL_ARCH)..."
200-
@docker build -t $(REGISTRY)/$(OPERATOR_IMAGE_NAME)-$(LOCAL_ARCH):dev \
200+
@$(CONTAINER_TOOL) build -t $(REGISTRY)/$(OPERATOR_IMAGE_NAME)-$(LOCAL_ARCH):dev \
201201
--build-arg VCS_REF=$(VCS_REF) --build-arg RELEASE_VERSION=$(RELEASE_VERSION) \
202202
--build-arg GOARCH=$(LOCAL_ARCH) -f Dockerfile .
203-
@docker push $(REGISTRY)/$(OPERATOR_IMAGE_NAME)-$(LOCAL_ARCH):dev
203+
@$(CONTAINER_TOOL) push $(REGISTRY)/$(OPERATOR_IMAGE_NAME)-$(LOCAL_ARCH):dev
204204

205205
build-bundle-image: yq
206206
@cp -f bundle/manifests/ibm-common-service-operator.clusterserviceversion.yaml /tmp/ibm-common-service-operator.clusterserviceversion.yaml
207207
$(YQ) eval -i 'del(.spec.replaces)' bundle/manifests/ibm-common-service-operator.clusterserviceversion.yaml
208-
docker build -f bundle.Dockerfile -t $(QUAY_REGISTRY)/$(BUNDLE_IMAGE_NAME):$(BUILD_VERSION) .
209-
docker push $(QUAY_REGISTRY)/$(BUNDLE_IMAGE_NAME):$(BUILD_VERSION)
208+
$(CONTAINER_TOOL) build -f bundle.Dockerfile -t $(QUAY_REGISTRY)/$(BUNDLE_IMAGE_NAME):$(BUILD_VERSION) .
209+
$(CONTAINER_TOOL) push $(QUAY_REGISTRY)/$(BUNDLE_IMAGE_NAME):$(BUILD_VERSION)
210210
@mv /tmp/ibm-common-service-operator.clusterserviceversion.yaml bundle/manifests/ibm-common-service-operator.clusterserviceversion.yaml
211211

212212
run-bundle:
@@ -219,8 +219,8 @@ cleanup-bundle:
219219
$(OPERATOR_SDK) cleanup ibm-common-service-operator
220220

221221
build-catalog-source:
222-
opm -u docker index add --bundles $(QUAY_REGISTRY)/$(BUNDLE_IMAGE_NAME):$(BUILD_VERSION) --tag $(QUAY_REGISTRY)/$(OPERATOR_IMAGE_NAME)-catalog:$(BUILD_VERSION)
223-
docker push $(QUAY_REGISTRY)/$(OPERATOR_IMAGE_NAME)-catalog:$(BUILD_VERSION)
222+
opm -u $(CONTAINER_TOOL) index add --bundles $(QUAY_REGISTRY)/$(BUNDLE_IMAGE_NAME):$(BUILD_VERSION) --tag $(QUAY_REGISTRY)/$(OPERATOR_IMAGE_NAME)-catalog:$(BUILD_VERSION)
223+
$(CONTAINER_TOOL) push $(QUAY_REGISTRY)/$(OPERATOR_IMAGE_NAME)-catalog:$(BUILD_VERSION)
224224

225225
update-csv-image: # updates operator image in currently deployed Common Service Operator
226226
oc patch csv -n ibm-common-services ibm-common-service-operator.v$(RELEASE_VERSION) --type json -p \
@@ -329,7 +329,7 @@ build-push-image: config-docker build-operator-image ## Build and push the oper
329329

330330
.PHONY: docker-push
331331
docker-push:
332-
docker push $(IMG)
332+
$(CONTAINER_TOOL) push $(IMG)
333333

334334
multiarch-image: config-docker ## Generate multiarch images for operator image.
335335
@MAX_PULLING_RETRY=20 RETRY_INTERVAL=30 common/scripts/multiarch_image.sh $(DOCKER_REGISTRY) $(OPERATOR_IMAGE_NAME) $(BUILD_VERSION) $(RELEASE_VERSION)

0 commit comments

Comments
 (0)