disable cs cr status update

Signed-off-by: Allen Li <liyuchen223@gmail.com>

Author: qpdpQ

controllers/bootstrap/init.go

@@ -239,10 +239,13 @@ func (b *Bootstrap) InitResources(instance *apiv3.CommonService, forceUpdateODLM
 		if err := b.ConfigODLMOperandManagedByOperator(ctx); err != nil {
 			return err
 		}
-		// Set "Pending" condition when creating OperandRegistry and OperandConfig
-		instance.SetPendingCondition(constant.MasterCR, apiv3.ConditionTypePending, corev1.ConditionTrue, apiv3.ConditionReasonInit, apiv3.ConditionMessageInit)
-		if err := b.Client.Status().Update(ctx, instance); err != nil {
-			return err
+		// block status update
+		if os.Getenv("NO_OLM") != "true" {
+			// Set "Pending" condition when creating OperandRegistry and OperandConfig
+			instance.SetPendingCondition(constant.MasterCR, apiv3.ConditionTypePending, corev1.ConditionTrue, apiv3.ConditionReasonInit, apiv3.ConditionMessageInit)
+			if err := b.Client.Status().Update(ctx, instance); err != nil {
+				return err
+			}
 		}
 
 		klog.Info("Installing/Updating OperandRegistry")

controllers/commonservice_controller.go

@@ -125,9 +125,12 @@ func (r *CommonServiceReconciler) ReconcileMasterCR(ctx context.Context, instanc
 		} else {
 			instance.SetReadyCondition(constant.KindCR, apiv3.ConditionTypeReady, corev1.ConditionTrue)
 		}
-		if err := r.Client.Status().Update(ctx, instance); err != nil {
-			klog.Warning(err)
-			return
+		// block status update
+		if os.Getenv("NO_OLM") != "true" {
+			if err := r.Client.Status().Update(ctx, instance); err != nil {
+				klog.Warning(err)
+				return
+			}
 		}
 	}()
 
@@ -145,9 +148,11 @@ func (r *CommonServiceReconciler) ReconcileMasterCR(ctx context.Context, instanc
 	if !reflect.DeepEqual(originalInstance.Status, instance.Status) {
 		forceUpdateODLMCRs = true
 	}
-
-	if statusErr = r.Client.Status().Patch(ctx, instance, client.MergeFrom(originalInstance)); statusErr != nil {
-		return ctrl.Result{}, fmt.Errorf("error while patching CommonService.Status: %v", statusErr)
+	// block status update
+	if os.Getenv("NO_OLM") != "true" {
+		if statusErr = r.Client.Status().Patch(ctx, instance, client.MergeFrom(originalInstance)); statusErr != nil {
+			return ctrl.Result{}, fmt.Errorf("error while patching CommonService.Status: %v", statusErr)
+		}
 	}
 
 	if instance.Status.Phase == "" {
@@ -159,9 +164,12 @@ func (r *CommonServiceReconciler) ReconcileMasterCR(ctx context.Context, instanc
 			return ctrl.Result{}, statusErr
 		}
 	} else {
-		if statusErr = r.updatePhase(ctx, instance, CRUpdating); statusErr != nil {
-			klog.Errorf("Fail to reconcile %s/%s: %v", instance.Namespace, instance.Name, statusErr)
-			return ctrl.Result{}, statusErr
+		// block status update
+		if os.Getenv("NO_OLM") != "true" {
+			if statusErr = r.updatePhase(ctx, instance, CRUpdating); statusErr != nil {
+				klog.Errorf("Fail to reconcile %s/%s: %v", instance.Namespace, instance.Name, statusErr)
+				return ctrl.Result{}, statusErr
+			}
 		}
 	}
 
@@ -203,8 +211,11 @@ func (r *CommonServiceReconciler) ReconcileMasterCR(ctx context.Context, instanc
 		if err := r.Reader.Get(ctx, types.NamespacedName{Name: r.Bootstrap.CSData.ServicesNs}, ns); err != nil {
 			if errors.IsNotFound(err) {
 				klog.Errorf("Not found servicesNamespace %s specified in the common-service CR.", r.Bootstrap.CSData.ServicesNs)
-				if err := r.updatePhase(ctx, instance, CRFailed); err != nil {
-					klog.Error(err)
+				// block status update
+				if os.Getenv("NO_OLM") != "true" {
+					if err := r.updatePhase(ctx, instance, CRFailed); err != nil {
+						klog.Error(err)
+					}
 				}
 				klog.Errorf("Fail to reconcile %s/%s: %v", instance.Namespace, instance.Name, err)
 				return ctrl.Result{}, err
@@ -267,10 +278,12 @@ func (r *CommonServiceReconciler) ReconcileMasterCR(ctx context.Context, instanc
 		instance.SetErrorCondition(constant.MasterCR, apiv3.ConditionTypeError, corev1.ConditionTrue, apiv3.ConditionReasonError, statusErr.Error())
 		instance.Status.Phase = CRFailed
 	}
-
-	if statusErr = r.Client.Status().Update(ctx, instance); statusErr != nil {
-		klog.Errorf("Fail to update %s/%s: %v", instance.Namespace, instance.Name, statusErr)
-		return ctrl.Result{}, statusErr
+	// block status update
+	if os.Getenv("NO_OLM") != "true" {
+		if statusErr = r.Client.Status().Update(ctx, instance); statusErr != nil {
+			klog.Errorf("Fail to update %s/%s: %v", instance.Namespace, instance.Name, statusErr)
+			return ctrl.Result{}, statusErr
+		}
 	}
 
 	var isEqual bool

main.go

@@ -170,7 +170,8 @@ func main() {
 			go goroutines.UpdateCsCrStatus(bs)
 		} else {
 			// Update CS CR Status
-			go goroutines.UpdateNoOLMCsCrStatus(bs)
+			// block status update
+			// go goroutines.UpdateNoOLMCsCrStatus(bs)
 		}
 
 		// Create CS CR