Skip to content

Commit 3187e23

Browse files
author
Xin Li
authored
Enhance delete rbac when comfigmap does not exist (#49)
1 parent 9f48ad2 commit 3187e23

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

controllers/namespacescope_controller.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,11 @@ func (r *NamespaceScopeReconciler) DeleteRbacFromUnmanagedNamespace(instance *op
239239
cm := &corev1.ConfigMap{}
240240
cmKey := types.NamespacedName{Name: instance.Spec.ConfigmapName, Namespace: instance.Namespace}
241241
if err := r.Get(ctx, cmKey, cm); err != nil {
242-
klog.Errorf("ConfigMap %s not found", cmKey.String())
242+
if errors.IsNotFound(err) {
243+
klog.Infof("ConfigMap %s not found", cmKey.String())
244+
return nil
245+
}
246+
klog.Errorf("Failed to get ConfigMap %s: %v", cmKey.String(), err)
243247
return err
244248
}
245249

0 commit comments

Comments
 (0)