Fix delete rbac issue (#37)

Xin Li · web-flow · commit 73b0dc9ae3dc · 2020-11-10T16:37:42.000+08:00
diff --git a/controllers/namespacescope_controller.go b/controllers/namespacescope_controller.go
@@ -305,7 +305,13 @@ func (r *NamespaceScopeReconciler) DeleteAllRbac(instance *operatorv1.NamespaceS
 		return err
 	}
 
-	for _, toNs := range instance.Spec.NamespaceMembers {
+	usingMembers, err := r.getNamespaceList(instance)
+	if err != nil {
+		return err
+	}
+	deletedMembers := util.GetListDifference(instance.Spec.NamespaceMembers, usingMembers)
+
+	for _, toNs := range deletedMembers {
 		if toNs == operatorNs {
 			continue
 		}

Original file line number	Diff line number	Diff line change
`@@ -305,7 +305,13 @@ func (r NamespaceScopeReconciler) DeleteAllRbac(instance operatorv1.NamespaceS`
`305`	`305`	`return err`
`306`	`306`	`}`
`307`	`307`
`308`		`- for _, toNs := range instance.Spec.NamespaceMembers {`
	`308`	`+ usingMembers, err := r.getNamespaceList(instance)`
	`309`	`+ if err != nil {`
	`310`	`+ return err`
	`311`	`+ }`
	`312`	`+ deletedMembers := util.GetListDifference(instance.Spec.NamespaceMembers, usingMembers)`
	`313`	`+`
	`314`	`+ for _, toNs := range deletedMembers {`
`309`	`315`	`if toNs == operatorNs {`
`310`	`316`	`continue`
`311`	`317`	`}`