Skip to content

Commit 3ded044

Browse files
committed
add labels
Signed-off-by: Ashima-Ashima1 <[email protected]>
1 parent e9703ca commit 3ded044

File tree

2 files changed

+42
-7
lines changed

2 files changed

+42
-7
lines changed

controllers/internal/crutils/ibmobjectcsi.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,8 @@ func (c *IBMObjectCSI) GetLabels() labels.Set {
3434
"app.kubernetes.io/name": config.ProductName,
3535
"app.kubernetes.io/instance": c.Name,
3636
"app.kubernetes.io/version": csiversion.Version,
37-
"app.kubernetes.io/managed-by": config.Name,
37+
"app.kubernetes.io/part-of": config.Name,
38+
"app.kubernetes.io/managed-by": "addon",
3839
"product": config.ProductName,
3940
"release": fmt.Sprintf("v%s", csiversion.Version),
4041
}
@@ -107,12 +108,10 @@ func (c *IBMObjectCSI) GetCSIControllerImage() string {
107108

108109
// GetCSIControllerResourceRequests ...
109110
func (c *IBMObjectCSI) GetCSIControllerResourceRequests() *objectdriverv1alpha1.ResourcesSpec {
110-
resources := c.Spec.Controller.Resources
111-
return &resources
111+
return &c.Spec.Controller.Resources
112112
}
113113

114114
// GetCSINodeResourceRequests ...
115115
func (c *IBMObjectCSI) GetCSINodeResourceRequests() *objectdriverv1alpha1.ResourcesSpec {
116-
resources := c.Spec.Node.Resources
117-
return &resources
116+
return &c.Spec.Node.Resources
118117
}

controllers/internal/crutils/static_resource_generator.go

Lines changed: 38 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,12 @@ func (c *IBMObjectCSI) GenerateCSIDriver() *storagev1.CSIDriver {
1515
defaultFSGroupPolicy := storagev1.FileFSGroupPolicy
1616
return &storagev1.CSIDriver{
1717
ObjectMeta: metav1.ObjectMeta{
18-
Name: config.DriverName,
19-
Labels: map[string]string{"app.kubernetes.io/name": "ibm-object-csi"},
18+
Name: config.DriverName,
19+
Labels: map[string]string{
20+
"app.kubernetes.io/name": "ibm-object-csi",
21+
"app.kubernetes.io/part-of": config.Name,
22+
"app.kubernetes.io/managed-by": "addon",
23+
},
2024
},
2125
Spec: storagev1.CSIDriverSpec{
2226
AttachRequired: boolptr.False(),
@@ -53,6 +57,10 @@ func (c *IBMObjectCSI) GenerateExternalProvisionerClusterRole() *rbacv1.ClusterR
5357
return &rbacv1.ClusterRole{
5458
ObjectMeta: metav1.ObjectMeta{
5559
Name: config.GetNameForResource(config.ExternalProvisionerClusterRole, c.Name),
60+
Labels: map[string]string{
61+
"app.kubernetes.io/part-of": config.Name,
62+
"app.kubernetes.io/managed-by": "addon",
63+
},
5664
},
5765
Rules: []rbacv1.PolicyRule{
5866
{
@@ -99,6 +107,10 @@ func (c *IBMObjectCSI) GenerateExternalProvisionerClusterRoleBinding() *rbacv1.C
99107
return &rbacv1.ClusterRoleBinding{
100108
ObjectMeta: metav1.ObjectMeta{
101109
Name: config.GetNameForResource(config.ExternalProvisionerClusterRoleBinding, c.Name),
110+
Labels: map[string]string{
111+
"app.kubernetes.io/part-of": config.Name,
112+
"app.kubernetes.io/managed-by": "addon",
113+
},
102114
},
103115
Subjects: []rbacv1.Subject{
104116
{
@@ -120,6 +132,10 @@ func (c *IBMObjectCSI) GenerateSCCForControllerClusterRole() *rbacv1.ClusterRole
120132
return &rbacv1.ClusterRole{
121133
ObjectMeta: metav1.ObjectMeta{
122134
Name: config.GetNameForResource(config.CSIControllerSCCClusterRole, c.Name),
135+
Labels: map[string]string{
136+
"app.kubernetes.io/part-of": config.Name,
137+
"app.kubernetes.io/managed-by": "addon",
138+
},
123139
},
124140
Rules: []rbacv1.PolicyRule{
125141
{
@@ -137,6 +153,10 @@ func (c *IBMObjectCSI) GenerateSCCForControllerClusterRoleBinding() *rbacv1.Clus
137153
return &rbacv1.ClusterRoleBinding{
138154
ObjectMeta: metav1.ObjectMeta{
139155
Name: config.GetNameForResource(config.CSIControllerSCCClusterRoleBinding, c.Name),
156+
Labels: map[string]string{
157+
"app.kubernetes.io/part-of": config.Name,
158+
"app.kubernetes.io/managed-by": "addon",
159+
},
140160
},
141161
Subjects: []rbacv1.Subject{
142162
{
@@ -158,6 +178,10 @@ func (c *IBMObjectCSI) GenerateSCCForNodeClusterRole() *rbacv1.ClusterRole {
158178
return &rbacv1.ClusterRole{
159179
ObjectMeta: metav1.ObjectMeta{
160180
Name: config.GetNameForResource(config.CSINodeSCCClusterRole, c.Name),
181+
Labels: map[string]string{
182+
"app.kubernetes.io/part-of": config.Name,
183+
"app.kubernetes.io/managed-by": "addon",
184+
},
161185
},
162186
Rules: []rbacv1.PolicyRule{
163187
{
@@ -187,6 +211,10 @@ func (c *IBMObjectCSI) GenerateSCCForNodeClusterRoleBinding() *rbacv1.ClusterRol
187211
return &rbacv1.ClusterRoleBinding{
188212
ObjectMeta: metav1.ObjectMeta{
189213
Name: config.GetNameForResource(config.CSINodeSCCClusterRoleBinding, c.Name),
214+
Labels: map[string]string{
215+
"app.kubernetes.io/part-of": config.Name,
216+
"app.kubernetes.io/managed-by": "addon",
217+
},
190218
},
191219
Subjects: []rbacv1.Subject{
192220
{
@@ -209,6 +237,10 @@ func (c *IBMObjectCSI) Generates3fsSC() *storagev1.StorageClass {
209237
return &storagev1.StorageClass{
210238
ObjectMeta: metav1.ObjectMeta{
211239
Name: config.GetNameForResource(config.S3fsStorageClass, c.Name),
240+
Labels: map[string]string{
241+
"app.kubernetes.io/part-of": config.Name,
242+
"app.kubernetes.io/managed-by": "addon",
243+
},
212244
},
213245
Provisioner: config.DriverName,
214246
ReclaimPolicy: &reclaimPolicy,
@@ -237,6 +269,10 @@ func (c *IBMObjectCSI) GenerateRcloneSC() *storagev1.StorageClass {
237269
return &storagev1.StorageClass{
238270
ObjectMeta: metav1.ObjectMeta{
239271
Name: config.GetNameForResource(config.RcloneStorageClass, c.Name),
272+
Labels: map[string]string{
273+
"app.kubernetes.io/part-of": config.Name,
274+
"app.kubernetes.io/managed-by": "addon",
275+
},
240276
},
241277
Provisioner: config.DriverName,
242278
ReclaimPolicy: &reclaimPolicy,

0 commit comments

Comments
 (0)