address review comments

Signed-off-by: Ashima-Ashima1 <[email protected]>

Author: ashimagarg27

api/v1alpha1/recoverstalevolume_types.go

@@ -26,14 +26,14 @@ import (
 
 // RecoverStaleVolumeSpec defines the desired state of RecoverStaleVolume
 type RecoverStaleVolumeSpec struct {
-	NoOfLogLines int64                      `json:"noOfLogLines,omitempty"`
-	Data         []NamespacedDeploymentData `json:"data,omitempty"`
+	LogHistory int64                      `json:"logHistory,omitempty"`
+	Data       []NamespacedDeploymentData `json:"data"`
 }
 
 // NamespacedDeploymentData ...
 type NamespacedDeploymentData struct {
-	Namespace   string   `json:"namespace,omitempty"`
-	Deployments []string `json:"applications,omitempty"`
+	Namespace   string   `json:"namespace"`
+	Deployments []string `json:"deployments,omitempty"`
 }
 
 // RecoverStaleVolumeStatus defines the observed state of RecoverStaleVolume

config/crd/bases/objectdriver.csi.ibm.com_recoverstalevolumes.yaml

@@ -44,17 +44,21 @@ spec:
                 items:
                   description: NamespacedDeploymentData ...
                   properties:
-                    applications:
+                    deployments:
                       items:
                         type: string
                       type: array
                     namespace:
                       type: string
+                  required:
+                  - namespace
                   type: object
                 type: array
-              noOfLogLines:
+              logHistory:
                 format: int64
                 type: integer
+            required:
+            - data
             type: object
           status:
             description: RecoverStaleVolumeStatus defines the observed state of RecoverStaleVolume

controllers/recoverstalevolume_controller.go

@@ -85,7 +85,7 @@ func (r *RecoverStaleVolumeReconciler) Reconcile(ctx context.Context, req ctrl.R
 		return ctrl.Result{}, err
 	}
 
-	var logTailLines = instance.Spec.NoOfLogLines
+	var logTailLines = instance.Spec.LogHistory
 	if logTailLines == 0 {
 		logTailLines = int64(constants.DefaultLogTailLines)
 	}