Merge pull request #37 from IBM/lintfix

Fix linter issues

Author: ambiknai

controllers/ibmobjectcsi_controller.go

@@ -545,7 +545,6 @@ func (r *IBMObjectCSIReconciler) getClusterRoleBindings(instance *crutils.IBMObj
 }
 
 func (r *IBMObjectCSIReconciler) getStorageClasses(instance *crutils.IBMObjectCSI) []*storagev1.StorageClass {
-
 	cosRegion := r.ControllerHelper.GetRegion()
 	cosEP := r.ControllerHelper.GetCosEP()
 	s3Provider := r.ControllerHelper.GetS3Provider()
@@ -566,7 +565,6 @@ func (r *IBMObjectCSIReconciler) getStorageClasses(instance *crutils.IBMObjectCS
 		// 	ibmCosSC := fmt.Sprintf("%s-%s", cosRegion, sc)
 		// 	cosSCs = append(cosSCs, ibmCosSC)
 		// }
-
 	} else {
 		cosSCs = append(cosSCs, "standard")
 	}

controllers/internal/crutils/static_resource_generator.go

@@ -222,8 +222,8 @@ func (c *IBMObjectCSI) GenerateS3fsSC(storageClassNamePrefix string,
 	region string, cosEndpoint string, cosStorageClass string) *storagev1.StorageClass {
 	// TODO: TIER Based SC
 	var storageClassName string
-	var cosEP string = ""
-	var cosSC string = "standard"
+	var cosEP string
+	var cosSC = "standard"
 
 	if len(cosEndpoint) > 0 {
 		cosEP = cosEndpoint
@@ -240,7 +240,7 @@ func (c *IBMObjectCSI) GenerateS3fsSC(storageClassNamePrefix string,
 		storageClassName = fmt.Sprintf("%s-%s-s3fs", storageClassNamePrefix, cosSC)
 	}
 
-	if isIBMColud == true {
+	if isIBMColud {
 		ibmCosSC := fmt.Sprintf("%s-%s", region, cosSC)
 		cosSC = ibmCosSC
 	}
@@ -277,10 +277,9 @@ func (c *IBMObjectCSI) GenerateS3fsSC(storageClassNamePrefix string,
 func (c *IBMObjectCSI) GenerateRcloneSC(storageClassNamePrefix string,
 	reclaimPolicy corev1.PersistentVolumeReclaimPolicy, isIBMColud bool,
 	region string, cosEndpoint string, cosStorageClass string) *storagev1.StorageClass {
-
 	var storageClassName string
-	var cosEP string = ""
-	var cosSC string = "standard"
+	var cosEP string
+	var cosSC = "standard"
 
 	if len(cosEndpoint) > 0 {
 		cosEP = cosEndpoint
@@ -297,7 +296,7 @@ func (c *IBMObjectCSI) GenerateRcloneSC(storageClassNamePrefix string,
 		storageClassName = fmt.Sprintf("%s-%s-rclone", storageClassNamePrefix, cosSC)
 	}
 
-	if isIBMColud == true {
+	if isIBMColud {
 		ibmCosSC := fmt.Sprintf("%s-%s", region, cosSC)
 		cosSC = ibmCosSC
 	}

controllers/util/common/common.go

@@ -24,7 +24,6 @@ import (
 
 var iaasIBMVPC = "ibm-vpc"
 var iaasIBMClassic = "ibm-classic"
-var cosIBMProvider = "ibm-cos"
 
 // ControllerHelper ...
 type ControllerHelper struct {