Skip to content

Commit 16f35c4

Browse files
committed
extend argparser with tlskeyfile and tlscertfile
-update Dockerfile -update bridge deployment script
1 parent 558bd3e commit 16f35c4

File tree

3 files changed

+23
-11
lines changed

3 files changed

+23
-11
lines changed

example_deployment_scripts/bridge_deployment/bridge-deployment.yaml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,11 @@ spec:
5656
- name: SERVER
5757
value: $(IBM_SPECTRUM_SCALE_PERF_QUERY_SERVICE_HOST)
5858
- name: TLSKEYPATH
59-
value: /opt/registry/certs
59+
value: /etc/bridge_ssl/certs
60+
- name: TLSKEYFILE
61+
value: "tls.key"
62+
- name: TLSCERTFILE
63+
value: "tls.crt"
6064
- name: PORT
6165
value: "8443"
6266
imagePullPolicy: Always
@@ -67,16 +71,17 @@ spec:
6771
containerPort: 8443
6872
volumeMounts:
6973
- name: logfiles
70-
mountPath: /opt/IBM/bridge/logs
74+
mountPath: /var/log/ibm_bridge_for_grafana/
7175
- name: config
7276
mountPath: /opt/IBM/zimon/
7377
readOnly: true
7478
optional: true
7579
- name: secret-volume
76-
mountPath: /opt/registry/certs
80+
mountPath: /etc/bridge_ssl/certs
81+
type: DirectoryOrCreate
7782
initContainers:
7883
- name: init-scale-perf-query-service
79-
image: busybox:1.28
84+
image: busybox:latest
8085
command: ['sh', '-c', "until nslookup ibm-spectrum-scale-perf-query.$(cat /var/run/secrets/kubernetes.io/serviceaccount/namespace).svc.cluster.local; do echo waiting for ibm-spectrum-scale-perf-query service; sleep 2; done"]
8186
#######################################################################################################################
8287
#

source/Dockerfile

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,16 @@ ARG HTTPPORT=4242
2323
ENV PORT=$HTTPPORT
2424
RUN echo "the HTTP/S port is set to $PORT"
2525

26-
ARG CERTPATH
26+
ARG CERTPATH=None
2727
ENV TLSKEYPATH=$CERTPATH
28-
RUN if [ -z "$TLSKEYPATH" ] && [ "$PORT" -eq 8443 ]; then echo "TLSKEYPATH FOR SSL CONNECTION NOT SET - ERROR"; exit 1; else echo "PASS"; fi
28+
29+
ARG KEYFILE=None
30+
ENV TLSKEYFILE=$KEYFILE
31+
32+
ARG CERTFILE=None
33+
ENV TLSCERTFILE=$CERTFILE
34+
35+
RUN if [ -z "$TLSKEYPATH" ] || [ -z "$TLSCERTFILE" ] || [ -z "$TLSKEYFILE" ] && [ "$PORT" -eq 8443 ]; then echo "TLSKEYPATH FOR SSL CONNECTION NOT SET - ERROR"; exit 1; else echo "PASS"; fi
2936
RUN echo "the ssl certificates path is set to $TLSKEYPATH"
3037

3138
ARG PMCOLLECTORIP=0.0.0.0
@@ -35,7 +42,7 @@ RUN echo "the pmcollector server ip is set to $SERVER"
3542

3643
WORKDIR /opt/IBM/bridge
3744

38-
ARG DEFAULTLOGPATH='./logs/zserver.log'
45+
ARG DEFAULTLOGPATH='/var/log/ibm_bridge_for_grafanalogs/install.log'
3946
ENV LOGPATH=$DEFAULTLOGPATH
4047
RUN mkdir -p $(dirname $LOGPATH)
4148
RUN echo "the log will use $(dirname $LOGPATH)"
@@ -47,7 +54,7 @@ RUN echo "pmcollector_server: $SERVER" >> $LOGPATH
4754
RUN echo "ssl certificates location: $TLSKEYPATH" >> $LOGPATH
4855
RUN echo "HTTP/S port: $PORT" >> $LOGPATH
4956

50-
CMD ["sh", "-c", "python3 zimonGrafanaIntf.py -c 10 -s $SERVER -p $PORT -t $TLSKEYPATH"]
57+
CMD ["sh", "-c", "python3 zimonGrafanaIntf.py -c 10 -s $SERVER -p $PORT -t $TLSKEYPATH --tlsKeyFile $TLSKEYFILE --tlsCertFile $TLSCERTFILE"]
5158

5259
EXPOSE 4242 8443
5360

source/confParser.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,9 @@ def parse_cmd_args(argv):
100100
parser.add_argument('-f', '--logFile', action="store", default="zserver.log", help='Name of the log file (Default: zserver.log')
101101
parser.add_argument('-c', '--logLevel', action="store", type=int, default=logging.INFO, help='log level 10 (DEBUG), 20 (INFO), 30 (WARN), 40 (ERROR) (Default: 20)')
102102
parser.add_argument('-p', '--port', action="store", type=int, choices=[4242, 8443], default=4242, help='port number listening on for HTTP(S) connections (Default: 4242)')
103-
parser.add_argument('-t', '--tlsKeyPath', action="store", help='Directory path of tls privkey.pem and cert.pem file location (Required only for HTTPS port 8443)')
104-
parser.add_argument('-k', '--tlsKeyFile', action="store", help='Name of TLS key file, f.e.: privkey.pem (Required only for HTTPS port 8443)')
105-
parser.add_argument('-m', '--tlsCertFile', action="store", help='Name of TLS certificate file, f.e.: cert.pem (Required only for HTTPS port 8443)')
103+
parser.add_argument('-t', '--tlsKeyPath', action="store", default=None, help='Directory path of tls privkey.pem and cert.pem file location (Required only for HTTPS port 8443)')
104+
parser.add_argument('-k', '--tlsKeyFile', action="store", default=None, help='Name of TLS key file, f.e.: privkey.pem (Required only for HTTPS port 8443)')
105+
parser.add_argument('-m', '--tlsCertFile', action="store", default=None, help='Name of TLS certificate file, f.e.: cert.pem (Required only for HTTPS port 8443)')
106106

107107
args = parser.parse_args(argv)
108108
return args, ''

0 commit comments

Comments
 (0)