Skip to content

Commit 30fe5be

Browse files
committed
make call_func_on_change optional in refresher
1 parent e7803b6 commit 30fe5be

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

source/messages.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
'MetaError': 'Metadata could not be retrieved. Check log file for more details, quitting',
3737
'MetaSuccess': 'Successfully retrieved MetaData',
3838
'RequestMetaUpdate': 'MetaData update requested',
39+
'ElapsedTimeSinceLastUpdate': 'Elapsed time:{} since last MetaData update',
3940
'QueryError': 'Query request could not be proceed. Reason: {}',
4041
'SearchErr': 'Search for {} did cause exception: {}',
4142
'LookupErr': 'Lookup for metric {} did not return any results',

source/refresher.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ class TopoRefreshManager(object, metaclass=Singleton):
3737
thread = None
3838
refresh_delay_secs = 30
3939

40-
def __init__(self, call_func_on_change, *args, **kwargs):
40+
def __init__(self, call_func_on_change=None, *args, **kwargs):
4141
self._cached_stamp = {}
4242
self.logger = getBridgeLogger()
4343
self.update_required = False
@@ -81,11 +81,12 @@ def monitor(self):
8181
if self.update_required:
8282
md = MetadataHandler()
8383
elapsed_time = time.time() - md.getUpdateTime
84-
# self.logger.trace(f"Elapsed time{elapsed_time}")
84+
self.logger.trace(MSG['ElapsedTimeSinceLastUpdate'].format(elapsed_time))
8585
if elapsed_time > 300 or self.new_keys > 100:
8686
self.logger.info(MSG['RequestMetaUpdate'])
87-
self.call_func_on_change(*self.args, **self.kwargs)
88-
self.clear_local_cache()
87+
if self.call_func_on_change is not None:
88+
self.call_func_on_change(*self.args, **self.kwargs)
89+
self.clear_local_cache()
8990
except KeyboardInterrupt:
9091
self.logger.details(MSG['StopMonitoringTopoChanges'])
9192
break

0 commit comments

Comments
 (0)