Skip to content

Commit 5c85c85

Browse files
authored
Merge pull request #32 from Helene/7.0.1a
fix version string comparison
2 parents eb4a047 + 7c3a557 commit 5c85c85

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

tests/test_cli_parser.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ def test_case03():
4040

4141
@with_setup(my_setup)
4242
def test_case04():
43-
if float(version) < 7.0:
43+
if version < "7.0":
4444
args, msg = parse_cmd_args(g)
4545
result = vars(args)
4646
assert isinstance(result['port'], int)
@@ -52,7 +52,7 @@ def test_case04():
5252

5353
@with_setup(my_setup)
5454
def test_case05():
55-
if float(version) < 7.0:
55+
if version < "7.0":
5656
args, msg = parse_cmd_args(g)
5757
result = vars(args)
5858
assert result['port'] == 4242 and result['serverPort'] == 9084

tests/test_configManager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ def test_case09():
6767
def test_case10():
6868
cm = ConfigManager()
6969
result = cm.defaults
70-
if float(version) < 7.0:
70+
if version < "7.0":
7171
assert int(result['port']) == 4242 and int(result['serverPort']) == 9084
7272
else:
7373
assert int(result['port']) == 4242 and int(result['serverPort']) == 9980

tests/test_parser.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,5 +19,5 @@ def test_case03():
1919

2020
def test_case04():
2121
result = os.system('python ./source/zimonGrafanaIntf.py -P 9084')
22-
if float(version) >= 7.0:
22+
if version >= "7.0":
2323
assert result > 0

0 commit comments

Comments
 (0)