Skip to content

Commit 85841e0

Browse files
committed
fix metric type in desc header
Signed-off-by: hwassman <[email protected]>
1 parent 5a833c9 commit 85841e0

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

source/collector.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,12 +109,15 @@ def __init__(self, name: str, desc: str, type: Optional[str] = None):
109109
self.desc = desc
110110
self.timeseries: list[TimeSeries] = []
111111

112-
def str_descfmt(self) -> [str]:
112+
def str_descfmt(self, original_counters=False) -> [str]:
113113
"""Format MetricTimeSeries description rows
114114
Output format:
115115
'''# HELP {name} {desc}'''
116116
'''# TYPE {name} {mtype}'''
117117
"""
118+
metric_type = self.mtype
119+
if not original_counters and metric_type == 'counter':
120+
metric_type = 'gauge'
118121

119122
myset = []
120123

@@ -125,7 +128,7 @@ def str_descfmt(self) -> [str]:
125128
myset.append(expfmt)
126129
expfmt1 = '''# TYPE {name} {mtype}'''.format(
127130
name=self.mname,
128-
mtype=self.mtype,
131+
mtype=metric_type,
129132
)
130133
myset.append(expfmt1)
131134

source/prometheus.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,15 @@ def TOPO(self):
5959
def format_response(self, data) -> [str]:
6060
resp = []
6161
for name, metric in data.items():
62-
header = metric.str_descfmt()
62+
header = metric.str_descfmt(original_counters=self.raw_data)
6363
resp.extend(header)
6464
for sts in metric.timeseries:
6565
if self.raw_data:
6666
sts.reduce_dps_to_first_not_none(reverse_order=True)
6767
for _key, _value in sts.dps.items():
68-
sts_resp = SingleTimeSeriesResponse(name, _key, _value, sts.tags, metric.mtype)
68+
sts_resp = SingleTimeSeriesResponse(name, _key,
69+
_value, sts.tags,
70+
metric.mtype)
6971
self.logger.trace(f'sts_resp.str_expfmt output: {sts_resp.str_expfmt()}')
7072
resp.extend(sts_resp.str_expfmt())
7173
return resp

0 commit comments

Comments
 (0)