Skip to content

Commit bc363fe

Browse files
committed
refine unit_tests
Signed-off-by: hwassman <[email protected]>
1 parent 87e414a commit bc363fe

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

source/queryHandler/SensorConfig.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,7 @@ def parseSensorsConfig(sensorsConfig, logger):
106106
if sensorsConfig.find("smbstat") != -1:
107107
sensorsStr = sensorsConfig[sensorsConfig.find("sensors"):sensorsConfig.find("smbstat")]
108108
else:
109-
end = None
110-
sensorsStr = sensorsConfig[sensorsConfig.find("sensors"):end]
109+
sensorsStr = sensorsConfig[sensorsConfig.find("sensors"):]
111110
sensorsList = re.findall('(?P<sensor>{.*?})(?:,|$)', sensorsStr)
112111
for sensorString in sensorsList:
113112
sensorAttr = re.findall(r'(?P<name>\w+) = (?P<value>\"\S*\"|\d+)', sensorString)

tests/test_zimon_config_parser.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,19 @@ def test_case02():
2626
sensorsList = readSensorsConfig(logger, zimonFile)
2727
assert isinstance(sensorsList, list)
2828
assert len(sensorsList) > 0
29+
assert len(sensorsList) == 32
2930

3031

3132
@with_setup(my_setup)
3233
def test_case03():
3334
zimonFile = os.path.join(path, "tests", "test_data", wrongSensorsConfig)
3435
sensorsList = readSensorsConfig(logger, zimonFile)
36+
nfsioConf = sensorsList[0]
3537
assert isinstance(sensorsList, list)
38+
assert isinstance(nfsioConf, dict)
3639
assert len(sensorsList) > 0
40+
assert len(sensorsList) == 1
41+
assert nfsioConf.get('name') == '"NFSIO"'
3742

3843

3944
@with_setup(my_setup)

0 commit comments

Comments
 (0)