fix flake8 findings

Author: Helene

source/bridgeLogger.py

@@ -20,27 +20,27 @@
 @author: HWASSMAN
 '''
 
-import json
-import re
 import logging
-import sys
 import os
 
 logging.TRACE = 5
 logging.addLevelName(logging.TRACE, 'TRACE')
 
 logging.MOREINFO = 15
-logging.addLevelName(logging.MOREINFO,"MOREINFO")
+logging.addLevelName(logging.MOREINFO, 'MOREINFO')
+
 
 class MyLogger(logging.getLoggerClass()):
 
     def __init__(self, name, level=logging.NOTSET):
         super().__init__(name, level)
 
+
     def trace(self, msg, *args, **kwargs):
         if self.isEnabledFor(logging.TRACE):
             self._log(logging.TRACE, msg, args, **kwargs)
 
+
     def details(self, msg, *args, **kwargs):
         if self.isEnabledFor(logging.MOREINFO):
             self._log(logging.MOREINFO, msg, args, **kwargs)
@@ -50,7 +50,7 @@ def configureLogging(logPath, logfile, loglevel=logging.INFO):
 
     try:
         loglevel = logging._checkLevel(loglevel)
-    except (ValueError, TypeError) as e:
+    except (ValueError, TypeError):
         loglevel = logging.INFO
 
     # create the logfile path if needed
@@ -79,4 +79,3 @@ def configureLogging(logPath, logfile, loglevel=logging.INFO):
 
     logger.propagate = False  # prevent propagation to default (console) logger
     return logger
-

source/confParser.py

@@ -22,7 +22,6 @@
 
 import argparse
 import os
-import logging.handlers
 from messages import MSG
 import configparser
 
@@ -101,7 +100,7 @@ def parse_cmd_args(argv):
                         In this case make sure the \'query2port = \"9094\"\' is enabled in the ZIMon queryinterface settings (\'ZIMonCollector.cfg\')')
     parser.add_argument('-l', '--logPath', action="store", default="/var/log/ibm_bridge_for_grafana", help='location path of the log file (Default: /var/log/ibm_bridge_for_grafana')
     parser.add_argument('-f', '--logFile', action="store", default="zserver.log", help='Name of the log file (Default: zserver.log')
-    parser.add_argument('-c', '--logLevel', action="store", type=int, default=15, 
+    parser.add_argument('-c', '--logLevel', action="store", type=int, default=15,
                         help='log level. Available levels: 10 (DEBUG), 15 (MOREINFO), 20 (INFO), 30 (WARN), 40 (ERROR) (Default: 15)')
     parser.add_argument('-p', '--port', action="store", type=int, choices=[4242, 8443], default=4242, help='port number listening on for HTTP(S) connections (Default: 4242)')
     parser.add_argument('-t', '--tlsKeyPath', action="store", default=None, help='Directory path of tls privkey.pem and cert.pem file location (Required only for HTTPS port 8443)')

tests/test_logger.py

@@ -1,6 +1,6 @@
 import logging
 from source.bridgeLogger import configureLogging
-from nose.tools import assert_raises_regexp, assert_raises
+from nose.tools import assert_raises
 
 
 def test_case01():
@@ -14,5 +14,5 @@ def test_case02():
 
 
 def test_case03():
-    result = configureLogging('/tmp','mylog', 'abc')
+    result = configureLogging('/tmp', 'mylog', 'abc')
     assert isinstance(result, logging.Logger)