Skip to content

Commit 142e30b

Browse files
starpitaavarghese
authored andcommitted
feat: version command should show both app version and lunchpail version
Signed-off-by: Nick Mitchell <[email protected]>
1 parent f8273b3 commit 142e30b

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

cmd/subcommands/version.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@ var versionCmd = &cobra.Command{
1212
Short: "version",
1313
Long: "version",
1414
RunE: func(cmd *cobra.Command, args []string) error {
15-
version := lunchpail.Version()
16-
if assembly.IsAssembled() {
17-
version = assembly.AppVersion()
15+
if assembly.IsAssembled() && assembly.AppVersion() != "" {
16+
fmt.Printf("Application Version: %s\n", assembly.AppVersion())
1817
}
1918

20-
fmt.Printf("%s\n", version)
19+
fmt.Printf(" Lunchpail Version: %s\n", lunchpail.Version())
20+
2121
return nil
2222
},
2323
}

tests/bin/deploy-tests.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ if [[ -d "$2" ]] && [[ -f "$2"/version ]]
7777
then
7878
# Check that app version passes through
7979
expectedAppVersion=$(cat "$2"/version)
80-
actualAppVersion=$($testapp version)
80+
actualAppVersion=$($testapp version | grep 'Application Version' | awk '{print $NF}')
8181
if [[ "$expectedAppVersion" = "$actualAppVersion" ]]
8282
then echo "✅ PASS App Version passthrough $expectedAppVersion"
8383
else echo "❌ FAIL App Version passthrough expected!=actual '$expectedAppVersion'!='$actualAppVersion'" && exit 1

0 commit comments

Comments
 (0)