Improve test coverage in test_tool_service (#241)

* Full coverage for test_verify_credentials
Signed-off-by: Madhav Kandukuri <[email protected]>

* Additional test_tool_service tests
Signed-off-by: Madhav Kandukuri <[email protected]>

* Add MCP tool call test
Signed-off-by: Madhav Kandukuri <[email protected]>

* More test_tool_service tests
Signed-off-by: Madhav Kandukuri <[email protected]>

* Some more tests
Signed-off-by: Madhav Kandukuri <[email protected]>

* More test cases
Signed-off-by: Madhav Kandukuri <[email protected]>

* test_tool_service at 90% coverage
Signed-off-by: Madhav Kandukuri <[email protected]>

* More tests
Signed-off-by: Madhav Kandukuri <[email protected]>

* Fix some test cases
Signed-off-by: Madhav Kandukuri <[email protected]>

* Linting and test cases
Signed-off-by: Madhav Kandukuri <[email protected]>

Author: madhav165

mcpgateway/services/tool_service.py

@@ -413,7 +413,8 @@ async def invoke_tool(self, db: Session, name: str, arguments: Dict[str, Any]) -
                 raise ToolNotFoundError(f"Tool '{name}' exists but is inactive")
             raise ToolNotFoundError(f"Tool not found: {name}")
 
-        is_reachable = db.execute(select(DbTool.reachable).where(slug_expr == name)).scalar_one_or_none()
+        # is_reachable = db.execute(select(DbTool.reachable).where(slug_expr == name)).scalar_one_or_none()
+        is_reachable = tool.reachable
 
         if not is_reachable:
             raise ToolNotFoundError(f"Tool '{name}' exists but is currently offline. Please verify if it is running.")
@@ -472,10 +473,7 @@ async def invoke_tool(self, db: Session, name: str, arguments: Dict[str, Any]) -
             elif tool.integration_type == "MCP":
                 transport = tool.request_type.lower()
                 gateway = db.execute(select(DbGateway).where(DbGateway.id == tool.gateway_id).where(DbGateway.enabled)).scalar_one_or_none()
-                if gateway.auth_type == "bearer":
-                    headers = decode_auth(gateway.auth_value)
-                else:
-                    headers = {}
+                headers = decode_auth(gateway.auth_value)
 
                 async def connect_to_sse_server(server_url: str) -> str:
                     """
@@ -527,7 +525,7 @@ async def connect_to_streamablehttp_server(server_url: str) -> str:
                 filtered_response = extract_using_jq(content, tool.jsonpath_filter)
                 tool_result = ToolResult(content=filtered_response)
             else:
-                return ToolResult(content="Invalid tool type")
+                return ToolResult(content=[TextContent(type="text", text="Invalid tool type")])
 
             return tool_result
         except Exception as e: