Skip to content

Commit 35707d3

Browse files
committed
lint
Signed-off-by: Mihai Criveti <[email protected]>
1 parent d2fcbb7 commit 35707d3

File tree

4 files changed

+17
-13
lines changed

4 files changed

+17
-13
lines changed

mcp-servers/python/mcp_eval_server/Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ help: ## Show this help message
1616
@echo "🚀 Quick Start:"
1717
@echo " make dev Start MCP server (stdio) with connection info"
1818
@echo " make serve-http Start HTTP server (JSON-RPC over HTTP)"
19-
@echo " make example Run evaluation example"
19+
@echo " make example Run evaluation example"
2020
@echo " make mcp-info Show MCP connection guide"
2121
@echo " make http-info Show HTTP server connection guide"
2222
@echo ""
@@ -164,7 +164,7 @@ check-env: ## Check required environment variables
164164
@echo ""
165165
@echo "📊 Available evaluation capabilities:"
166166
@echo " • 4 Judge tools (evaluate, compare, rank, reference)"
167-
@echo " • 4 Prompt tools (clarity, consistency, completeness, relevance)"
167+
@echo " • 4 Prompt tools (clarity, consistency, completeness, relevance)"
168168
@echo " • 4 Agent tools (tool usage, task completion, reasoning, benchmarks)"
169169
@echo " • 3 Quality tools (factuality, coherence, toxicity)"
170170
@echo " • 3 Workflow tools (suites, execution, comparison)"
@@ -195,7 +195,7 @@ mcp-info: ## Show MCP connection information
195195
@echo ""
196196
@echo "🛠️ Available Tools: 29 evaluation tools"
197197
@echo " • judge.evaluate_response"
198-
@echo " • judge.pairwise_comparison"
198+
@echo " • judge.pairwise_comparison"
199199
@echo " • prompt.evaluate_clarity"
200200
@echo " • agent.evaluate_tool_use"
201201
@echo " • quality.assess_toxicity"

mcp-servers/python/mcp_eval_server/README.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,8 @@ export AZURE_OPENAI_KEY="your-azure-key"
118118
}
119119
```
120120

121-
**Protocol**: stdio (Model Context Protocol)
122-
**Transport**: Standard input/output (no HTTP port needed)
121+
**Protocol**: stdio (Model Context Protocol)
122+
**Transport**: Standard input/output (no HTTP port needed)
123123
**Tools Available**: 29 specialized evaluation tools
124124

125125
### **Docker Deployment**
@@ -491,7 +491,7 @@ benchmarks:
491491
# 1. Run MCP server (for Claude Desktop, etc.)
492492
make dev # Shows connection info + starts server
493493
494-
# 2. Test basic functionality
494+
# 2. Test basic functionality
495495
make example # Run evaluation example
496496
make test-mcp # Test MCP protocol
497497
```
@@ -546,7 +546,7 @@ curl -X POST \
546546
-H "Content-Type: application/json" \
547547
-d '{
548548
"jsonrpc": "2.0",
549-
"id": 2,
549+
"id": 2,
550550
"method": "tools/call",
551551
"params": {
552552
"name": "judge.evaluate_response",
@@ -569,20 +569,20 @@ import asyncio
569569
async def evaluate_via_http():
570570
async with httpx.AsyncClient() as client:
571571
base_url = "http://localhost:9000"
572-
572+
573573
# List tools via JSON-RPC
574574
tools_request = {
575575
"jsonrpc": "2.0",
576576
"id": 1,
577577
"method": "tools/list",
578578
"params": {}
579579
}
580-
580+
581581
response = await client.post(base_url, json=tools_request)
582582
result = response.json()
583583
tools = result.get("result", [])
584584
print(f"Available tools: {len(tools)}")
585-
585+
586586
# Evaluate response via JSON-RPC
587587
eval_request = {
588588
"jsonrpc": "2.0",
@@ -598,7 +598,7 @@ async def evaluate_via_http():
598598
}
599599
}
600600
}
601-
601+
602602
response = await client.post(base_url, json=eval_request)
603603
result = response.json()
604604
print(f"Evaluation result: {result}")

mcpgateway/config.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -667,7 +667,9 @@ def validate_database(self) -> None:
667667
db_dir.mkdir(parents=True)
668668

669669
# Validation patterns for safe display (configurable)
670-
validation_dangerous_html_pattern: str = r"<(script|iframe|object|embed|link|meta|base|form|img|svg|video|audio|source|track|area|map|canvas|applet|frame|frameset|html|head|body|style)\b|</*(script|iframe|object|embed|link|meta|base|form|img|svg|video|audio|source|track|area|map|canvas|applet|frame|frameset|html|head|body|style)>"
670+
validation_dangerous_html_pattern: str = (
671+
r"<(script|iframe|object|embed|link|meta|base|form|img|svg|video|audio|source|track|area|map|canvas|applet|frame|frameset|html|head|body|style)\b|</*(script|iframe|object|embed|link|meta|base|form|img|svg|video|audio|source|track|area|map|canvas|applet|frame|frameset|html|head|body|style)>"
672+
)
671673

672674
validation_dangerous_js_pattern: str = r"(?i)(?:^|\s|[\"'`<>=])(javascript:|vbscript:|data:\s*[^,]*[;\s]*(javascript|vbscript)|\bon[a-z]+\s*=|<\s*script\b)"
673675

mcpgateway/validators.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,9 @@ class SecurityValidator:
6363
"""Configurable validation with MCP-compliant limits"""
6464

6565
# Configurable patterns (from settings)
66-
DANGEROUS_HTML_PATTERN = settings.validation_dangerous_html_pattern # Default: '<(script|iframe|object|embed|link|meta|base|form|img|svg|video|audio|source|track|area|map|canvas|applet|frame|frameset|html|head|body|style)\b|</*(script|iframe|object|embed|link|meta|base|form|img|svg|video|audio|source|track|area|map|canvas|applet|frame|frameset|html|head|body|style)>'
66+
DANGEROUS_HTML_PATTERN = (
67+
settings.validation_dangerous_html_pattern
68+
) # Default: '<(script|iframe|object|embed|link|meta|base|form|img|svg|video|audio|source|track|area|map|canvas|applet|frame|frameset|html|head|body|style)\b|</*(script|iframe|object|embed|link|meta|base|form|img|svg|video|audio|source|track|area|map|canvas|applet|frame|frameset|html|head|body|style)>'
6769
DANGEROUS_JS_PATTERN = settings.validation_dangerous_js_pattern # Default: javascript:|vbscript:|on\w+\s*=|data:.*script
6870
ALLOWED_URL_SCHEMES = settings.validation_allowed_url_schemes # Default: ["http://", "https://", "ws://", "wss://"]
6971

0 commit comments

Comments
 (0)