Cleanup and lint

Signed-off-by: Mihai Criveti <[email protected]>

Author: crivetimihai

tests/unit/mcpgateway/services/test_completion_service.py

@@ -151,7 +151,6 @@ class DummySession:
     assert "Missing URI template" in str(exc.value)
 
 
-
 @pytest.mark.asyncio
 async def test_complete_resource_values():
     service = CompletionService()

tests/unit/mcpgateway/services/test_gateway_service.py

@@ -81,9 +81,7 @@ def _inject_check_gateway_health(monkeypatch):
 
     async def _check(self, gateway):
         try:
-            await self._initialize_gateway(
-                gateway.url, getattr(gateway, "auth_value", {}), getattr(gateway, "transport", "sse")
-            )
+            await self._initialize_gateway(gateway.url, getattr(gateway, "auth_value", {}), getattr(gateway, "transport", "sse"))
             gateway.last_seen = datetime.now(timezone.utc)
             return True
         except Exception:
@@ -147,8 +145,8 @@ async def test_register_gateway(self, gateway_service, test_db):
         # DB: no gateway with that name; no existing tools found
         test_db.execute = Mock(
             side_effect=[
-                _make_execute_result(scalar=None),        # name-conflict check
-                _make_execute_result(scalars_list=[]),    # tool lookup
+                _make_execute_result(scalar=None),  # name-conflict check
+                _make_execute_result(scalars_list=[]),  # tool lookup
             ]
         )
         test_db.add = Mock()
@@ -188,7 +186,6 @@ async def test_register_gateway(self, gateway_service, test_db):
         assert result.url == "http://example.com/gateway"
         assert result.description == "A test gateway"
 
-
     @pytest.mark.asyncio
     async def test_register_gateway_name_conflict(self, gateway_service, mock_gateway, test_db):
         """Trying to register a gateway whose *name* already exists raises a conflict error."""
@@ -228,7 +225,6 @@ async def test_register_gateway_connection_error(self, gateway_service, test_db)
 
         assert "Failed to connect" in str(exc_info.value)
 
-
     # ────────────────────────────────────────────────────────────────────
     # LIST / GET
     # ────────────────────────────────────────────────────────────────────
@@ -398,9 +394,7 @@ async def test_forward_request(self, gateway_service, mock_gateway):
         """Happy-path RPC forward."""
         mock_response = AsyncMock()
         mock_response.raise_for_status = Mock()
-        mock_response.json = Mock(
-            return_value={"jsonrpc": "2.0", "result": {"success": True, "data": "OK"}, "id": 1}
-        )
+        mock_response.json = Mock(return_value={"jsonrpc": "2.0", "result": {"success": True, "data": "OK"}, "id": 1})
         gateway_service._http_client.post.return_value = mock_response
 
         result = await gateway_service.forward_request(mock_gateway, "method", {"p": 1})
@@ -413,9 +407,7 @@ async def test_forward_request_error_response(self, gateway_service, mock_gatewa
         """Gateway returns JSON-RPC error."""
         mock_response = AsyncMock()
         mock_response.raise_for_status = Mock()
-        mock_response.json = Mock(
-            return_value={"jsonrpc": "2.0", "error": {"code": -32000, "message": "Boom"}, "id": 1}
-        )
+        mock_response.json = Mock(return_value={"jsonrpc": "2.0", "error": {"code": -32000, "message": "Boom"}, "id": 1})
         gateway_service._http_client.post.return_value = mock_response
 
         with pytest.raises(GatewayError) as exc_info:

tests/unit/mcpgateway/services/test_logging_service.py

@@ -27,7 +27,6 @@
 from mcpgateway.services.logging_service import LoggingService
 from mcpgateway.types import LogLevel
 
-
 # ---------------------------------------------------------------------------
 # Basic behaviour
 # ---------------------------------------------------------------------------

tests/unit/mcpgateway/services/test_prompt_service.py

@@ -33,7 +33,6 @@
 )
 from mcpgateway.types import LogLevel, Message, PromptResult, Role, TextContent
 
-
 # ---------------------------------------------------------------------------
 # helpers
 # ---------------------------------------------------------------------------
@@ -56,7 +55,6 @@ def _make_execute_result(*, scalar: Any = None, scalars_list: Optional[list] = N
     return result
 
 
-
 def _build_db_prompt(
     *,
     pid: int = 1,
@@ -184,10 +182,12 @@ async def test_get_prompt_not_found(self, prompt_service, test_db):
     @pytest.mark.asyncio
     async def test_update_prompt_success(self, prompt_service, test_db):
         existing = _build_db_prompt()
-        test_db.execute = Mock(side_effect=[  # first call = find existing, second = conflict check
-            _make_execute_result(scalar=existing),
-            _make_execute_result(scalar=None),
-        ])
+        test_db.execute = Mock(
+            side_effect=[  # first call = find existing, second = conflict check
+                _make_execute_result(scalar=existing),
+                _make_execute_result(scalar=None),
+            ]
+        )
         test_db.commit = Mock()
         test_db.refresh = Mock()
         prompt_service._notify_prompt_updated = AsyncMock()
@@ -204,10 +204,12 @@ async def test_update_prompt_success(self, prompt_service, test_db):
     async def test_update_prompt_name_conflict(self, prompt_service, test_db):
         existing = _build_db_prompt()
         conflicting = _build_db_prompt(pid=2, name="other")
-        test_db.execute = Mock(side_effect=[
-            _make_execute_result(scalar=existing),
-            _make_execute_result(scalar=conflicting),
-        ])
+        test_db.execute = Mock(
+            side_effect=[
+                _make_execute_result(scalar=existing),
+                _make_execute_result(scalar=conflicting),
+            ]
+        )
         upd = PromptUpdate(name="other")
         with pytest.raises(PromptError) as exc_info:
             await prompt_service.update_prompt(test_db, "hello", upd)
@@ -259,15 +261,17 @@ async def test_delete_prompt_not_found(self, prompt_service, test_db):
     @pytest.mark.asyncio
     async def test_aggregate_and_reset_metrics(self, prompt_service, test_db):
         # Metrics numbers to be returned by scalar() calls
-        test_db.execute = Mock(side_effect=[
-            _make_execute_result(scalar=10),  # total
-            _make_execute_result(scalar=8),   # successful
-            _make_execute_result(scalar=2),   # failed
-            _make_execute_result(scalar=0.1),  # min_rt
-            _make_execute_result(scalar=0.9),  # max_rt
-            _make_execute_result(scalar=0.5),  # avg_rt
-            _make_execute_result(scalar=datetime(2025, 1, 1, tzinfo=timezone.utc)),  # last_time
-        ])
+        test_db.execute = Mock(
+            side_effect=[
+                _make_execute_result(scalar=10),  # total
+                _make_execute_result(scalar=8),  # successful
+                _make_execute_result(scalar=2),  # failed
+                _make_execute_result(scalar=0.1),  # min_rt
+                _make_execute_result(scalar=0.9),  # max_rt
+                _make_execute_result(scalar=0.5),  # avg_rt
+                _make_execute_result(scalar=datetime(2025, 1, 1, tzinfo=timezone.utc)),  # last_time
+            ]
+        )
 
         metrics = await prompt_service.aggregate_metrics(test_db)
         assert metrics["total_executions"] == 10

tests/unit/mcpgateway/services/test_resource_service.py

@@ -13,10 +13,10 @@
 
 from mcpgateway.schemas import ResourceCreate, ResourceRead
 from mcpgateway.services.resource_service import (
+    ResourceError,
     ResourceNotFoundError,
     ResourceService,
     ResourceURIConflictError,
-    ResourceError
 )
 
 

tests/unit/mcpgateway/services/test_root_service.py

@@ -103,7 +103,6 @@ async def test_initialize_adds_default_roots(monkeypatch):
     await service.shutdown()
 
 
-
 @pytest.mark.asyncio
 async def test_subscribe_changes_receives_events():
     service = RootService()
@@ -112,7 +111,7 @@ async def test_subscribe_changes_receives_events():
     async def subscriber():
         async for ev in service.subscribe_changes():
             events.append(ev)
-            if len(events) >= 2:        # expect "added" then "removed"
+            if len(events) >= 2:  # expect "added" then "removed"
                 break
 
     # Start subscription and give the event-loop one tick so the queue
@@ -122,7 +121,7 @@ async def subscriber():
 
     # Add a root, then remove it again.
     r = await service.add_root("subscriber-test")
-    await service.remove_root(str(r.uri).rstrip("/"))   # match stored key
+    await service.remove_root(str(r.uri).rstrip("/"))  # match stored key
 
     # Collect both events or time-out
     await asyncio.wait_for(task, timeout=1.0)