Merge pull request #201 from IBM/pyrefly-check

Add pyrefly static type checker to Makefile and dev dependencies

Author: crivetimihai

.dockerignore

@@ -1,3 +1,4 @@
+mcp-servers/go/fast-time-server/Dockerfile
 Dockerfile
 Dockerfile.*
 Containerfile.*

Makefile

@@ -337,6 +337,7 @@ images:
 # help: fawltydeps           - Detect undeclared / unused deps
 # help: wily                 - Maintainability report
 # help: pyre                 - Static analysis with Facebook Pyre
+# help: pyrefly              - Static analysis with Facebook Pyrefly
 # help: depend               - List dependencies in ≈requirements format
 # help: snakeviz             - Profile & visualise with snakeviz
 # help: pstats               - Generate PNG call-graph from cProfile stats
@@ -348,7 +349,7 @@ images:
 
 # List of individual lint targets; lint loops over these
 LINTERS := isort flake8 pylint mypy bandit pydocstyle pycodestyle pre-commit \
-           ruff pyright radon pyroma pyre spellcheck importchecker \
+           ruff pyright radon pyroma pyrefly spellcheck importchecker \
 		   pytype check-manifest markdownlint
 
 .PHONY: lint $(LINTERS) black fawltydeps wily depend snakeviz pstats \
@@ -439,6 +440,9 @@ wily:                               ## 📈  Maintainability report
 pyre:                               ## 🧠  Facebook Pyre analysis
 	@$(VENV_DIR)/bin/pyre
 
+pyrefly:                            ## 🧠  Facebook Pyrefly analysis (faster, rust)
+	@$(VENV_DIR)/bin/pyrefly check mcpgateway
+
 depend:                             ## 📦  List dependencies
 	pdm list --freeze
 
@@ -654,8 +658,9 @@ sonar-deps-podman:
 	python3 -m pip install --quiet podman-compose
 
 sonar-deps-docker:
-	@echo "🔧 Ensuring docker-compose is available …"
-	@which docker-compose >/dev/null || python3 -m pip install --quiet docker-compose
+	@echo "🔧 Ensuring $(COMPOSE_CMD) is available …"
+	@command -v $(firstword $(COMPOSE_CMD)) >/dev/null || \
+	  python3 -m pip install --quiet docker-compose
 
 ## ─────────── Run SonarQube server (compose) ────────────────────────────
 sonar-up-podman:
@@ -665,10 +670,11 @@ sonar-up-podman:
 	@sleep 30 && podman ps | grep sonarqube || echo "⚠️  Server may still be starting."
 
 sonar-up-docker:
-	@echo "🚀 Starting SonarQube (v$(SONARQUBE_VERSION)) with docker-compose …"
+	@echo "🚀 Starting SonarQube (v$(SONARQUBE_VERSION)) with $(COMPOSE_CMD) …"
 	SONARQUBE_VERSION=$(SONARQUBE_VERSION) \
-	docker-compose -f podman-compose-sonarqube.yaml up -d
-	@sleep 30 && docker ps | grep sonarqube || echo "⚠️  Server may still be starting."
+	$(COMPOSE_CMD) -f podman-compose-sonarqube.yaml up -d
+	@sleep 30 && $(COMPOSE_CMD) ps | grep sonarqube || \
+	  echo "⚠️  Server may still be starting."
 
 ## ─────────── Containerised Scanner CLI (Docker / Podman) ───────────────
 sonar-submit-docker:

pyproject.toml

@@ -123,6 +123,7 @@ dev = [
     "pylint>=3.3.7",
     "pylint-pydantic>=0.3.5",
     "pyre-check>=0.9.23",
+    "pyrefly>=0.21.0",
     "pyright>=1.1.402",
     "pyroma>=4.2",
     "pyspelling>=2.10",
@@ -365,3 +366,14 @@ ignore_unused = [
   "twine",
   "uvicorn"
 ]
+
+# --------------------------------------------------------------------
+#  🛠  https://github.com/facebook/pyrefly (replaces pyre)
+# --------------------------------------------------------------------
+[tool.pyrefly]
+project-excludes = [
+    "**/build/",
+    '**/\.venv/',
+    '**/\.mypy_cache/',
+]
+python-version = "3.11.0"

tests/unit/mcpgateway/services/test_resource_service.py

@@ -177,7 +177,6 @@ async def test_register_resource_success(self, resource_service, mock_db, sample
             patch.object(resource_service, "_notify_resource_added", new_callable=AsyncMock),
             patch.object(resource_service, "_convert_resource_to_read") as mock_convert,
         ):
-
             mock_convert.return_value = ResourceRead(
                 id=1,
                 uri=sample_resource_create.uri,
@@ -263,7 +262,6 @@ async def test_register_resource_integrity_error(self, resource_service, mock_db
 
         # Mock validation success
         with patch.object(resource_service, "_is_valid_uri", return_value=True), patch.object(resource_service, "_detect_mime_type", return_value="text/plain"):
-
             # Mock IntegrityError on commit
             mock_db.commit.side_effect = IntegrityError("", "", "")
 
@@ -290,7 +288,6 @@ async def test_register_resource_binary_content(self, resource_service, mock_db)
             patch.object(resource_service, "_notify_resource_added", new_callable=AsyncMock),
             patch.object(resource_service, "_convert_resource_to_read") as mock_convert,
         ):
-
             mock_convert.return_value = ResourceRead(
                 id=1,
                 uri=binary_resource.uri,
@@ -443,7 +440,6 @@ async def test_toggle_resource_status_activate(self, resource_service, mock_db,
         mock_db.get.return_value = mock_inactive_resource
 
         with patch.object(resource_service, "_notify_resource_activated", new_callable=AsyncMock), patch.object(resource_service, "_convert_resource_to_read") as mock_convert:
-
             mock_convert.return_value = ResourceRead(
                 id=2,
                 uri=mock_inactive_resource.uri,
@@ -478,7 +474,6 @@ async def test_toggle_resource_status_deactivate(self, resource_service, mock_db
         mock_db.get.return_value = mock_resource
 
         with patch.object(resource_service, "_notify_resource_deactivated", new_callable=AsyncMock), patch.object(resource_service, "_convert_resource_to_read") as mock_convert:
-
             mock_convert.return_value = ResourceRead(
                 id=1,
                 uri=mock_resource.uri,
@@ -564,7 +559,6 @@ async def test_update_resource_success(self, resource_service, mock_db, mock_res
         mock_db.execute.return_value = mock_scalar
 
         with patch.object(resource_service, "_notify_resource_updated", new_callable=AsyncMock), patch.object(resource_service, "_convert_resource_to_read") as mock_convert:
-
             mock_convert.return_value = ResourceRead(
                 id=1,
                 uri=mock_resource.uri,
@@ -634,7 +628,6 @@ async def test_update_resource_binary_content(self, resource_service, mock_db, m
         mock_db.execute.return_value = mock_scalar
 
         with patch.object(resource_service, "_notify_resource_updated", new_callable=AsyncMock), patch.object(resource_service, "_convert_resource_to_read") as mock_convert:
-
             mock_convert.return_value = ResourceRead(
                 id=1,
                 uri=mock_resource.uri,
@@ -983,7 +976,6 @@ async def test_read_template_resource_error(self, resource_service):
         resource_service._template_cache["template"] = template
 
         with patch.object(resource_service, "_uri_matches_template", return_value=True), patch.object(resource_service, "_extract_template_params", side_effect=Exception("Template error")):
-
             with pytest.raises(ResourceError) as exc_info:
                 await resource_service._read_template_resource(uri)
 
@@ -1002,7 +994,6 @@ async def test_read_template_resource_binary_not_supported(self, resource_servic
         resource_service._template_cache["binary"] = template
 
         with patch.object(resource_service, "_uri_matches_template", return_value=True), patch.object(resource_service, "_extract_template_params", return_value={"id": "123"}):
-
             with pytest.raises(ResourceError) as exc_info:
                 await resource_service._read_template_resource(uri)
 
@@ -1257,7 +1248,6 @@ async def test_register_resource_generic_error(self, resource_service, mock_db,
 
         # Mock validation success
         with patch.object(resource_service, "_is_valid_uri", return_value=True), patch.object(resource_service, "_detect_mime_type", return_value="text/plain"):
-
             # Mock generic error on add
             mock_db.add.side_effect = Exception("Generic error")