Filelock path rectification (#321)

* filelock_path updated as /tmp folder

Signed-off-by: Keval Mahajan <[email protected]>

* filelock_path uses temp_dir bydefault and then appends to the path configured

Signed-off-by: Keval Mahajan <[email protected]>

* updated FILELOCK_NAME

Signed-off-by: Keval Mahajan <[email protected]>

* updated filename_path

Signed-off-by: Keval Mahajan <[email protected]>

---------

Signed-off-by: Keval Mahajan <[email protected]>

Author: kevalmahajan

.env.example

@@ -241,7 +241,11 @@ UNHEALTHY_THRESHOLD=3
 #####################################
 # Lock file Settings
 #####################################
-FILELOCK_PATH=/tmp/gateway_healthcheck_init.lock
+
+# This path is append with the system temp directory. 
+# It is used to ensure that only one instance of the gateway health Check can run at a time.
+FILELOCK_NAME=gateway_healthcheck_init.lock   # saved dir in /tmp/gateway_healthcheck_init.lock
+# FILELOCK_NAME=somefolder/gateway_healthcheck_init.lock   # saved dir in /tmp/somefolder/gateway_healthcheck_init.lock#
 
 
 #####################################

charts/mcp-stack/README.md

@@ -51,7 +51,7 @@ Kubernetes: `>=1.21.0`
 | mcpContextForge.config.FEDERATION_PEERS | string | `"[]"` |  |
 | mcpContextForge.config.FEDERATION_SYNC_INTERVAL | string | `"300"` |  |
 | mcpContextForge.config.FEDERATION_TIMEOUT | string | `"30"` |  |
-| mcpContextForge.config.FILELOCK_PATH | string | `"/tmp/gateway_healthcheck_init.lock"` |  |
+| mcpContextForge.config.FILELOCK_NAME | string | `"gateway_healthcheck_init.lock"` |  |
 | mcpContextForge.config.GUNICORN_MAX_REQUESTS | string | `"10000"` |  |
 | mcpContextForge.config.GUNICORN_MAX_REQUESTS_JITTER | string | `"100"` |  |
 | mcpContextForge.config.GUNICORN_PRELOAD_APP | string | `"true"` |  |

charts/mcp-stack/values.schema.json

@@ -521,10 +521,10 @@
               "description": "Unhealthy threshold",
               "default": "3"
             },
-            "FILELOCK_PATH": {
+            "FILELOCK_NAME": {
               "type": "string",
               "description": "File lock path",
-              "default": "/tmp/gateway_healthcheck_init.lock"
+              "default": "gateway_healthcheck_init.lock"
             },
             "DEV_MODE": {
               "type": "string",

charts/mcp-stack/values.yaml

@@ -193,7 +193,7 @@ mcpContextForge:
     HEALTH_CHECK_INTERVAL: "60"      # seconds between peer health checks
     HEALTH_CHECK_TIMEOUT: "10"       # request timeout per health check
     UNHEALTHY_THRESHOLD: "3"         # failed checks before peer marked unhealthy
-    FILELOCK_PATH: /tmp/gateway_healthcheck_init.lock # lock file used at start-up
+    FILELOCK_NAME: gateway_healthcheck_init.lock # lock file used at start-up
 
     # ─ Development toggles ─
     DEV_MODE: "false"                # enable dev-mode features

mcpgateway/config.py

@@ -169,7 +169,7 @@ def _parse_federation_peers(cls, v):
     health_check_timeout: int = 10  # seconds
     unhealthy_threshold: int = 5  # after this many failures, mark as Offline
 
-    filelock_path: str = "tmp/gateway_service_leader.lock"
+    filelock_name: str = "gateway_service_leader.lock"
 
     # Default Roots
     default_roots: List[str] = []

mcpgateway/services/gateway_service.py

@@ -20,6 +20,8 @@
 import logging
 from typing import Any, AsyncGenerator, Dict, List, Optional, Set
 import uuid
+import tempfile
+import os
 
 # Third-Party
 from filelock import FileLock, Timeout
@@ -123,7 +125,13 @@ def __init__(self) -> None:
         elif settings.cache_type != "none":
             # Fallback: File-based lock
             self._redis_client = None
-            self._lock_path = settings.filelock_path
+
+            temp_dir = tempfile.gettempdir()
+            user_path = os.path.normpath(settings.filelock_name)
+            if os.path.isabs(user_path):
+                user_path = os.path.relpath(user_path, start=os.path.splitdrive(user_path)[0] + os.sep)
+            full_path = os.path.join(temp_dir, user_path)
+            self._lock_path = full_path.replace("\\", "/")
             self._file_lock = FileLock(self._lock_path)
         else:
             self._redis_client = None

tests/unit/mcpgateway/cache/test_resource_cache.py

@@ -7,6 +7,7 @@
 
 Unit tests for ResourceCache.
 """
+
 # Standard
 import asyncio
 import time