Change pylint settings (#244)

* pylintrc config

Signed-off-by: Mihai Criveti <[email protected]>

* Pylint cleanup

Signed-off-by: Mihai Criveti <[email protected]>

* pylint cleanup

Signed-off-by: Mihai Criveti <[email protected]>

* pylint cleanup

Signed-off-by: Mihai Criveti <[email protected]>

* pylint cleanup

Signed-off-by: Mihai Criveti <[email protected]>

---------

Signed-off-by: Mihai Criveti <[email protected]>

Author: crivetimihai

.pylintrc

@@ -88,7 +88,7 @@ persistent=yes
 
 # Minimum Python version to use for version dependent checks. Will default to
 # the version used to run pylint.
-py-version=3.9
+py-version=3.11
 
 # Discover python modules and packages in the file system subtree.
 recursive=no
@@ -291,7 +291,7 @@ max-args=12
 max-positional-arguments = 6
 
 # Maximum number of attributes for a class (see R0902).
-max-attributes=10
+max-attributes=16
 
 # Maximum number of boolean expressions in an if statement (see R0916).
 max-bool-expr=5
@@ -397,7 +397,9 @@ preferred-modules=
 
 # The type of string formatting that logging methods do. `old` means using %
 # formatting, `new` is for `{}` formatting.
-logging-format-style=new
+# Mihai: Not having this set to old triggers: E1205 (logging-too-many-args)
+#logging-format-style=new
+logging-format-style=old
 
 # Logging modules to check that the string format arguments are in logging
 # function parameter format.
@@ -476,7 +478,7 @@ notes-rgx=
 [REFACTORING]
 
 # Maximum number of nested blocks for function / method body
-max-nested-blocks=5
+max-nested-blocks=6
 
 # Complete name of functions that never returns. When checking for
 # inconsistent-return-statements if a never returning function is called then

docs/docs/development/developer-onboarding.md

@@ -11,7 +11,8 @@
     - [ ] Node.js and npm, npx (used for testing with `supergateway` and the HTML/JS Admin UI)
     - [ ] Docker, Docker Compose, and Podman
     - [ ] Make, GitHub CLI (`gh`), `curl`, `jq`, `openssl`
-    - [ ] Optional: Visual Studio Code + Dev Containers extension (or WSL2 if on Windows)
+    - [ ] Optional: Visual Studio Code + Dev Containers extension (or WSL2 if on Windows) + Pyrefly
+    - [ ] Optional: On Windows, install the WSL and Remote Development extensions
 
 ???+ check "Python tooling"
     - [ ] `pip install --upgrade pip`

mcpgateway/bootstrap_db.py

@@ -1,5 +1,24 @@
 # -*- coding: utf-8 -*-
-# mcpgateway/bootstrap_db.py
+"""Database bootstrap/upgrade entry-point for MCP Gateway.
+
+Copyright 2025
+SPDX-License-Identifier: Apache-2.0
+Authors: Madhav Kandukuri
+
+The script:
+
+1. Creates a synchronous SQLAlchemy ``Engine`` from ``settings.database_url``.
+2. Looks for an *alembic.ini* two levels up from this file to drive migrations.
+3. If the database is still empty (no ``gateways`` table), it:
+   - builds the base schema with ``Base.metadata.create_all()``
+   - stamps the migration head so Alembic knows it is up-to-date
+4. Otherwise, it applies any outstanding Alembic revisions.
+5. Logs a **"Database ready"** message on success.
+
+It is intended to be invoked via ``python -m mcpgateway.bootstrap_db`` or
+directly with ``python mcpgateway/bootstrap_db.py``.
+"""
+
 # Standard
 import asyncio
 import logging
@@ -17,12 +36,15 @@
 logger = logging.getLogger(__name__)
 
 
-async def main():
+async def main() -> None:
     """
     Bootstrap or upgrade the database schema, then log readiness.
 
     Runs `create_all()` + `alembic stamp head` on an empty DB, otherwise just
     executes `alembic upgrade head`, leaving application data intact.
+
+    Args:
+        None
     """
     engine = create_engine(settings.database_url)
     project_root = Path(__file__).resolve().parents[1]
@@ -34,7 +56,7 @@ async def main():
 
     insp = inspect(engine)
     if "gateways" not in insp.get_table_names():
-        logger.info("Empty DB detected – creating baseline schema")
+        logger.info("Empty DB detected - creating baseline schema")
         Base.metadata.create_all(engine)
         command.stamp(cfg, "head")  # record baseline
     else:

mcpgateway/db.py

@@ -110,7 +110,13 @@
 # ---------------------------------------------------------------------------
 # 6. Function to return UTC timestamp
 # ---------------------------------------------------------------------------
-def utc_now():
+def utc_now() -> datetime:
+    """Return the current Coordinated Universal Time (UTC).
+
+    Returns:
+        datetime: A timezone-aware `datetime` whose `tzinfo` is
+        `datetime.timezone.utc`.
+    """
     return datetime.now(timezone.utc)
 
 
@@ -122,6 +128,7 @@ class Base(DeclarativeBase):
     """Base class for all models."""
 
 
+# TODO: cleanup, not sure why this is commented out?
 # # Association table for tools and gateways (federation)
 # tool_gateway_table = Table(
 #     "tool_gateway_association",

pyproject.toml

@@ -24,13 +24,14 @@ classifiers = [
     "Programming Language :: Python :: 3",
     "Programming Language :: Python :: 3.11",
     "Programming Language :: Python :: 3.12",
+    "Programming Language :: Python :: 3.13",
     "Framework :: FastAPI",
     "Framework :: AsyncIO",
     "Topic :: Internet :: WWW/HTTP :: WSGI :: Application",
     "Topic :: Software Development :: Libraries :: Application Frameworks"
 ]
 readme = "README.md"
-requires-python = ">=3.11,<3.13"
+requires-python = ">=3.11,<3.14"
 
 # SPDX licence expression + explicit licence file (PEP 639)
 license = "Apache-2.0"

tests/unit/mcpgateway/transports/test_sse_transport.py

@@ -12,8 +12,7 @@
 # Standard
 import asyncio
 import json
-import types
-from unittest.mock import AsyncMock, Mock, patch
+from unittest.mock import Mock, patch
 
 # Third-Party
 from fastapi import Request

tests/unit/mcpgateway/transports/test_websocket_transport.py

@@ -9,9 +9,7 @@
 """
 
 # Standard
-import asyncio
 import logging
-import types
 from unittest.mock import AsyncMock
 
 # Third-Party