autoflake8 black isort

Signed-off-by: Mihai Criveti <[email protected]>

Author: crivetimihai

.gitignore

@@ -1,3 +1,4 @@
+debug_login_page.png
 docs/pstats.png
 mcp.prof
 mcp.pstats

Makefile

@@ -10,17 +10,22 @@
 # help: 🐍 MCP CONTEXT FORGE  (An enterprise-ready Model Context Protocol Gateway)
 #
 # ──────────────────────────────────────────────────────────────────────────
-# Project variables
+SHELL := /bin/bash
+.SHELLFLAGS := -eu -o pipefail -c
+
 # Read values from .env.make
 -include .env.make
 
+# Project variables
 PROJECT_NAME      = mcpgateway
 DOCS_DIR          = docs
 HANDSDOWN_PARAMS  = -o $(DOCS_DIR)/ -n $(PROJECT_NAME) --name "MCP Gateway" --cleanup
 
 TEST_DOCS_DIR ?= $(DOCS_DIR)/docs/test
 
+# -----------------------------------------------------------------------------
 # Project-wide clean-up targets
+# -----------------------------------------------------------------------------
 DIRS_TO_CLEAN := __pycache__ .pytest_cache .tox .ruff_cache .pyre .mypy_cache .pytype \
                  dist build site .eggs *.egg-info .cache htmlcov certs \
                  $(VENV_DIR) $(VENV_DIR).sbom $(COVERAGE_DIR) \
@@ -41,13 +46,21 @@ METRICS_MD   ?= $(DOCS_DIR)/docs/metrics/loc.md
 
 # -----------------------------------------------------------------------------
 # Container resource configuration
+# -----------------------------------------------------------------------------
 CONTAINER_MEMORY = 2048m
 CONTAINER_CPUS   = 2
 
 # Virtual-environment variables
 VENVS_DIR := $(HOME)/.venv
 VENV_DIR  := $(VENVS_DIR)/$(PROJECT_NAME)
 
+# -----------------------------------------------------------------------------
+# OS Specific
+# -----------------------------------------------------------------------------
+# The -r flag for xargs is GNU-specific and will fail on macOS
+XARGS_FLAGS := $(shell [ "$$(uname)" = "Darwin" ] && echo "" || echo "-r")
+
+
 # =============================================================================
 # 📖 DYNAMIC HELP
 # =============================================================================
@@ -98,10 +111,7 @@ venv:
 
 .PHONY: activate
 activate:
-	@echo -e "💡  Enter the venv using:\n    . $(VENV_DIR)/bin/activate\n"
-	@. $(VENV_DIR)/bin/activate
-	@echo "export MYPY_CACHE_DIR=/tmp/cache/mypy/$(PROJECT_NAME)"
-	@echo "export PYTHONPYCACHEPREFIX=/tmp/cache/$(PROJECT_NAME)"
+	@echo "💡  Enter the venv using:\n. $(VENV_DIR)/bin/activate\n"
 
 .PHONY: install
 install: venv
@@ -225,7 +235,7 @@ coverage:
 			--md-report --md-report-output=$(DOCS_DIR)/docs/test/unittest.md \
 			--dist loadgroup -n 8 -rA --cov-append --capture=tee-sys -v \
 			--durations=120 --doctest-modules app/ --cov-report=term \
-			--cov=app --ignore=test.py tests/ || true"
+			--cov=mcpgateway --ignore=test.py tests/ || true"
 	@printf '\n## Coverage report\n\n' >> $(DOCS_DIR)/docs/test/unittest.md
 	@/bin/bash -c "source $(VENV_DIR)/bin/activate && \
 		coverage report --format=markdown -m --no-skip-covered \
@@ -1319,7 +1329,7 @@ image-clean:
 	@echo "🧹 Removing all $(IMAGE_BASE) images..."
 	@$(CONTAINER_RUNTIME) images --format "{{.Repository}}:{{.Tag}}" | \
 		grep -E "(localhost/)?$(IMAGE_BASE)" | \
-		xargs -r $(CONTAINER_RUNTIME) rmi -f 2>/dev/null || true
+		xargs $(XARGS_FLAGS) $(CONTAINER_RUNTIME) rmi -f 2>/dev/null
 	@echo "✅ Images cleaned"
 
 # Fix image naming issues

playwright.config.py

@@ -1,7 +1,11 @@
 # -*- coding: utf-8 -*-
+# Standard
 import os
+
+# Third-Party
 from playwright.sync_api import Playwright
 
+
 def pytest_configure(config):
     """Configure Playwright for pytest runs."""
     os.environ.setdefault("PLAYWRIGHT_BROWSERS_PATH", os.path.expanduser("~/.cache/ms-playwright"))

tests/playwright/conftest.py

@@ -7,13 +7,12 @@
 # Standard
 import base64
 import os
+import re
 from typing import Generator
 
 # Third-Party
 from playwright.sync_api import APIRequestContext, Page, Playwright
 import pytest
-import re
-from playwright.sync_api import Page, Browser, BrowserContext
 
 # Get configuration from environment
 BASE_URL = os.getenv("TEST_BASE_URL", "http://localhost:8000")
@@ -78,6 +77,7 @@ def authenticated_page(page: Page) -> Page:
     """Alias for page fixture."""
     return page
 
+
 @pytest.fixture
 def admin_page(page: Page):
     """Provide a logged-in admin page for UI tests."""
@@ -87,10 +87,13 @@ def admin_page(page: Page):
     page.wait_for_url(re.compile(r".*admin"))
     return page
 
+
 @pytest.fixture
 def test_tool_data():
     """Provide test data for tool creation."""
+    # Standard
     import uuid
+
     unique_id = uuid.uuid4()
     return {
         "name": f"test-api-tool-{unique_id}",
@@ -99,9 +102,10 @@ def test_tool_data():
         "integrationType": "REST",
         "requestType": "GET",
         "headers": '{"Authorization": "Bearer test-token"}',
-        "input_schema": '{"type": "object", "properties": {"query": {"type": "string"}}}'
+        "input_schema": '{"type": "object", "properties": {"query": {"type": "string"}}}',
     }
 
+
 @pytest.fixture(autouse=True)
 def setup_test_environment(page: Page):
     """Set viewport and default timeout for consistent UI tests."""

tests/playwright/entities/test_tools.py

@@ -1,20 +1,22 @@
 # -*- coding: utf-8 -*-
-import pytest
-from playwright.sync_api import Page, expect
+# Third-Party
+from playwright.sync_api import expect, Page
+
 
 class TestToolsCRUD:
     """CRUD tests for Tools entity in MCP Gateway Admin UI.
 
     Examples:
         pytest tests/playwright/entities/test_tools.py
     """
+
     def test_create_new_tool(self, page: Page, test_tool_data, admin_page):
         """Test creating a new tool with debug screenshots and waits."""
         # Go to the Global Tools tab (if not already there)
         page.click('[data-testid="tools-tab"]')
 
         # Wait for the tools panel to be visible
-        page.wait_for_selector('#tools-panel:not(.hidden)')
+        page.wait_for_selector("#tools-panel:not(.hidden)")
 
         # Add a small delay to ensure the UI has time to update
         page.wait_for_timeout(500)
@@ -41,7 +43,7 @@ def test_delete_tool(self, page: Page, test_tool_data, admin_page):
         page.click('[data-testid="tools-tab"]')
 
         # Wait for the tools panel to be visible
-        page.wait_for_selector('#tools-panel:not(.hidden)')
+        page.wait_for_selector("#tools-panel:not(.hidden)")
 
         # Create tool first
         page.locator('#add-tool-form [name="name"]').fill(test_tool_data["name"])

tests/playwright/test_admin_ui.py

@@ -2,8 +2,8 @@
 """Test cases for admin UI."""
 
 # Third-Party
-import pytest
 from playwright.sync_api import expect, Page
+import pytest
 
 # Local
 from .pages.admin_page import AdminPage

tests/playwright/test_api_endpoints.py

@@ -2,8 +2,8 @@
 """Test API endpoints through UI interactions."""
 
 # Third-Party
-import pytest
 from playwright.sync_api import APIRequestContext, expect, Page
+import pytest
 
 
 class TestAPIEndpoints:

tests/playwright/test_api_integration.py

@@ -1,20 +1,25 @@
 # -*- coding: utf-8 -*-
+# Third-Party
+from playwright.sync_api import APIRequestContext, expect, Page
 import pytest
-from playwright.sync_api import Page, expect, APIRequestContext
+
 
 class TestAPIIntegration:
     """API integration tests for MCP protocol and REST endpoints.
 
     Examples:
         pytest tests/playwright/test_api_integration.py
     """
+
     @pytest.mark.skip(reason="Temporarily disabled for demonstration purposes")
     def test_should_handle_mcp_protocol_requests(self, page: Page, admin_page):
         """Test MCP protocol API integration via UI."""
         api_calls = []
+
         def handle_request(route):
             api_calls.append(route.request.url)
             route.continue_()
+
         page.route("/api/mcp/**", handle_request)
         page.click("#tab-tools")
         page.wait_for_selector("#tools-panel")
@@ -33,17 +38,10 @@ def test_mcp_initialize_endpoint(self, page: Page, request: APIRequestContext, a
         cookies = page.context.cookies()
         jwt_cookie = next((c for c in cookies if c["name"] == "jwt_token"), None)
         assert jwt_cookie is not None
-        response = request.post("/api/mcp/initialize",
+        response = request.post(
+            "/api/mcp/initialize",
             headers={"Cookie": f"jwt_token={jwt_cookie['value']}"},
-            data={
-                "jsonrpc": "2.0",
-                "method": "initialize",
-                "params": {
-                    "protocolVersion": "2025-03-26",
-                    "capabilities": {}
-                },
-                "id": 1
-            }
+            data={"jsonrpc": "2.0", "method": "initialize", "params": {"protocolVersion": "2025-03-26", "capabilities": {}}, "id": 1},
         )
         assert response.ok
         data = response.json()

tests/playwright/test_auth.py

@@ -1,13 +1,16 @@
 # -*- coding: utf-8 -*-
+# Standard
 import os
 import re
-import pytest
+
+# Third-Party
 from playwright.sync_api import expect
 
 BASE_URL = os.getenv("TEST_BASE_URL", "http://localhost:8000")
 BASIC_AUTH_USER = os.getenv("BASIC_AUTH_USER", "admin")
 BASIC_AUTH_PASSWORD = os.getenv("BASIC_AUTH_PASSWORD", "changeme")
 
+
 class TestAuthentication:
     """Authentication tests for MCP Gateway Admin UI.
 
@@ -16,6 +19,7 @@ class TestAuthentication:
     Examples:
         pytest tests/playwright/test_auth.py
     """
+
     def test_should_login_with_valid_credentials(self, browser):
         """Test successful access with valid HTTP Basic Auth credentials."""
         context = browser.new_context(
@@ -27,7 +31,7 @@ def test_should_login_with_valid_credentials(self, browser):
         page = context.new_page()
         # Go directly to admin - HTTP Basic Auth handles authentication
         page.goto(f"{BASE_URL}/admin")
-        page.screenshot(path="debug_login_page.png")
+        #page.screenshot(path="debug_login_page.png")
 
         # Verify we successfully accessed the admin page
         expect(page).to_have_url(re.compile(r".*admin"))

tests/playwright/test_htmx_interactions.py

@@ -1,14 +1,16 @@
 # -*- coding: utf-8 -*-
-import re
+# Third-Party
+from playwright.sync_api import expect, Page
 import pytest
-from playwright.sync_api import Page, expect
+
 
 class TestHTMXInteractions:
     """HTMX and UI interaction tests for MCP Gateway Admin UI.
 
     Examples:
         pytest tests/playwright/test_htmx_interactions.py
     """
+
     @pytest.fixture(autouse=True)
     def setup(self, admin_page):
         """Login before each test."""
@@ -48,6 +50,8 @@ def test_htmx_polling_updates(self, page: Page, admin_page):
         page.wait_for_selector("#servers-table")
         # Wait for polling (simulate with sleep or wait for content change)
         # This is a placeholder; in real test, use a more robust polling check
+        # Standard
         import time
+
         time.sleep(2)
         expect(page.locator("#servers-table")).to_be_visible()