Cleanup and lint

Signed-off-by: Mihai Criveti <[email protected]>

Author: crivetimihai

.github/workflows/snyk.yml.inactive

@@ -60,7 +60,7 @@ jobs:
   dependencies:
     name: 📦 Dependency Scan
     runs-on: ubuntu-latest
-    
+
     steps:
       # -------------------------------------------------------------
       # 0️⃣  Checkout source
@@ -108,7 +108,7 @@ jobs:
   code-security:
     name: 🔐 Code Security (SAST)
     runs-on: ubuntu-latest
-    
+
     steps:
       # -------------------------------------------------------------
       # 0️⃣  Checkout source
@@ -163,7 +163,7 @@ jobs:
   container-security:
     name: 🐳 Container Security
     runs-on: ubuntu-latest
-    
+
     steps:
       # -------------------------------------------------------------
       # 0️⃣  Checkout source
@@ -223,7 +223,7 @@ jobs:
   iac-security:
     name: 🏗️ IaC Security
     runs-on: ubuntu-latest
-    
+
     steps:
       # -------------------------------------------------------------
       # 0️⃣  Checkout source
@@ -253,7 +253,7 @@ jobs:
                 --json-file-output="snyk-iac-${file%.y*ml}.json" || true
             fi
           done
-          
+
           # Test Containerfiles
           for file in Containerfile*; do
             if [ -f "$file" ]; then
@@ -308,7 +308,7 @@ jobs:
     name: 📋 Generate SBOM
     runs-on: ubuntu-latest
     if: github.event_name == 'push' && github.ref == 'refs/heads/main'
-    
+
     steps:
       # -------------------------------------------------------------
       # 0️⃣  Checkout source
@@ -337,7 +337,7 @@ jobs:
         run: |
           # Get version from pyproject.toml
           VERSION=$(grep -m1 version pyproject.toml | cut -d'"' -f2 || echo "0.0.0")
-          
+
           # Generate CycloneDX format
           snyk sbom \
             --format=cyclonedx1.5+json \
@@ -346,7 +346,7 @@ jobs:
             --version=$VERSION \
             --json-file-output=sbom-cyclonedx.json \
             . || true
-          
+
           # Generate SPDX format
           snyk sbom \
             --format=spdx2.3+json \
@@ -376,7 +376,7 @@ jobs:
     runs-on: ubuntu-latest
     needs: [dependencies, code-security, container-security, iac-security]
     if: always()
-    
+
     steps:
       # -------------------------------------------------------------
       # 0️⃣  Download all artifacts
@@ -397,16 +397,16 @@ jobs:
           echo "**Triggered by:** ${{ github.event_name }}" >> $GITHUB_STEP_SUMMARY
           echo "**Severity Threshold:** ${{ github.event.inputs.severity-threshold || 'high' }}" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
-          
+
           echo "## 📋 Scan Results" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
-          
+
           # List all result files
           echo "### 📁 Generated Reports:" >> $GITHUB_STEP_SUMMARY
           find snyk-results -type f -name "*.json" -o -name "*.sarif" | while read -r file; do
             echo "- \`$(basename "$file")\`" >> $GITHUB_STEP_SUMMARY
           done
-          
+
           echo "" >> $GITHUB_STEP_SUMMARY
           echo "---" >> $GITHUB_STEP_SUMMARY
-          echo "*View detailed results in the [Security tab](../../security/code-scanning) or download artifacts from this workflow run.*" >> $GITHUB_STEP_SUMMARY
+          echo "*View detailed results in the [Security tab](../../security/code-scanning) or download artifacts from this workflow run.*" >> $GITHUB_STEP_SUMMARY

docker-compose.yml

@@ -396,4 +396,3 @@ services:
   #     timeout: 10s
   #     retries: 5
   #     start_period: 20s
-

docs/docs/best-practices/mcp-best-practices.md

@@ -106,19 +106,19 @@ time_server/
 ├── .gitignore                     # Exclude venvs, artifacts, and secrets from Git
 ├── docs/                          # (Optional) Diagrams, specs, and additional documentation
 ├── tests/                         # Unit and integration tests
-│   ├── __init__.py
-│   ├── test_main.py               # Tests for main entrypoint behavior
-│   └── test_tools.py              # Tests for core tool functionality
+│   ├── __init__.py
+│   ├── test_main.py               # Tests for main entrypoint behavior
+│   └── test_tools.py              # Tests for core tool functionality
 └── src/                           # Application source code
-    └── mcp_time_server/           # Main package named after your server
-        ├── __init__.py            # Marks this directory as a Python package
-        ├── main.py                # Entrypoint that wires everything together
-        ├── mcp_server_base.py     # Optional base class for shared server behavior
-        ├── server.py              # Server logic (e.g., tool registration, lifecycle hooks)
-        └── tools/                 # Directory for all MCP tool implementations
-            ├── __init__.py
-            ├── tools.py           # Tool business logic (e.g., `get_time`, `format_time`)
-            └── tools_registration.py # Registers tools into the MCP framework
+    └── mcp_time_server/           # Main package named after your server
+        ├── __init__.py            # Marks this directory as a Python package
+        ├── main.py                # Entrypoint that wires everything together
+        ├── mcp_server_base.py     # Optional base class for shared server behavior
+        ├── server.py              # Server logic (e.g., tool registration, lifecycle hooks)
+        └── tools/                 # Directory for all MCP tool implementations
+            ├── __init__.py
+            ├── tools.py           # Tool business logic (e.g., `get_time`, `format_time`)
+            └── tools_registration.py # Registers tools into the MCP framework
 ```
 
 ## 📝 Documentation
@@ -165,7 +165,7 @@ MCP_GITHUB_BASE_URL=...
 
 ## 🏷 Required Capabilities (README Metadata Tags)
 
-Add tags at the top of `README.md` between YAML markers to declare your server’s required capabilities.
+Add tags at the top of `README.md` between YAML markers to declare your server's required capabilities.
 
 ### Available Tags:
 
@@ -195,4 +195,4 @@ tags:
   - needs_filesystem_access
   - needs_api_key_user
 ---
-```
+```

tests/unit/mcpgateway/services/test_gateway_service.py

@@ -278,7 +278,6 @@ async def test_ssl_verification_bypass(self, gateway_service, monkeypatch):
         Test case logic to verify settings.skip_ssl_verify
 
         """
-        pass
 
     # ────────────────────────────────────────────────────────────────────
     # Validate Gateway URL Auth Failure - 401
@@ -433,7 +432,7 @@ async def test_bulk_concurrent_validation(self, gateway_service, monkeypatch):
         resilient_client_mock.client = mock_client
         resilient_client_mock.aclose = AsyncMock()
 
-        # Patch ResilientHttpClient where it’s used in your module
+        # Patch ResilientHttpClient where it's used in your module
         monkeypatch.setattr("mcpgateway.services.gateway_service.ResilientHttpClient", MagicMock(return_value=resilient_client_mock))
 
         # Run the validations concurrently