Improved test_constant_time_operations method (#684)

* Improved test_constant_time_operations method

Signed-off-by: Sebastian <[email protected]>

* Typo

Signed-off-by: Sebastian <[email protected]>

---------

Signed-off-by: Sebastian <[email protected]>
Co-authored-by: Sebastian <[email protected]>

Author: ChrisPC-39

tests/security/test_input_validation.py

@@ -1780,40 +1780,35 @@ def test_constant_time_operations(self):
         """Test that validation doesn't leak timing information."""
         logger.debug("Testing constant-time validation")
 
-        # Standard
-        import statistics
         import time
+        import statistics
 
-        # Test multiple validation attempts
         valid_times = []
         invalid_times = []
 
-        for _ in range(10):
-            # Valid input
+        # Actual measurement
+        for _ in range(100):
             start = time.time()
             try:
                 ToolCreate(name="valid_name", url="https://example.com")
             except:
                 pass
-            valid_times.append(time.time() - start)
+            valid_times.append(time.perf_counter() - start)
 
-            # Invalid input
-            start = time.time()
+            start = time.perf_counter()
             try:
                 ToolCreate(name="<script>alert('XSS')</script>", url="https://example.com")
             except:
                 pass
-            invalid_times.append(time.time() - start)
+            invalid_times.append(time.perf_counter() - start)
 
-        # Calculate statistics
-        valid_avg = statistics.mean(valid_times)
-        invalid_avg = statistics.mean(invalid_times)
+        valid_median = statistics.median(valid_times)
+        invalid_median = statistics.median(invalid_times)
 
-        logger.debug(f"Valid input avg time: {valid_avg:.6f}s")
-        logger.debug(f"Invalid input avg time: {invalid_avg:.6f}s")
+        logger.debug(f"Valid median: {valid_median:.9f}s")
+        logger.debug(f"Invalid median: {invalid_median:.9f}s")
 
-        # Times should be similar (within 50% of each other)
-        ratio = max(valid_avg, invalid_avg) / min(valid_avg, invalid_avg)
+        ratio = max(valid_median, invalid_median) / min(valid_median, invalid_median)
         assert ratio < 1.5, f"Timing difference too large: {ratio:.2f}x"