Fix/passthrough header save (#868)

* save passthrough headers in update gateway

Signed-off-by: Arjav <[email protected]>

* remove updated_at

Signed-off-by: Arjav <[email protected]>

* Fix passthrough headers not saving in add forms

- Add missing passthrough_headers field to DbGateway creation in register_gateway()
- Add method="POST" to add-tool-form, add-resource-form, and add-gateway-form
- Standardize all add form handlers to use fetch() instead of fetchWithTimeout()
- Remove redirect: "manual" option that was interfering with form responses

---------

Signed-off-by: Arjav <[email protected]>
Co-authored-by: Mihai Criveti <[email protected]>

Author: arjavdongaonkar

mcpgateway/services/gateway_service.py

@@ -560,6 +560,7 @@ async def register_gateway(
                 auth_type=auth_type,
                 auth_value=auth_value,
                 oauth_config=oauth_config,
+                passthrough_headers=gateway.passthrough_headers,
                 tools=tools,
                 resources=db_resources,
                 prompts=db_prompts,
@@ -889,6 +890,17 @@ async def update_gateway(self, db: Session, gateway_id: str, gateway_update: Gat
                     gateway.transport = gateway_update.transport
                 if gateway_update.tags is not None:
                     gateway.tags = gateway_update.tags
+                if gateway_update.passthrough_headers is not None:
+                    if isinstance(gateway_update.passthrough_headers, list):
+                        gateway.passthrough_headers = gateway_update.passthrough_headers
+                    else:
+                        if isinstance(gateway_update.passthrough_headers, str):
+                            parsed = [h.strip() for h in gateway_update.passthrough_headers.split(",") if h.strip()]
+                            gateway.passthrough_headers = parsed
+                        else:
+                            raise GatewayError("Invalid passthrough_headers format: must be list[str] or comma-separated string")
+
+                    logger.info("Updated passthrough_headers for gateway {gateway.id}: {gateway.passthrough_headers}")
 
                 if getattr(gateway, "auth_type", None) is not None:
                     gateway.auth_type = gateway_update.auth_type

mcpgateway/static/admin.js

@@ -6903,13 +6903,10 @@ async function handleGatewayFormSubmit(e) {
             formData.append("oauth_config", JSON.stringify(oauthConfig));
         }
 
-        const response = await fetchWithTimeout(
-            `${window.ROOT_PATH}/admin/gateways`,
-            {
-                method: "POST",
-                body: formData,
-            },
-        );
+        const response = await fetch(`${window.ROOT_PATH}/admin/gateways`, {
+            method: "POST",
+            body: formData,
+        });
         const result = await response.json();
 
         if (!result || !result.success) {
@@ -6967,13 +6964,10 @@ async function handleResourceFormSubmit(e) {
         const isInactiveCheckedBool = isInactiveChecked("resources");
         formData.append("is_inactive_checked", isInactiveCheckedBool);
 
-        const response = await fetchWithTimeout(
-            `${window.ROOT_PATH}/admin/resources`,
-            {
-                method: "POST",
-                body: formData,
-            },
-        );
+        const response = await fetch(`${window.ROOT_PATH}/admin/resources`, {
+            method: "POST",
+            body: formData,
+        });
         const result = await response.json();
         if (!result || !result.success) {
             throw new Error(result?.message || "Failed to add Resource");
@@ -7025,13 +7019,10 @@ async function handlePromptFormSubmit(e) {
         const isInactiveCheckedBool = isInactiveChecked("prompts");
         formData.append("is_inactive_checked", isInactiveCheckedBool);
 
-        const response = await fetchWithTimeout(
-            `${window.ROOT_PATH}/admin/prompts`,
-            {
-                method: "POST",
-                body: formData,
-            },
-        );
+        const response = await fetch(`${window.ROOT_PATH}/admin/prompts`, {
+            method: "POST",
+            body: formData,
+        });
         const result = await response.json();
         if (!result || !result.success) {
             throw new Error(result?.message || "Failed to add prompt");
@@ -7131,14 +7122,10 @@ async function handleServerFormSubmit(e) {
         const isInactiveCheckedBool = isInactiveChecked("servers");
         formData.append("is_inactive_checked", isInactiveCheckedBool);
 
-        const response = await fetchWithTimeout(
-            `${window.ROOT_PATH}/admin/servers`,
-            {
-                method: "POST",
-                body: formData,
-                redirect: "manual",
-            },
-        );
+        const response = await fetch(`${window.ROOT_PATH}/admin/servers`, {
+            method: "POST",
+            body: formData,
+        });
         const result = await response.json();
         if (!result || !result.success) {
             throw new Error(result?.message || "Failed to add server.");
@@ -7214,13 +7201,10 @@ async function handleToolFormSubmit(event) {
         const isInactiveCheckedBool = isInactiveChecked("tools");
         formData.append("is_inactive_checked", isInactiveCheckedBool);
 
-        const response = await fetchWithTimeout(
-            `${window.ROOT_PATH}/admin/tools`,
-            {
-                method: "POST",
-                body: formData,
-            },
-        );
+        const response = await fetch(`${window.ROOT_PATH}/admin/tools`, {
+            method: "POST",
+            body: formData,
+        });
         const result = await response.json();
         if (!result || !result.success) {
             throw new Error(result?.message || "Failed to add tool");

mcpgateway/templates/admin.html

@@ -2383,7 +2383,7 @@ <h3 class="text-lg font-bold dark:text-gray-200">Add New Tool from REST API</h3>
             </div>
           </div>
 
-          <form id="add-tool-form">
+          <form method="POST" id="add-tool-form">
             <div class="grid grid-cols-1 gap-6">
               <div>
                 <label
@@ -3018,7 +3018,7 @@ <h2 class="text-2xl font-bold dark:text-gray-200">MCP Resources</h2>
           <h3 class="text-lg font-bold mb-4 dark:text-gray-200">
             Add New Resource
           </h3>
-          <form id="add-resource-form">
+          <form method="POST" id="add-resource-form">
             <div class="grid grid-cols-1 gap-6">
               <div>
                 <label
@@ -3820,7 +3820,7 @@ <h2 class="text-2xl font-bold dark:text-gray-200">
           <h3 class="text-lg font-bold mb-4 dark:text-gray-200">
             Add New MCP Server or Gateway
           </h3>
-          <form id="add-gateway-form">
+          <form method="POST" id="add-gateway-form">
             <div class="grid grid-cols-1 gap-6">
               <div>
                 <label