Skip to content

Commit d96d2f0

Browse files
committed
flake8 test update
Signed-off-by: Satya <[email protected]>
1 parent e8d6175 commit d96d2f0

File tree

1 file changed

+10
-40
lines changed

1 file changed

+10
-40
lines changed

mcpgateway/admin.py

Lines changed: 10 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -423,10 +423,7 @@ async def admin_add_server(request: Request, db: Session = Depends(get_db), user
423423
)
424424
except KeyError as e:
425425
# Convert KeyError to ValidationError-like response
426-
return JSONResponse(
427-
content={"message": f"Missing required field: {e}", "success": False},
428-
status_code=422
429-
)
426+
return JSONResponse(content={"message": f"Missing required field: {e}", "success": False}, status_code=422)
430427

431428
try:
432429
await server_service.register_server(db, server)
@@ -436,64 +433,37 @@ async def admin_add_server(request: Request, db: Session = Depends(get_db), user
436433
)
437434

438435
except CoreValidationError as ex:
439-
return JSONResponse(
440-
content={"message": str(ex), "success": False},
441-
status_code=422
442-
)
436+
return JSONResponse(content={"message": str(ex), "success": False}, status_code=422)
443437

444438
except ValidationError as ex:
445-
return JSONResponse(
446-
content={"message": str(ex), "success": False},
447-
status_code=422
448-
)
439+
return JSONResponse(content={"message": str(ex), "success": False}, status_code=422)
449440

450441
except IntegrityError as ex:
451442
logger.error(f"Database error: {ex}")
452-
return JSONResponse(
453-
content={"message": f"Server already exists with name: {server.name}","success": False},
454-
status_code=409
455-
)
443+
return JSONResponse(content={"message": f"Server already exists with name: {server.name}", "success": False}, status_code=409)
456444
except Exception as ex:
457445
if isinstance(ex, ServerError):
458446
# Custom server logic error — 500 Internal Server Error makes sense
459-
return JSONResponse(
460-
content={"message": str(ex), "success": False},
461-
status_code=500
462-
)
447+
return JSONResponse(content={"message": str(ex), "success": False}, status_code=500)
463448

464449
if isinstance(ex, ValueError):
465450
# Invalid input — 400 Bad Request is appropriate
466-
return JSONResponse(
467-
content={"message": str(ex), "success": False},
468-
status_code=400
469-
)
451+
return JSONResponse(content={"message": str(ex), "success": False}, status_code=400)
470452

471453
if isinstance(ex, RuntimeError):
472454
# Unexpected error during runtime — 500 is suitable
473-
return JSONResponse(
474-
content={"message": str(ex), "success": False},
475-
status_code=500
476-
)
455+
return JSONResponse(content={"message": str(ex), "success": False}, status_code=500)
477456

478457
if isinstance(ex, ValidationError):
479458
# Pydantic or input validation failure — 422 Unprocessable Entity is correct
480-
return JSONResponse(
481-
content={"message": ErrorFormatter.format_validation_error(ex), "success": False},
482-
status_code=422
483-
)
459+
return JSONResponse(content={"message": ErrorFormatter.format_validation_error(ex), "success": False}, status_code=422)
484460

485461
if isinstance(ex, IntegrityError):
486462
# DB constraint violation — 409 Conflict is appropriate
487-
return JSONResponse(
488-
content={"message": ErrorFormatter.format_database_error(ex), "success": False},
489-
status_code=409
490-
)
463+
return JSONResponse(content={"message": ErrorFormatter.format_database_error(ex), "success": False}, status_code=409)
491464

492465
# For any other unhandled error, default to 500
493-
return JSONResponse(
494-
content={"message": str(ex), "success": False},
495-
status_code=500
496-
)
466+
return JSONResponse(content={"message": str(ex), "success": False}, status_code=500)
497467

498468

499469
@admin_router.post("/servers/{server_id}/edit")

0 commit comments

Comments
 (0)