Skip to content

Commit dde95fe

Browse files
authored
Use warning for non standard mcp protocols (#331)
Signed-off-by: Madhav Kandukuri <[email protected]>
1 parent 33ba349 commit dde95fe

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

mcpgateway/cache/session_registry.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -657,11 +657,7 @@ async def handle_initialize_logic(self, body: dict) -> InitializeResult:
657657
)
658658

659659
if protocol_version != settings.protocol_version:
660-
raise HTTPException(
661-
status_code=status.HTTP_400_BAD_REQUEST,
662-
detail=f"Unsupported protocol version: {protocol_version}",
663-
headers={"MCP-Error-Code": "-32003"},
664-
)
660+
logger.warning(f"Using non default protocol version: {protocol_version}")
665661

666662
return InitializeResult(
667663
protocolVersion=settings.protocol_version,

tests/unit/mcpgateway/cache/test_session_registry.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
# Standard
2929
import asyncio
3030
import json
31+
import logging
3132
import re
3233
from typing import Any, Dict, List
3334
from unittest.mock import AsyncMock, Mock, patch
@@ -480,11 +481,13 @@ async def test_handle_initialize_missing_version_error(registry: SessionRegistry
480481

481482

482483
@pytest.mark.asyncio
483-
async def test_handle_initialize_unsupported_version_error(registry: SessionRegistry):
484+
async def test_handle_initialize_unsupported_version_warning(registry: SessionRegistry, caplog):
485+
caplog.set_level(logging.WARNING, logger="mcpgateway.cache.session_registry")
484486
body = {"protocol_version": "999"}
485-
with pytest.raises(HTTPException) as exc:
486-
await registry.handle_initialize_logic(body)
487-
assert exc.value.headers["MCP-Error-Code"] == "-32003"
487+
488+
await registry.handle_initialize_logic(body)
489+
490+
assert "Using non default protocol version: 999" in caplog.text
488491

489492

490493
# --------------------------------------------------------------------------- #

0 commit comments

Comments
 (0)