avoid recursion in case of non dict yaml element (#582)

Signed-off-by: haim-kermany <[email protected]>

Author: haim-kermany

nca/NetworkConfig/TopologyObjectsFinder.py

@@ -47,14 +47,12 @@ def add_eps_from_yaml(self, yaml_obj, kind_override=None):
         :param kind_override: if set, ignoring the object kind and using this param instead
         :return: None
         """
+        if isinstance(yaml_obj, list):
+            for ep_sub_list in yaml_obj:  # e.g. when we have a list of lists - call recursively for each list
+                self.add_eps_from_yaml(ep_sub_list)
+            return
         if not isinstance(yaml_obj, dict):
-            try:
-                for ep_sub_list in yaml_obj:  # e.g. when we have a list of lists - call recursively for each list
-                    self.add_eps_from_yaml(ep_sub_list)
-            except TypeError:
-                pass
             return
-
         kind = yaml_obj.get('kind') if not kind_override else kind_override
         if kind in ['List', 'PodList', 'WorkloadEndpointList', 'HostEndpointList', 'NetworkSetList',
                     'GlobalNetworkSetList']:

tests/bad_yamls/list_of_strings.json

@@ -0,0 +1,5 @@
+[
+  "esnext.global-this",
+  "esnext.promise.all-settled",
+  "esnext.string.match-all"
+]