feat: Support for directlink tgw connection type (#50)

Author: kennburger

.travis.yml

@@ -10,8 +10,6 @@ before_install:
 
 jobs:
   include:
-    - stage: Node JS 10
-      node_js: 10
     - stage: Node JS 12
       node_js: 12
 

test/unit/transit-gateway-apis.v1.test.js

@@ -540,9 +540,7 @@ describe('TransitGatewayApisV1', () => {
           transitGatewayId: transitGatewayId,
         };
 
-        const listTransitGatewayConnectionsResult = transitGatewayApisService.listTransitGatewayConnections(
-          params
-        );
+        const listTransitGatewayConnectionsResult = transitGatewayApisService.listTransitGatewayConnections(params);
 
         // all methods should return a Promise
         expectToBePromise(listTransitGatewayConnectionsResult);
@@ -620,8 +618,7 @@ describe('TransitGatewayApisV1', () => {
         const localTunnelIp = '192.168.129.2';
         const name = 'Transit_Service_BWTN_SJ_DL';
         const networkAccountId = '28e4d90ac7504be694471ee66e70d0d5';
-        const networkId =
-          'crn:v1:bluemix:public:is:us-south:a/123456::vpc:4727d842-f94f-4a2d-824a-9bc9b02c523b';
+        const networkId = 'crn:v1:bluemix:public:is:us-south:a/123456::vpc:4727d842-f94f-4a2d-824a-9bc9b02c523b';
         const remoteBgpAsn = '65010';
         const remoteGatewayIp = '10.242.63.12';
         const remoteTunnelIp = '192.168.129.1';
@@ -641,9 +638,7 @@ describe('TransitGatewayApisV1', () => {
           zone: zone,
         };
 
-        const createTransitGatewayConnectionResult = transitGatewayApisService.createTransitGatewayConnection(
-          params
-        );
+        const createTransitGatewayConnectionResult = transitGatewayApisService.createTransitGatewayConnection(params);
 
         // all methods should return a Promise
         expectToBePromise(createTransitGatewayConnectionResult);
@@ -727,9 +722,7 @@ describe('TransitGatewayApisV1', () => {
           id: id,
         };
 
-        const deleteTransitGatewayConnectionResult = transitGatewayApisService.deleteTransitGatewayConnection(
-          params
-        );
+        const deleteTransitGatewayConnectionResult = transitGatewayApisService.deleteTransitGatewayConnection(params);
 
         // all methods should return a Promise
         expectToBePromise(deleteTransitGatewayConnectionResult);
@@ -739,11 +732,7 @@ describe('TransitGatewayApisV1', () => {
 
         const options = getOptions(createRequestMock);
 
-        checkUrlAndMethod(
-          options,
-          '/transit_gateways/{transit_gateway_id}/connections/{id}',
-          'DELETE'
-        );
+        checkUrlAndMethod(options, '/transit_gateways/{transit_gateway_id}/connections/{id}', 'DELETE');
         const expectedAccept = undefined;
         const expectedContentType = undefined;
         checkMediaHeaders(createRequestMock, expectedAccept, expectedContentType);
@@ -807,9 +796,7 @@ describe('TransitGatewayApisV1', () => {
           id: id,
         };
 
-        const getTransitGatewayConnectionResult = transitGatewayApisService.getTransitGatewayConnection(
-          params
-        );
+        const getTransitGatewayConnectionResult = transitGatewayApisService.getTransitGatewayConnection(params);
 
         // all methods should return a Promise
         expectToBePromise(getTransitGatewayConnectionResult);
@@ -819,11 +806,7 @@ describe('TransitGatewayApisV1', () => {
 
         const options = getOptions(createRequestMock);
 
-        checkUrlAndMethod(
-          options,
-          '/transit_gateways/{transit_gateway_id}/connections/{id}',
-          'GET'
-        );
+        checkUrlAndMethod(options, '/transit_gateways/{transit_gateway_id}/connections/{id}', 'GET');
         const expectedAccept = 'application/json';
         const expectedContentType = undefined;
         checkMediaHeaders(createRequestMock, expectedAccept, expectedContentType);
@@ -889,9 +872,7 @@ describe('TransitGatewayApisV1', () => {
           name: name,
         };
 
-        const updateTransitGatewayConnectionResult = transitGatewayApisService.updateTransitGatewayConnection(
-          params
-        );
+        const updateTransitGatewayConnectionResult = transitGatewayApisService.updateTransitGatewayConnection(params);
 
         // all methods should return a Promise
         expectToBePromise(updateTransitGatewayConnectionResult);
@@ -901,11 +882,7 @@ describe('TransitGatewayApisV1', () => {
 
         const options = getOptions(createRequestMock);
 
-        checkUrlAndMethod(
-          options,
-          '/transit_gateways/{transit_gateway_id}/connections/{id}',
-          'PATCH'
-        );
+        checkUrlAndMethod(options, '/transit_gateways/{transit_gateway_id}/connections/{id}', 'PATCH');
         const expectedAccept = 'application/json';
         const expectedContentType = 'application/json';
         checkMediaHeaders(createRequestMock, expectedAccept, expectedContentType);
@@ -972,9 +949,7 @@ describe('TransitGatewayApisV1', () => {
           action: action,
         };
 
-        const createTransitGatewayConnectionActionsResult = transitGatewayApisService.createTransitGatewayConnectionActions(
-          params
-        );
+        const createTransitGatewayConnectionActionsResult = transitGatewayApisService.createTransitGatewayConnectionActions(params);
 
         // all methods should return a Promise
         expectToBePromise(createTransitGatewayConnectionActionsResult);
@@ -984,11 +959,7 @@ describe('TransitGatewayApisV1', () => {
 
         const options = getOptions(createRequestMock);
 
-        checkUrlAndMethod(
-          options,
-          '/transit_gateways/{transit_gateway_id}/connections/{id}/actions',
-          'POST'
-        );
+        checkUrlAndMethod(options, '/transit_gateways/{transit_gateway_id}/connections/{id}/actions', 'POST');
         const expectedAccept = undefined;
         const expectedContentType = 'application/json';
         checkMediaHeaders(createRequestMock, expectedAccept, expectedContentType);

transit-gateway-apis/v1.ts

@@ -475,8 +475,9 @@ class TransitGatewayApisV1 extends BaseService {
    * Generally only used if the network is in a different account than the gateway. This field is required to be
    * unspecified for network type 'gre_tunnel'.
    * @param {string} [params.networkId] - The ID of the network being connected via this connection. This field is
-   * required for some types, such as 'vpc'. For network type 'vpc' this is the CRN of the VPC to be connected. This
-   * field is required to be unspecified for network type 'classic' and 'gre_tunnel' connections.
+   * required for some types, such as 'vpc' and 'directlink'. For network types 'vpc' and 'directlink' this is the CRN
+   * of the VPC / Direct Link gateway respectively. This field is required to be unspecified for network type 'classic'
+   * and 'gre_tunnel' connections.
    * @param {string} [params.remoteBgpAsn] - Remote network BGP ASN.  This field is only applicable to 'gre_tunnel' type
    * connections. The following ASN values are reserved and unavailable 64512-64513, 65100, 65201-65234, 65402-65433,
    * 65500 and 4201065000-4201065999. If 'remote_bgp_asn' is omitted on gre_tunnel connection create requests IBM will
@@ -988,8 +989,9 @@ namespace TransitGatewayApisV1 {
      */
     networkAccountId?: string;
     /** The ID of the network being connected via this connection. This field is required for some types, such as
-     *  'vpc'. For network type 'vpc' this is the CRN of the VPC to be connected. This field is required to be
-     *  unspecified for network type 'classic' and 'gre_tunnel' connections.
+     *  'vpc' and 'directlink'. For network types 'vpc' and 'directlink' this is the CRN of the VPC / Direct Link
+     *  gateway respectively. This field is required to be unspecified for network type 'classic' and 'gre_tunnel'
+     *  connections.
      */
     networkId?: string;
     /** Remote network BGP ASN.  This field is only applicable to 'gre_tunnel' type connections. The following ASN
@@ -1018,9 +1020,10 @@ namespace TransitGatewayApisV1 {
   export namespace CreateTransitGatewayConnectionConstants {
     /** Defines what type of network is connected via this connection. For access to gre_tunnel connections contact IBM support. */
     export enum NetworkType {
-      VPC = 'vpc',
       CLASSIC = 'classic',
+      DIRECTLINK = 'directlink',
       GRE_TUNNEL = 'gre_tunnel',
+      VPC = 'vpc',
     }
   }
 
@@ -1178,7 +1181,8 @@ namespace TransitGatewayApisV1 {
      */
     network_account_id?: string;
     /** The ID of the network being connected via this connection. This field is required for some types, such as
-     *  'vpc'. For network type 'vpc' this is the CRN of the VPC to be connected.
+     *  'vpc' and 'directlink'. For network types 'vpc' and 'directlink' it should be the CRN of the target vpc /
+     *  gateway respectively.
      */
     network_id?: string;
     /** Defines what type of network is connected via this connection. The list of enumerated values for this
@@ -1297,7 +1301,8 @@ namespace TransitGatewayApisV1 {
     /** The user-defined name for this transit gateway connection. */
     name: string;
     /** The ID of the network being connected via this connection. This field is required for some types, such as
-     *  'vpc'. For network type 'vpc' this is the CRN of the VPC to be connected.
+     *  'vpc' and 'directlink'. For network types 'vpc' and 'directlink' it should be the CRN of the target vpc /
+     *  gateway respectively.
      */
     network_id?: string;
     /** Defines what type of network is connected via this connection. The list of enumerated values for this