fix: fixing vulnerability: server-side request forgery in axios (#135)

jkalandaibm · web-flow · commit b31748f421e2 · 2024-08-27T09:42:21.000-05:00
* fix: minor tweak
Signed-off-by: jkalanda &lt;jkalanda@us.ibm.com&gt;
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -32,21 +32,22 @@
   },
   "license": "Apache-2.0",
   "engines": {
-    "node": ">=14.0.0"
+    "node": ">=18.0.0"
   },
   "dependencies": {
     "@types/extend": "^3.0.4",
     "@types/node": "^20.11.28",
     "extend": "^3.0.2",
-    "ibm-cloud-sdk-core": "^4.2.4"
+    "ibm-cloud-sdk-core": "^5.0.1"
   },
   "devDependencies": {
+    "@ibm-cloud/sdk-test-utilities": "^1.0.0",
     "@semantic-release/changelog": "^6.0.3",
     "@semantic-release/git": "^10.0.1",
     "@typescript-eslint/eslint-plugin": "^7.2.0",
     "@typescript-eslint/parser": "^7.2.0",
     "ansi-regex": "^6.0.1",
-    "axios": "^1.6.7",
+    "axios": "^1.7.4",
     "dotenv": "^16.4.5",
     "eslint": "^8.57.0",
     "eslint-config-google": "^0.14.0",
diff --git a/test/unit/cis/alerts.v1.test.js b/test/unit/cis/alerts.v1.test.js
@@ -16,7 +16,6 @@
 
 // need to import the whole package to mock getAuthenticatorFromEnvironment
 const core = require('ibm-cloud-sdk-core');
-
 const { NoAuthAuthenticator, unitTestUtils } = core;
 
 const AlertsV1 = require('../../../dist/cis/alertsv1/v1');
@@ -27,7 +26,8 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
+
 
 const alertsServiceOptions = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/authenticated-origin-pull-api.v1.test.js b/test/unit/cis/authenticated-origin-pull-api.v1.test.js
@@ -16,7 +16,6 @@
 
 // need to import the whole package to mock getAuthenticatorFromEnvironment
 const core = require('ibm-cloud-sdk-core');
-
 const { NoAuthAuthenticator, unitTestUtils } = core;
 
 const AuthenticatedOriginPullApiV1 = require('../../../dist/cis/authenticated-origin-pull-apiv1/v1');
@@ -28,7 +27,7 @@ const {
   expectToBePromise,
   checkUserHeader,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const authenticatedOriginPullApiServiceOptions = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/caching-api.v1.test.js b/test/unit/cis/caching-api.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/cis-ip-api.v1.test.js b/test/unit/cis/cis-ip-api.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/custom-pages.v1.test.js b/test/unit/cis/custom-pages.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/dns-record-bulk.v1.test.js b/test/unit/cis/dns-record-bulk.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/dns-records.v1.test.js b/test/unit/cis/dns-records.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/edge-functions-api.v1.test.js b/test/unit/cis/edge-functions-api.v1.test.js
@@ -28,7 +28,7 @@ const {
   expectToBePromise,
   checkUserHeader,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/filters.v1.test.js b/test/unit/cis/filters.v1.test.js
@@ -16,7 +16,6 @@
 
 // need to import the whole package to mock getAuthenticatorFromEnvironment
 const core = require('ibm-cloud-sdk-core');
-
 const { NoAuthAuthenticator, unitTestUtils } = core;
 
 const FiltersV1 = require('../../../dist/cis/filtersv1/v1');
@@ -27,7 +26,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkUserHeader,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const filtersServiceOptions = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/firewall-access-rules.v1.test.js b/test/unit/cis/firewall-access-rules.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/firewall-api.v1.test.js b/test/unit/cis/firewall-api.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/firewall-event-analytics-api.v1.test.js b/test/unit/cis/firewall-event-analytics-api.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/firewall-rules.v1.test.js b/test/unit/cis/firewall-rules.v1.test.js
@@ -16,7 +16,6 @@
 
 // need to import the whole package to mock getAuthenticatorFromEnvironment
 const core = require('ibm-cloud-sdk-core');
-
 const { NoAuthAuthenticator, unitTestUtils } = core;
 
 const FirewallRulesV1 = require('../../../dist/cis/firewallrulesv1/v1');
@@ -27,7 +26,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkUserHeader,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const firewallRulesServiceOptions = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/global-load-balancer-events.v1.test.js b/test/unit/cis/global-load-balancer-events.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/global-load-balancer-monitor.v1.test.js b/test/unit/cis/global-load-balancer-monitor.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/global-load-balancer-pools.v0.test.js b/test/unit/cis/global-load-balancer-pools.v0.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/global-load-balancer.v1.test.js b/test/unit/cis/global-load-balancer.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/logpush-jobs-api.v1.test.js b/test/unit/cis/logpush-jobs-api.v1.test.js
@@ -16,7 +16,6 @@
 
 // need to import the whole package to mock getAuthenticatorFromEnvironment
 const core = require('ibm-cloud-sdk-core');
-
 const { NoAuthAuthenticator, unitTestUtils } = core;
 
 const LogpushJobsApiV1 = require('../../../dist/cis/logpushjobsapiv1/v1');
@@ -27,7 +26,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const logpushJobsApiServiceOptions = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/mtls.v1.test.js b/test/unit/cis/mtls.v1.test.js
@@ -16,7 +16,6 @@
 
 // need to import the whole package to mock getAuthenticatorFromEnvironment
 const core = require('ibm-cloud-sdk-core');
-
 const { NoAuthAuthenticator, unitTestUtils } = core;
 
 const MtlsV1 = require('../../../dist/cis/mtlsv1/v1');
@@ -27,7 +26,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const mtlsServiceOptions = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/page-rule-api.v1.test.js b/test/unit/cis/page-rule-api.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/range-applications.v1.test.js b/test/unit/cis/range-applications.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/routing.v1.test.js b/test/unit/cis/routing.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/security-events-api.v1.test.js b/test/unit/cis/security-events-api.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/ssl-certificate-api.v1.test.js b/test/unit/cis/ssl-certificate-api.v1.test.js
@@ -16,8 +16,8 @@
 
 // need to import the whole package to mock getAuthenticatorFromEnvironment
 const sdkCorePackage = require('ibm-cloud-sdk-core');
-
 const { NoAuthAuthenticator, unitTestUtils } = sdkCorePackage;
+
 const SslCertificateApiV1 = require('../../../dist/cis/ssl-certificate-api/v1');
 
 const {
@@ -27,7 +27,7 @@ const {
   expectToBePromise,
   checkUserHeader,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const sslCertificateApiServiceOptions = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/user-agent-blocking-rules.v1.test.js b/test/unit/cis/user-agent-blocking-rules.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/waf-api.v1.test.js b/test/unit/cis/waf-api.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/waf-rule-groups-api.v1.test.js b/test/unit/cis/waf-rule-groups-api.v1.test.js
@@ -21,7 +21,7 @@ const { NoAuthAuthenticator, unitTestUtils } = core;
 
 const WafRuleGroupsApiV1 = require('../../../dist/cis/wafrulegroupsapiv1/v1');
 
-const { getOptions, checkUrlAndMethod, checkMediaHeaders, expectToBePromise } = unitTestUtils;
+const { getOptions, checkUrlAndMethod, checkMediaHeaders, expectToBePromise } = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/waf-rule-packages-api.v1.test.js b/test/unit/cis/waf-rule-packages-api.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/waf-rules-api.v1.test.js b/test/unit/cis/waf-rules-api.v1.test.js
@@ -21,7 +21,7 @@ const { NoAuthAuthenticator, unitTestUtils } = core;
 
 const WafRulesApiV1 = require('../../../dist/cis/wafrulesapiv1/v1');
 
-const { getOptions, checkUrlAndMethod, checkMediaHeaders, expectToBePromise } = unitTestUtils;
+const { getOptions, checkUrlAndMethod, checkMediaHeaders, expectToBePromise } = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/webhooks.v1.test.js b/test/unit/cis/webhooks.v1.test.js
@@ -16,7 +16,6 @@
 
 // need to import the whole package to mock getAuthenticatorFromEnvironment
 const core = require('ibm-cloud-sdk-core');
-
 const { NoAuthAuthenticator, unitTestUtils } = core;
 
 const WebhooksV1 = require('../../../dist/cis/webhooksv1/v1');
@@ -27,7 +26,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const webhooksServiceOptions = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/zone-firewall-access-rules.v1.test.js b/test/unit/cis/zone-firewall-access-rules.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/zone-lockdown.v1.test.js b/test/unit/cis/zone-lockdown.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/zone-rate-limits.v1.test.js b/test/unit/cis/zone-rate-limits.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/zones-settings.v1.test.js b/test/unit/cis/zones-settings.v1.test.js
@@ -27,7 +27,7 @@ const {
   checkMediaHeaders,
   expectToBePromise,
   checkForSuccessfulExecution,
-} = unitTestUtils;
+} = require('@ibm-cloud/sdk-test-utilities');
 
 const service = {
   authenticator: new NoAuthAuthenticator(),
diff --git a/test/unit/cis/zones.v1.test.js b/test/unit/cis/zones.v1.test.js
diff --git a/test/unit/direct-link-provider.v2.test.js b/test/unit/direct-link-provider.v2.test.js
diff --git a/test/unit/direct-link.v1.test.js b/test/unit/direct-link.v1.test.js
diff --git a/test/unit/dns-svcs.v1.test.js b/test/unit/dns-svcs.v1.test.js
diff --git a/test/unit/transit-gateway-apis.v1.test.js b/test/unit/transit-gateway-apis.v1.test.js
