Skip to content

Commit fe7231d

Browse files
Merge pull request #57 from IBM/detect-secrets
chore: update the secrets.baseline to allow false positives for direct link sdk
2 parents b517cca + d44c0c1 commit fe7231d

File tree

2 files changed

+17
-10
lines changed

2 files changed

+17
-10
lines changed

.secrets.baseline

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"files": "package-lock.json|^.secrets.baseline$",
44
"lines": null
55
},
6-
"generated_at": "2021-03-09T20:28:36Z",
6+
"generated_at": "2021-10-13T18:10:23Z",
77
"plugins_used": [
88
{
99
"name": "AWSKeyDetector"
@@ -25,6 +25,7 @@
2525
"name": "CloudantDetector"
2626
},
2727
{
28+
"ghe_instance": "github.ibm.com",
2829
"name": "GheDetector"
2930
},
3031
{
@@ -136,7 +137,7 @@
136137
],
137138
"test/unit/direct-link-provider.v2.test.js": [
138139
{
139-
"hashed_secret": "8cff7739d641fa350594fe96091ff06c8b66fa30",
140+
"hashed_secret": "c690fcc1554f0eb5b865d7f09c9ceda156df2a80",
140141
"is_secret": false,
141142
"is_verified": false,
142143
"line_number": 238,
@@ -149,7 +150,7 @@
149150
"hashed_secret": "d67a00cdeec75b04602db35a89c15bb6ee53c877",
150151
"is_secret": false,
151152
"is_verified": false,
152-
"line_number": 544,
153+
"line_number": 605,
153154
"type": "Hex High Entropy String",
154155
"verified_result": null
155156
}
@@ -159,21 +160,21 @@
159160
"hashed_secret": "d67a00cdeec75b04602db35a89c15bb6ee53c877",
160161
"is_secret": false,
161162
"is_verified": false,
162-
"line_number": 179,
163+
"line_number": 240,
163164
"type": "Hex High Entropy String",
164165
"verified_result": null
165166
},
166167
{
167168
"hashed_secret": "eb74ff42e2e8dfbaf3e4f64a02cdadc8bedda8c3",
168169
"is_secret": false,
169170
"is_verified": false,
170-
"line_number": 553,
171+
"line_number": 622,
171172
"type": "Hex High Entropy String",
172173
"verified_result": null
173174
}
174175
]
175176
},
176-
"version": "0.13.1+ibm.31.dss",
177+
"version": "0.13.1+ibm.46.dss",
177178
"word_list": {
178179
"file": null,
179180
"hash": null

test/integration/direct-link.v1.test.js

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,12 @@ const wait = (ms = 5000) => {
8484
});
8585
};
8686

87+
const get_port = ports => {
88+
const providerToBeUsed = 'DL2-TEST';
89+
const port = ports.find(port => port.provider_name === providerToBeUsed);
90+
return port;
91+
};
92+
8793
const options = {
8894
authenticator: new IamAuthenticator({
8995
apikey: config.IAMAPIKEY,
@@ -368,7 +374,7 @@ describe('DirectLinkV1', () => {
368374
dlService.listPorts({}).then(response => {
369375
expect(response.status).toBe(200);
370376
if (null != response && null != response.result && null != response.result.ports) {
371-
port = response.result.ports[0];
377+
port = get_port(response.result.ports);
372378
}
373379
done();
374380
});
@@ -1275,7 +1281,7 @@ describe('DirectLinkV1', () => {
12751281
dlService.listPorts({}).then(response => {
12761282
expect(response.status).toBe(200);
12771283
if (null != response && null != response.result && null != response.result.ports) {
1278-
port = response.result.ports[0];
1284+
port = get_port(response.result.ports);
12791285
}
12801286
done();
12811287
});
@@ -1519,7 +1525,7 @@ describe('DirectLinkV1', () => {
15191525
dlService.listPorts({}).then(response => {
15201526
expect(response.status).toBe(200);
15211527
if (null != response && null != response.result && null != response.result.ports) {
1522-
port = response.result.ports[0];
1528+
port = get_port(response.result.ports);
15231529
}
15241530
done();
15251531
});
@@ -1814,7 +1820,7 @@ describe('DirectLinkV1', () => {
18141820
dlService.listPorts({}).then(response => {
18151821
expect(response.status).toBe(200);
18161822
if (null != response && null != response.result && null != response.result.ports) {
1817-
port = response.result.ports[0];
1823+
port = get_port(response.result.ports);
18181824
}
18191825
done();
18201826
});

0 commit comments

Comments
 (0)