Skip to content

Commit f37f4c2

Browse files
committed
Update to download/upload-artifact to v5
This brings breaking changes at v4, though I don't think they actually affected us. Update the configuration based off the examples in the docs https://github.com/actions/download-artifact?tab=readme-ov-file#download-multiple-filtered-artifacts-to-the-same-directory
1 parent 17b69c0 commit f37f4c2

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

.github/workflows/create-release.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ jobs:
4242
- name: Package Binary
4343
run: ./node_modules/.bin/node-pre-gyp package
4444
- name: Upload Artifact
45-
uses: actions/upload-artifact@v3
45+
uses: actions/upload-artifact@v5
4646
with:
47-
name: ${{ matrix.os }}-binaries
47+
name: binaries-${{ matrix.os }}
4848
path: build/stage/*.tar.gz
4949

5050
create-release:
@@ -57,7 +57,11 @@ jobs:
5757
run: jq -r '"version=" + .version' package.json >> "$GITHUB_OUTPUT"
5858
# Download all of the various binaries that were created
5959
- name: Download built binaries from workflow
60-
uses: actions/download-artifact@v3
60+
uses: actions/download-artifact@v5
61+
with:
62+
path: binaries
63+
pattern: binaries-*
64+
merge-multiple: true
6165
- name: Create Release
6266
id: create_release
6367
uses: softprops/action-gh-release@v2
@@ -68,7 +72,7 @@ jobs:
6872
generate_release_notes: true
6973
fail_on_unmatched_files: true
7074
files:
71-
./*-binaries/odbc-*.tar.gz
75+
./binaries/odbc-*.tar.gz
7276
- name: Publish to NPM
7377
uses: JS-DevTools/npm-publish@v3
7478
with:

0 commit comments

Comments
 (0)