Add test for requestOptions and links

Signed-off-by: Alan Cha <[email protected]>

Author: Alan-Cha

packages/openapi-to-graphql/lib/oas_3_tools.js

@@ -1101,10 +1101,14 @@ export function storeSaneName(
  * sanitized
  */
 export function sanitizeObjectKeys(obj: object): object {
-  return Object.keys(obj).reduce((acc, key) => {
-    acc[sanitize(key, CaseStyle.camelCase)] = obj[key]
-    return acc
-  }, {})
+  if (typeof obj === 'object') {
+    return Object.keys(obj).reduce((acc, key) => {
+      acc[sanitize(key, CaseStyle.camelCase)] = obj[key]
+      return acc
+    }, {})
+  } else {
+    return undefined
+  }
 }
 
 /**

packages/openapi-to-graphql/lib/oas_3_tools.js.map

@@ -16,7 +16,7 @@ import { GraphQLOperationType } from '../lib/types/graphql'
 
 const oas = require('./fixtures/example_oas.json')
 const PORT = 3002
-// update PORT for this test case:
+// Update PORT for this test case:
 oas.servers[0].variables.port.default = String(PORT)
 
 let createdSchema

packages/openapi-to-graphql/lib/schema_builder.js

@@ -7,18 +7,26 @@
 
 /* globals beforeAll, test, expect */
 
-import { graphql, parse, validate } from 'graphql'
+import { graphql } from 'graphql'
 
 import * as openAPIToGraphQL from '../lib/index'
 import { startServer, stopServer } from './example_api2_server'
 
 const oas = require('./fixtures/example_oas2.json')
 const PORT = 3004
-// update PORT for this test case:
+// Update PORT for this test case:
 oas.servers[0].variables.port.default = String(PORT)
 
 let createdSchema
 
+/**
+ * This test suite is used to verify the behavior of the operationIdFieldNames
+ * option.
+ *
+ * It is necessary to make a separate OAS because we need all of operations to
+ * have operationIDs.
+ */
+
 /**
  * Set up the schema first and run example API server
  */
@@ -41,7 +49,8 @@ afterAll(() => {
 })
 
 /**
- * There should be two operations
+ * There should be two operations.
+ *
  * One will be given a field name from the operationId, i.e. user, and the other
  * one, because it does not have an operationId defined, will have an
  * autogenerated field name based on the path, i.e. getUser

packages/openapi-to-graphql/lib/schema_builder.js.map

@@ -18,10 +18,15 @@ const oas = require('./fixtures/example_oas.json')
 const oas3 = require('./fixtures/example_oas3.json')
 const PORT = 3005
 const PORT2 = 3006
-// update PORT for this test case:
+// Update PORT for this test case:
 oas.servers[0].variables.port.default = String(PORT)
 oas3.servers[0].variables.port.default = String(PORT2)
 
+/**
+ * This test suite is used to verify the behavior of interOAS links, i.e.
+ * links across different OASs
+ */
+
 let createdSchema
 
 /**
@@ -30,9 +35,7 @@ let createdSchema
 beforeAll(() => {
   return Promise.all([
     openAPIToGraphQL
-      .createGraphQLSchema([oas, oas3], {
-        fillEmptyResponses: true
-      })
+      .createGraphQLSchema([oas, oas3])
       .then(({ schema, report }) => {
         createdSchema = schema
       }),

packages/openapi-to-graphql/src/oas_3_tools.ts

@@ -8,39 +8,23 @@
 /* globals beforeAll, test, expect */
 
 import { graphql } from 'graphql'
-
 import * as openAPIToGraphQL from '../lib/index'
-import { Options } from '../lib/types/options'
-import { startServer, stopServer } from './example_api_server'
 
 const oas = require('./fixtures/example_oas4.json')
-const PORT = 3007
-// Update PORT for this test case:
-oas.servers[0].variables.port.default = String(PORT)
+
+// This test suite is used to verify the behavior of anyOf and oneOf handling
 
 let createdSchema
 
 /**
- * Set up the schema first and run example API server
+ * Set up the schema
  */
 beforeAll(() => {
-  return Promise.all([
-    openAPIToGraphQL
-      .createGraphQLSchema(oas, {
-        fillEmptyResponses: true
-      })
-      .then(({ schema, report }) => {
-        createdSchema = schema
-      }),
-    startServer(PORT)
-  ])
-})
-
-/**
- * Shut down API server
- */
-afterAll(() => {
-  return stopServer()
+  return openAPIToGraphQL
+    .createGraphQLSchema(oas)
+    .then(({ schema, report }) => {
+      createdSchema = schema
+    })
 })
 
 const anyOfQuery = `{

packages/openapi-to-graphql/test/example_api.test.ts

@@ -0,0 +1,105 @@
+// Copyright IBM Corp. 2017,2018. All Rights Reserved.
+// Node module: openapi-to-graphql
+// This file is licensed under the MIT License.
+// License text available at https://opensource.org/licenses/MIT
+
+'use strict'
+
+/* globals beforeAll, test, expect */
+
+import { graphql, parse, validate } from 'graphql'
+
+import * as openAPIToGraphQL from '../lib/index'
+import { Options } from '../lib/types/options'
+import { startServer, stopServer } from './example_api6_server'
+
+const oas = require('./fixtures/example_oas6.json')
+const PORT = 3009
+// Update PORT for this test case:
+oas.servers[0].variables.port.default = String(PORT)
+
+let createdSchema
+
+/**
+ * Set up the schema first and run example API server
+ */
+beforeAll(() => {
+  return Promise.all([
+    openAPIToGraphQL.createGraphQLSchema(oas).then(({ schema, report }) => {
+      createdSchema = schema
+    }),
+    startServer(PORT)
+  ])
+})
+
+/**
+ * Shut down API server
+ */
+afterAll(() => {
+  return stopServer()
+})
+
+test('Option requestOptions should work with links', () => {
+  // Verifying the behavior of the link by itself
+  const query = `{
+    object {
+      object2Link {
+        data
+      }
+      withParameter: object2Link (specialheader: "extra data"){
+        data
+      }
+    }
+  }`
+
+  const promise = graphql(createdSchema, query).then(result => {
+    expect(result.data).toEqual({
+      object: {
+        object2Link: {
+          data: 'object2'
+        },
+        withParameter: {
+          data: "object2 with special header: 'extra data'"
+        }
+      }
+    })
+  })
+
+  const options: Options = {
+    requestOptions: {
+      url: undefined,
+      headers: {
+        specialheader: 'requestOptions'
+      }
+    }
+  }
+
+  const query2 = `{
+    object {
+      object2Link {
+        data
+      }
+    }
+  }`
+
+  const promise2 = openAPIToGraphQL
+    .createGraphQLSchema(oas, options)
+    .then(({ schema }) => {
+      const ast = parse(query2)
+      const errors = validate(schema, ast)
+      expect(errors).toEqual([])
+      return graphql(schema, query2).then(result => {
+        expect(result).toEqual({
+          data: {
+            object: {
+              object2Link: {
+                data: "object2 with special header: 'requestOptions'" // Data from requestOptions in a link
+              }
+            }
+          }
+        })
+      })
+    })
+
+  return Promise.all([promise, promise2])
+})