Refactor fallback channel selection to sort by semantic version and find the first available channel (#1171)

* Refactor fallback channel selection to sort by semantic version and find the first available channel

Signed-off-by: Daniel Fan <[email protected]>

* Increase golangci-lint timeout

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>

Author: Daniel-Fan

common/scripts/lint_go.sh

@@ -15,4 +15,4 @@
 # limitations under the License.
 #
 
-GOGC=25 golangci-lint run -c ./common/config/.golangci.yml --timeout=480s
+GOGC=25 golangci-lint run -c ./common/config/.golangci.yml --timeout=600s

controllers/operator/manager.go

@@ -270,10 +270,14 @@ func findCatalogFromFallbackChannels(fallbackChannels []string, fallBackChannelA
 	// sort fallback channels by semantic version
 	semverlList, semVerChannelMappings := prunedSemverChannel(fallbackChannels)
 
-	maxChannel := util.FindMaxSemver("", semverlList, semVerChannelMappings)
-	if catalogSources, ok := fallBackChannelAndCatalogMapping[maxChannel]; ok {
-		fallbackChannel = maxChannel
-		fallbackCatalog = append(fallbackCatalog, catalogSources...)
+	sort.Sort(semver.ByVersion(semverlList))
+	// find the first available channel from the sorted list in descending order
+	for i := len(semverlList) - 1; i >= 0; i-- {
+		if catalogs, ok := fallBackChannelAndCatalogMapping[semVerChannelMappings[semverlList[i]]]; ok {
+			fallbackChannel = semVerChannelMappings[semverlList[i]]
+			fallbackCatalog = catalogs
+			break
+		}
 	}
 	return fallbackChannel, fallbackCatalog
 }