Correct resource label for caching and use GenerationChangedPredicate for OperandRequest reconciliation triggering (#1180)

* Update BindInfoRefreshLabel value to 'enabled' in cache configuration

Signed-off-by: Daniel Fan <[email protected]>

* Replace ResourceVersionChangedPredicate with GenerationChangedPredicate in OperandRequest controller setup

Signed-off-by: Daniel Fan <[email protected]>

---------

Signed-off-by: Daniel Fan <[email protected]>

Author: Daniel-Fan

controllers/k8sutil/cache.go

@@ -37,7 +37,7 @@ func NewODLMCache(isolatedModeEnable bool, opts ctrl.Options) ctrl.Options {
 		labels.Set{constant.ODLMWatchedLabel: "true"},
 	)
 	cacheFreshLabelSelector := labels.SelectorFromSet(
-		labels.Set{constant.BindInfoRefreshLabel: "true"},
+		labels.Set{constant.BindInfoRefreshLabel: "enabled"},
 	)
 
 	watchNamespace := util.GetWatchNamespace()

controllers/operandrequest/operandrequest_controller.go

@@ -406,7 +406,7 @@ func (r *Reconciler) SetupWithManager(mgr ctrl.Manager) error {
 	}
 	return ctrl.NewControllerManagedBy(mgr).
 		WithOptions(options).
-		For(&operatorv1alpha1.OperandRequest{}, builder.WithPredicates(predicate.ResourceVersionChangedPredicate{})).
+		For(&operatorv1alpha1.OperandRequest{}, builder.WithPredicates(predicate.GenerationChangedPredicate{})).
 		Watches(&olmv1alpha1.Subscription{}, handler.EnqueueRequestsFromMapFunc(r.getSubToRequestMapper), builder.WithPredicates(predicate.Funcs{
 			UpdateFunc: func(e event.UpdateEvent) bool {
 				oldObject := e.ObjectOld.(*olmv1alpha1.Subscription)

controllers/operandrequestnoolm/operandrequestnoolm_controller.go

@@ -351,7 +351,7 @@ func (r *Reconciler) SetupWithManager(mgr ctrl.Manager) error {
 	}
 	return ctrl.NewControllerManagedBy(mgr).
 		WithOptions(options).
-		For(&operatorv1alpha1.OperandRequest{}, builder.WithPredicates(predicate.ResourceVersionChangedPredicate{})).
+		For(&operatorv1alpha1.OperandRequest{}, builder.WithPredicates(predicate.GenerationChangedPredicate{})).
 		Watches(&corev1.ConfigMap{}, handler.EnqueueRequestsFromMapFunc(r.getReferenceToRequestMapper), builder.WithPredicates(predicate.Funcs{
 			UpdateFunc: func(e event.UpdateEvent) bool {
 				oldObject := e.ObjectOld.(*corev1.ConfigMap)