Skip to content

Commit ee95a67

Browse files
authored
use reader.Get to get resource in cluster (#1158)
Signed-off-by: Allen Li <[email protected]>
1 parent e051c49 commit ee95a67

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

controllers/operandbindinfo/operandbindinfo_controller.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ func (r *Reconciler) copySecret(ctx context.Context, sourceName, targetName, sou
312312
if apierrors.IsAlreadyExists(err) {
313313
// If already exist, update the Secret
314314
existingSecret := &corev1.Secret{}
315-
if err := r.Client.Get(ctx, types.NamespacedName{Namespace: targetNs, Name: targetName}, existingSecret); err != nil {
315+
if err := r.Reader.Get(ctx, types.NamespacedName{Namespace: targetNs, Name: targetName}, existingSecret); err != nil {
316316
return false, errors.Wrapf(err, "failed to get secret %s/%s", targetNs, targetName)
317317
}
318318

@@ -413,7 +413,7 @@ func (r *Reconciler) copyConfigmap(ctx context.Context, sourceName, targetName,
413413
if apierrors.IsAlreadyExists(err) {
414414
// If already exist, update the ConfigMap
415415
existingCm := &corev1.ConfigMap{}
416-
if err := r.Client.Get(ctx, types.NamespacedName{Namespace: targetNs, Name: targetName}, existingCm); err != nil {
416+
if err := r.Reader.Get(ctx, types.NamespacedName{Namespace: targetNs, Name: targetName}, existingCm); err != nil {
417417
return false, errors.Wrapf(err, "failed to get ConfigMap %s/%s", targetNs, targetName)
418418
}
419419

@@ -518,7 +518,7 @@ func (r *Reconciler) copyRoute(ctx context.Context, route operatorv1alpha1.Route
518518
if apierrors.IsAlreadyExists(err) {
519519
// If already exist, update the ConfigMap
520520
existingCm := &corev1.ConfigMap{}
521-
if err := r.Client.Get(ctx, types.NamespacedName{Namespace: targetNs, Name: targetName}, existingCm); err != nil {
521+
if err := r.Reader.Get(ctx, types.NamespacedName{Namespace: targetNs, Name: targetName}, existingCm); err != nil {
522522
return false, errors.Wrapf(err, "failed to get ConfigMap %s/%s", targetNs, targetName)
523523
}
524524
if needUpdate := util.CompareConfigMap(cmCopy, existingCm); needUpdate {
@@ -614,7 +614,7 @@ func (r *Reconciler) copyService(ctx context.Context, service operatorv1alpha1.S
614614
if apierrors.IsAlreadyExists(err) {
615615
// If already exist, update the ConfigMap
616616
existingCm := &corev1.ConfigMap{}
617-
if err := r.Client.Get(ctx, types.NamespacedName{Namespace: targetNs, Name: targetName}, existingCm); err != nil {
617+
if err := r.Reader.Get(ctx, types.NamespacedName{Namespace: targetNs, Name: targetName}, existingCm); err != nil {
618618
return false, errors.Wrapf(err, "failed to get ConfigMap %s/%s", targetNs, targetName)
619619
}
620620
if needUpdate := util.CompareConfigMap(cmCopy, existingCm); needUpdate {

0 commit comments

Comments
 (0)