Skip to content

Commit 0a08b56

Browse files
committed
OpenShiftP-281: update the CreateClaimSpecFile function to account for maximum one /dev/crypto/nx-gzip
Signed-off-by: Paul Bastide <[email protected]>
1 parent 6642852 commit 0a08b56

File tree

2 files changed

+21
-17
lines changed

2 files changed

+21
-17
lines changed

cmd/power-dra-kubeletplugin/cdi.go

Lines changed: 20 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -73,29 +73,34 @@ func (cdi *CDIHandler) CreateCommonSpecFile() error {
7373
func (cdi *CDIHandler) CreateClaimSpecFile(claimUID string, devices PreparedDevices) error {
7474
specName := cdiapi.GenerateTransientSpecName(cdiVendor, cdiClass, claimUID)
7575

76+
// Only one device is used for nx-gzip
77+
deviceAdds := []cdispec.Device{
78+
cdispec.Device{
79+
Name: "crypto/nx-gzip",
80+
},
81+
}
82+
7683
spec := &cdispec.Spec{
7784
Kind: cdiKind,
78-
Devices: []cdispec.Device{},
85+
Devices: deviceAdds,
7986
}
8087

81-
for _, device := range devices {
82-
claimEdits := cdiapi.ContainerEdits{
83-
ContainerEdits: &cdispec.ContainerEdits{
84-
Env: []string{
85-
fmt.Sprintf("Nx_DEVICE_%s_RESOURCE_CLAIM=%s", device.DeviceName[4:], claimUID),
86-
},
88+
claimEdits := cdiapi.ContainerEdits{
89+
ContainerEdits: &cdispec.ContainerEdits{
90+
Env: []string{
91+
"NX_DEVICE_CLAIM=added",
8792
},
88-
}
89-
claimEdits.Append(device.ContainerEdits)
90-
91-
cdiDevice := cdispec.Device{
92-
Name: fmt.Sprintf("%s-%s", claimUID, device.DeviceName),
93-
ContainerEdits: *claimEdits.ContainerEdits,
94-
}
93+
},
94+
}
9595

96-
spec.Devices = append(spec.Devices, cdiDevice)
96+
// At this point
97+
cdiDevice := cdispec.Device{
98+
Name: fmt.Sprintf("%s-%s", claimUID, "crypto/nx-gzip"),
99+
ContainerEdits: *claimEdits.ContainerEdits,
97100
}
98101

102+
spec.Devices = append(spec.Devices, cdiDevice)
103+
99104
minVersion, err := cdiapi.MinimumRequiredVersion(spec)
100105
if err != nil {
101106
return fmt.Errorf("failed to get minimum required CDI spec version: %v", err)

cmd/power-dra-kubeletplugin/discovery.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ func enumerateAllPossibleDevices(numNx int) (AllocatableDevices, error) {
2626
return alldevices, nil
2727
}
2828

29-
// prepopulate
30-
29+
// prepopulate with a single nx-gzip
3130
device := resourceapi.Device{
3231
Name: "crypto/nx-gzip",
3332
Basic: &resourceapi.BasicDevice{

0 commit comments

Comments
 (0)