fix: rename ui Context tab -> Messages and Raw Trace -> Trace

Also a minor code cleanup to DrawerContentBody

Signed-off-by: Nick Mitchell <[email protected]>

Author: starpit

pdl-live-react/src/view/detail/DrawerContentBody.tsx

@@ -14,15 +14,6 @@ import {
   type NonScalarPdlBlock as Model,
 } from "../../helpers"
 
-function defBody(_def: string | null, block: Model) {
-  const value = hasResult(block) ? block.pdl__result : undefined
-  return (
-    <Tab eventKey={0} title={<TabTitleText>Value</TabTitleText>}>
-      {!value ? "Value not found" : <DefContent value={value} />}
-    </Tab>
-  )
-}
-
 function blockBody(block: Model) {
   const tabs = [
     <Tab key={0} eventKey={0} title={<TabTitleText>Summary</TabTitleText>}>
@@ -35,7 +26,7 @@ function blockBody(block: Model) {
         <SourceTabContent block={block} />
       </Suspense>
     </Tab>,
-    <Tab key={2} eventKey={2} title={<TabTitleText>Raw Trace</TabTitleText>}>
+    <Tab key={2} eventKey={2} title={<TabTitleText>Trace</TabTitleText>}>
       <Suspense>
         <RawTraceTabContent block={block} />
       </Suspense>
@@ -46,7 +37,7 @@ function blockBody(block: Model) {
     tabs.splice(
       1,
       0,
-      <Tab key={3} eventKey={3} title={<TabTitleText>Context</TabTitleText>}>
+      <Tab key={3} eventKey={3} title={<TabTitleText>Messages</TabTitleText>}>
         <Suspense>
           <ContextTabContent block={block} />
         </Suspense>
@@ -68,29 +59,27 @@ type Props = {
 export default function DrawerContentBody({
   id,
   value,
-  def,
   objectType,
   model,
 }: Props) {
+  if (!model) {
+    return (
+      <Suspense fallback={<div />}>
+        <BlockNotFound pdl__id={id} value={value} />
+      </Suspense>
+    )
+  }
+
   switch (objectType) {
-    case "def":
-      if (!model) {
-        return (
-          <Suspense>
-            <BlockNotFound pdl__id={id} value={value} />
-          </Suspense>
-        )
-      }
-      return defBody(def, model)
+    case "def": {
+      const value = hasResult(model) ? model.pdl__result : undefined
+      return (
+        <Tab eventKey={0} title={<TabTitleText>Value</TabTitleText>}>
+          {!value ? "Value not found" : <DefContent value={value} />}
+        </Tab>
+      )
+    }
     default:
-      if (!model) {
-        return (
-          <Suspense>
-            <BlockNotFound pdl__id={id} value={value} />
-          </Suspense>
-        )
-      }
-
       return blockBody(model)
   }
 }