updated docs README, removed logger (#617)

* updated docs README, removed logger

Signed-off-by: Mandana Vaziri <[email protected]>

* telemetry

Signed-off-by: Mandana Vaziri <[email protected]>

---------

Signed-off-by: Mandana Vaziri <[email protected]>

Author: vazirim

docs/README.md

@@ -54,8 +54,6 @@ Follow the following instructions to set up a dev environment to get started wit
     Hello! How can I help you today?
     ```
 
-You are all set!
-
 ### Documentation updates
 
 When you make changes to PDL, ensure to document any new features in the docs section. You can serve the docs locally to preview changes.

docs/assets/telemetry.png

@@ -4,8 +4,6 @@ text:
 # Define GEN to be the result of a Granite LLM using ollama
 - model: ollama/granite-code:8b
   parameters:
-    # "greedy" sampling tells the LLM to use the most likely token at each step
-    # decoding_method: greedy # Not used by Ollama
     # Tell the LLM to stop after generating an exclamation point.
     stop: ['!']
   def: GEN

docs/contrib.md

@@ -436,16 +436,6 @@
     "\n"
    ]
   },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "id": "9b919506-79ed-4a13-ac1d-1fdfc3e4f9d9",
-   "metadata": {},
-   "outputs": [],
-   "source": [
-    "! cat log.txt"
-   ]
-  },
   {
    "cell_type": "markdown",
    "id": "89438b62-29e4-472e-89ec-57c1626ffd44",

examples/hello/hello-def-use.pdl

@@ -1,6 +1,5 @@
 import argparse
 import json
-import logging
 import sys
 from pathlib import Path
 from typing import Any, Literal, Optional, TypedDict
@@ -25,8 +24,6 @@
 from .pdl_runner import exec_docker
 from .pdl_utils import validate_scope
 
-logger = logging.getLogger(__name__)
-
 
 class InterpreterConfig(TypedDict, total=False):
     """Configuration parameters of the PDL interpreter."""
@@ -68,7 +65,6 @@ def exec_program(
     Returns:
         Return the final result if `output` is set to `"result"`. If set of `all`, it returns a dictionary containing, `result`, `scope`, and `trace`.
     """
-    logging.basicConfig(filename="log.txt", encoding="utf-8", format="", filemode="w")
     config = config or {}
     state = InterpreterState(**config)
     if not isinstance(scope, PdlDict):
@@ -189,11 +185,6 @@ def main():
         const="*_trace.json",
         help="output trace for live document and optionally specify the file name",
     )
-    parser.add_argument(
-        "-l",
-        "--log",
-        help="specify a name for the log file",
-    )
     parser.add_argument(
         "--schema",
         action="store_true",
@@ -278,7 +269,6 @@ def main():
     )
     pdl_interpreter.generate(
         pdl_file,
-        args.log,
         InterpreterState(**config),
         PdlDict(initial_scope),
         trace_file,

examples/notebooks/demo.ipynb

@@ -1,5 +1,4 @@
 import json
-import logging
 import re
 import shlex
 import subprocess  # nosec
@@ -103,9 +102,6 @@
     stringify,
 )
 
-logger = logging.getLogger(__name__)
-
-
 empty_scope: ScopeType = PdlDict({"pdl_context": PdlList([])})
 
 
@@ -145,7 +141,6 @@ def with_pop(self: "InterpreterState") -> "InterpreterState":
 
 def generate(
     pdl_file: str | Path,
-    log_file: Optional[str | Path],
     state: Optional[InterpreterState],
     initial_scope: ScopeType,
     trace_file: Optional[str | Path],
@@ -154,14 +149,10 @@ def generate(
 
     Args:
         pdl_file: Program to execute.
-        log_file: File where the log is written. If `None`, use `log.txt`.
         initial_scope: Environment defining the variables in scope to execute the program.
         state: Initial state of the interpreter.
         trace_file: Indicate if the execution trace must be produced and the file to save it.
     """
-    if log_file is None:
-        log_file = "log.txt"
-    logging.basicConfig(filename=log_file, encoding="utf-8", format="", filemode="w")
     try:
         prog, loc = parse_file(pdl_file)
         if state is None:
@@ -271,7 +262,6 @@ def process_block(
                 yield_background(background)
             if state.yield_result:
                 yield_result(result.result(), BlockKind.DATA)
-            append_log(state, "pdl_context", background)
         else:
             result, background, scope, trace = process_advanced_block_timed(
                 state, scope, block, loc
@@ -653,8 +643,6 @@ def process_block_body(
                     ) from exc
                 match_case_trace = match_case.model_copy(update={"then": then_trace})
                 cases.append(match_case_trace)
-            if not matched:
-                append_log(state, "Match", "no match!")
             block.with_ = cases
             trace = block
         case RepeatBlock():
@@ -1264,18 +1252,12 @@ def get_transformed_inputs(kwargs):
             litellm_params = params_to_model
 
         litellm.input_callback = [get_transformed_inputs]
-        # append_log(state, "Model Input", messages_to_str(model_input))
 
         msg, raw_result = generate_client_response(state, concrete_block, model_input)
-        # if "input" in litellm_params:
-        append_log(state, "Model Input", litellm_params)
-        # else:
-        #    append_log(state, "Model Input", messages_to_str(model_input))
         background: LazyMessages = PdlList([lazy_apply(lambda msg: msg | {"defsite": block.id}, msg)])  # type: ignore
         result = lazy_apply(
             lambda msg: "" if msg["content"] is None else msg["content"], msg
         )
-        append_log(state, "Model Output", result)
         trace = block.model_copy(update={"result": result, "trace": concrete_block})
         if block.modelResponse is not None:
             scope = scope | {block.modelResponse: raw_result}
@@ -1423,7 +1405,6 @@ def process_call_code(
         loc,
     )
     code_s = code_.result()
-    append_log(state, "Code Input", code_s)
     match block.lang:
         case "python":
             try:
@@ -1495,7 +1476,6 @@ def process_call_code(
                 loc=loc,
                 trace=block.model_copy(),
             )
-    append_log(state, "Code Output", result)
     trace = block.model_copy(update={"result": result})
     return result, background, scope, trace
 
@@ -1615,7 +1595,6 @@ def process_input(
         try:
             with open(file, encoding="utf-8") as f:
                 s = f.read()
-                append_log(state, "Input from File: " + str(file), s)
         except Exception as exc:
             if isinstance(exc, FileNotFoundError):
                 msg = f"file {str(file)} not found"
@@ -1637,7 +1616,6 @@ def process_input(
             message = "Enter/Paste your content. Ctrl-D to save it."
         if block.multiline is False:
             s = input(message)
-            append_log(state, "Input from stdin: ", s)
         else:  # multiline
             print(message)
             contents = []
@@ -1648,7 +1626,6 @@ def process_input(
                     break
                 contents.append(line + "\n")
             s = "".join(contents)
-            append_log(state, "Input from stdin: ", s)
     trace = block.model_copy(update={"result": s})
     background: LazyMessages = PdlList(
         [PdlDict({"role": state.role, "content": s, "defsite": block.id})]  # type: ignore
@@ -1802,8 +1779,3 @@ def parse_result(parser: ParserType, text: str) -> JSONReturnType:
 
 def get_var(var: str, scope: ScopeType, loc: LocationType) -> Any:
     return process_expr(scope, f"{EXPR_START_STRING} {var} {EXPR_END_STRING}", loc)
-
-
-def append_log(state: InterpreterState, title, somestring):
-    logger.warning("**********  %s  **********", title)
-    # logger.warning(str(somestring)) # XXX TODO: Logging without forcing lazy values

src/pdl/pdl.py

@@ -4,7 +4,7 @@
 
 
 def do_test(t, capsys):
-    generate(t["file"], None, None, empty_scope, None)
+    generate(t["file"], None, empty_scope, None)
     captured = capsys.readouterr()
     output_string = captured.out + "\n" + captured.err
     output = output_string.split("\n")