Skip to content

Commit 506b6ac

Browse files
committed
use a vertical orientation for Run page
Signed-off-by: Nick Mitchell <[email protected]>
1 parent ace9a85 commit 506b6ac

File tree

2 files changed

+44
-53
lines changed

2 files changed

+44
-53
lines changed

pdl-live-react/src/page/Run.css

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1 @@
11
@import "../view/term/RunTerminal.css";
2-
3-
.pdl-run-page-section {
4-
.pdl-run-split-item-card-header,
5-
.pdl-run-split-item-card-body {
6-
padding-inline-start: 0;
7-
padding-right: 0;
8-
}
9-
}

pdl-live-react/src/page/Run.tsx

Lines changed: 44 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -88,51 +88,7 @@ export default function Run() {
8888

8989
return (
9090
<Page breadcrumb1="Run">
91-
<PageSection className="pdl-run-page-section">
92-
<Flex>
93-
<FlexItem flex={{ default: "flex_1" }}>
94-
<Card isPlain>
95-
<CardHeader className="pdl-run-split-item-card-header">
96-
<CardTitle>Program</CardTitle>
97-
</CardHeader>
98-
<CardBody className="pdl-run-split-item-card-body">
99-
<div style={{ height: "600px" }}>
100-
<CodeEditor
101-
onEditorDidMount={(editor, _monaco) => {
102-
editor.layout()
103-
}}
104-
options={{ fontSize: 16 }}
105-
aria-label="text area to provide PDL program source"
106-
code={initialInput}
107-
isDarkTheme
108-
isFullHeight
109-
language={Language.yaml}
110-
onChange={(value) => {
111-
setError(false)
112-
setInput(value)
113-
}}
114-
/>
115-
</div>
116-
</CardBody>
117-
</Card>
118-
</FlexItem>
119-
120-
<FlexItem flex={{ default: "flex_1" }}>
121-
<Card isPlain>
122-
<CardHeader className="pdl-run-split-item-card-header">
123-
<CardTitle>Output</CardTitle>
124-
</CardHeader>
125-
<CardBody className="pdl-run-split-item-card-body">
126-
<div
127-
className="pdl-run-terminal"
128-
ref={xtermRef}
129-
style={{ height: "600px" }}
130-
/>
131-
</CardBody>
132-
</Card>
133-
</FlexItem>
134-
</Flex>
135-
91+
<PageSection type="subnav">
13692
<Toolbar>
13793
<ToolbarContent>
13894
<ToolbarItem>
@@ -143,6 +99,49 @@ export default function Run() {
14399
</ToolbarContent>
144100
</Toolbar>
145101
</PageSection>
102+
103+
<PageSection
104+
className="pdl-run-page-section"
105+
padding={{ default: "noPadding" }}
106+
>
107+
<Card isCompact isPlain>
108+
<CardHeader className="pdl-run-split-item-card-header">
109+
<CardTitle>Program</CardTitle>
110+
</CardHeader>
111+
<CardBody className="pdl-run-split-item-card-body">
112+
<div style={{ height: "300px" }}>
113+
<CodeEditor
114+
onEditorDidMount={(editor, _monaco) => {
115+
editor.layout()
116+
}}
117+
options={{ fontSize: 16 }}
118+
aria-label="text area to provide PDL program source"
119+
code={initialInput}
120+
isDarkTheme
121+
isFullHeight
122+
language={Language.yaml}
123+
onChange={(value) => {
124+
setError(false)
125+
setInput(value)
126+
}}
127+
/>
128+
</div>
129+
</CardBody>
130+
</Card>
131+
132+
<Card isCompact isPlain>
133+
<CardHeader className="pdl-run-split-item-card-header">
134+
<CardTitle>Output</CardTitle>
135+
</CardHeader>
136+
<CardBody className="pdl-run-split-item-card-body">
137+
<div
138+
className="pdl-run-terminal"
139+
ref={xtermRef}
140+
style={{ height: "400px" }}
141+
/>
142+
</CardBody>
143+
</Card>
144+
</PageSection>
146145
</Page>
147146
)
148147
}

0 commit comments

Comments
 (0)