Syntax error analyzer handles defs (#80)

* Analyzing errors in defs

Signed-off-by: Mandana Vaziri <[email protected]>

* cleanup

Signed-off-by: Mandana Vaziri <[email protected]>

---------

Signed-off-by: Mandana Vaziri <[email protected]>

Author: vazirim

pdl/pdl_schema_error_analyzer.py

@@ -117,6 +117,14 @@ def analyze_errors(defs, schema, data, loc: LocationType) -> list[str]:  # noqa:
                     ret += analyze_errors(
                         defs, schema["properties"][field], data[field], newloc
                     )
+            if "additionalProperties" in schema.keys() and not isinstance(
+                schema["additionalProperties"], bool
+            ):
+                for key, value in data.items():
+                    nloc = append(loc, key)
+                    ret += analyze_errors(
+                        defs, schema["additionalProperties"], value, nloc
+                    )
 
     elif is_any_of(schema):
         if len(schema["anyOf"]) == 2 and nullable(schema):

tests/data/line/hello31.pdl

@@ -0,0 +1,11 @@
+defs:
+
+  # ... several other defs, ~85 lines
+  get_current_weather:
+    function:
+      subject: str
+    return:
+      api: https
+      url: https://api.weatherapi.com/v1/current.json?key=cf601276764642cb96224947230712&q=
+      input: "{{ subject }}"
+      show_result: false

tests/test_examples.py

@@ -13,6 +13,7 @@
     pathlib.Path("tests") / "data" / "line" / "hello8.pdl",
     pathlib.Path("tests") / "data" / "line" / "hello10.pdl",
     pathlib.Path("tests") / "data" / "line" / "hello11.pdl",
+    pathlib.Path("tests") / "data" / "line" / "hello31.pdl",
 ]
 
 

tests/test_line_table.py

@@ -405,3 +405,18 @@ def test_line29(capsys):
 
 def test_line30(capsys):
     do_test(line30, capsys)
+
+
+line31 = {
+    "file": "tests/data/line/hello31.pdl",
+    "errors": [
+        "",
+        "tests/data/line/hello31.pdl:0 - Missing required field: function",
+        "tests/data/line/hello31.pdl:0 - Missing required field: return",
+        "tests/data/line/hello31.pdl:11 - Field not allowed: show_result",
+    ],
+}
+
+
+def test_line31(capsys):
+    do_test(line31, capsys)